3.2.0 as submitted to CRAN #2726
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit b7a34d1.
AshesITR
reviewed
Feb 12, 2025
| # large files not needed for CRAN | ||
| ^man/figures/logo[.]png$ | ||
| # keep '-still.gif' compact versions | ||
| ^vignettes/.*([^l]|[^l]l|[^i]ll|[^t]ill|[^s]till)[.]gif$ |
Collaborator
There was a problem hiding this comment.
Is negative lookbehind supported?
^vignettes/.*(?<!still)[.]gif$
Collaborator
Author
There was a problem hiding this comment.
It should be as the match is with perl=TRUE:
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the last-minute changes I made to tidy up the submission.
Merging without review to reflect what was submitted with fidelity. That also means it subsumes #2719 so I'll close that too.