Read HSB colors in RGB and CMYK color modes #361
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyamagu
reviewed
Jun 20, 2023
Contributor
kyamagu
left a comment
There was a problem hiding this comment.
Thanks for catching this issue. My only question is about the necessity of always passing the entire low-level PSD structure, as it seems only the target color mode matters in the end. I understand that the function signature must be uniform in _get_xxx.
src/psd_tools/composite/vector.py
Outdated
|
|
||
|
|
||
| def _get_color(desc) -> Tuple[float, ...]: | ||
| def _get_color(psd, desc) -> Tuple[float, ...]: |
Contributor
There was a problem hiding this comment.
Is that really necessary to always pass the entire PSD structure or only the color mode property?
Contributor
Author
There was a problem hiding this comment.
You're right, the color_mode only is sufficient. I've update the code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
I saw some files (as the one added in the test corpus), where the color
Klassdoesn't match the color-mode of the PSD file. Specifically I've seen HSB colors in files with RGB and CMYK color modes.These types of colors seem to come from other softwares (Affinity Designer) as Photoshop itself seems to always convert the HSB values to match the color mode of the file when saving. However Photoshop supports opening files with HSB color when the color mode RGB or CMYK (I haven't had the opportunity to test with other color modes).