Skip to content

Add support for ClientSideWeightedRoundRobin LB policy #6999

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add support for ClientSideWeightedRoundRobin LB policy #6999

wants to merge 1 commit into from
+1,606 −4

Conversation

anton-kuklin
Copy link

Fixes #6998

@anton-kuklin anton-kuklin requested a review from a team as a code owner April 15, 2025 17:33
@anton-kuklin anton-kuklin requested review from sunjayBhatia and tsaarni and removed request for a team April 15, 2025 17:33
@sunjayBhatia sunjayBhatia requested review from a team, rajatvig and wilsonwu and removed request for a team April 15, 2025 17:34
@github-actions GitHub Actions
Copy link

Hi @anton-kuklin! Welcome to our community and thank you for opening your first Pull Request. Someone will review it soon. Thank you for committing to making Contour better. You can also join us on our mailing list and in our channel in the Kubernetes Slack Workspace

@anton-kuklin
Copy link
Author

anton-kuklin commented Apr 15, 2025 •
edited
Loading

CC: @davinci26 @clayton-gonsalves @seth-epps @shadialtarsha @gregbarasch

@tsaarni tsaarni added the release-note/minor A minor change that needs about a paragraph of explanation in the release notes. label Apr 15, 2025
@codecov Codecov
Copy link

codecov bot commented Apr 15, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 94.02985% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.81%. Comparing base (cdf2738) to head (049fa51).
⚠️ Report is 127 commits behind head on main.

Files with missing lines Patch % Lines
internal/dag/extension_processor.go 42.85% 3 Missing and 1 partial ⚠️
internal/dag/httpproxy_processor.go 42.85% 3 Missing and 1 partial ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #6999      +/-   ##
==========================================
+ Coverage   80.72%   80.81%   +0.08%     
==========================================
  Files         131      131              
  Lines       19868    19996     +128     
==========================================
+ Hits        16039    16159     +120     
- Misses       3537     3543       +6     
- Partials      292      294       +2
Files with missing lines Coverage Δ
internal/dag/dag.go 98.78% <ø> (ø)
internal/dag/policy.go 96.02% <100.00%> (+0.34%) ⬆️
internal/envoy/v3/cluster.go 96.97% <100.00%> (+0.66%) ⬆️
internal/dag/extension_processor.go 93.87% <42.85%> (-2.56%) ⬇️
internal/dag/httpproxy_processor.go 90.76% <42.85%> (-0.24%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

davinci26
davinci26 approved these changes Apr 15, 2025
View reviewed changes
Copy link
Contributor

@davinci26 davinci26 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved the internal version of the PR so lgtm

@github-actions GitHub Actions
Copy link

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 30d of inactivity, lifecycle/stale is applied
  • After 60d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels May 16, 2025
@github-actions GitHub Actions
Copy link

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 30d of inactivity, lifecycle/stale is applied
  • After 60d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jun 16, 2025
@github-actions GitHub Actions
Copy link

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 30d of inactivity, lifecycle/stale is applied
  • After 60d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 17, 2025
sunjayBhatia
sunjayBhatia reviewed Sep 4, 2025
View reviewed changes
apis/projectcontour/v1/httpproxy.go
// calculated as eps/qps.
ErrorUtilizationPenalty string `json:"errorUtilizationPenalty,omitempty"`

// By default, endpoint weight is computed based on the :ref:`application_utilization <envoy_v3_api_field_.xds.data.orca.v3.OrcaLoadReport.application_utilization>` field reported by the endpoint.
Copy link
Member

@sunjayBhatia sunjayBhatia Sep 4, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets clean this up a bit to not include the envoy doc reference fields/links in our CRDs here

@github-actions github-actions bot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Sep 5, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 5, 2025

The Contour project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 30d of inactivity, lifecycle/stale is applied
  • After 60d of inactivity since lifecycle/stale was applied, the PR is closed

You can:

  • Ensure your PR is passing all CI checks. PRs that are fully green are more likely to be reviewed. If you are having trouble with CI checks, reach out to the #contour channel in the Kubernetes Slack workspace.
  • Mark this PR as fresh by commenting or pushing a commit
  • Close this PR
  • Offer to help out with triage

Please send feedback to the #contour channel in the Kubernetes Slack

@github-actions github-actions bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sunjayBhatia sunjayBhatia sunjayBhatia left review comments

@tsaarni tsaarni Awaiting requested review from tsaarni tsaarni is a code owner automatically assigned from projectcontour/maintainers

@rajatvig rajatvig Awaiting requested review from rajatvig rajatvig was automatically assigned from projectcontour/contour-reviewers

@wilsonwu wilsonwu Awaiting requested review from wilsonwu wilsonwu was automatically assigned from projectcontour/contour-reviewers

+1 more reviewer

@davinci26 davinci26 davinci26 approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. release-note/minor A minor change that needs about a paragraph of explanation in the release notes.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support ClientSideWeightedRoundRobin LB policy

4 participants

@anton-kuklin @sunjayBhatia @davinci26 @tsaarni