[Release 1.18] Cherry-pick: Allow retry policy, num retries to be zero #4174
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…4117) Since the current field for NumRetries is not a pointer, Contour doesn't have a good way to understand if the field is unspecified, or set to zero. To keep the v1 API contract, Contour will allow this field to be set to -1 which means the numRetries should be zero. If unspecified or set to zero, then the Envoy default of 1 is used. Signed-off-by: Steve Sloka <[email protected]>
Codecov Report
@@ Coverage Diff @@
## release-1.18 #4174 +/- ##
================================================
+ Coverage 77.65% 77.66% +0.01%
================================================
Files 112 112
Lines 8977 8990 +13
================================================
+ Hits 6971 6982 +11
- Misses 1857 1859 +2
Partials 149 149
|
sunjayBhatia
approved these changes
Nov 11, 2021
skriss
approved these changes
Nov 11, 2021
Signed-off-by: Nick Young <[email protected]>
b6c994f to
8c2e19e
Compare
Member
Author
|
Merging this with admin powers so I can get the release cut. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick PR #4117 to release-1.18, in preparation for a 1.18.3 release.
Updates #4168
Original commit message below.
Since the current field for NumRetries is not a pointer, Contour
doesn't have a good way to understand if the field is unspecified,
or set to zero.
To keep the v1 API contract, Contour will allow this field to be set
to -1 which means the numRetries should be zero. If unspecified or set
to zero, then the Envoy default of 1 is used.
Signed-off-by: Steve Sloka [email protected]