[release-1.18] internal/dag: don't walk DAG to look for service (#4061) #4066
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removes code that walks the DAG looking for a matching existing Service when adding a new Service. This code is very inefficient when the DAG is large and creates a performance bottleneck. Some extra memory may end up being used if duplicate Services are created, but it's unlikely to be a material issue in practice. Closes projectcontour#4058. Signed-off-by: Steve Kriss <[email protected]>
Member
Author
|
Codegen is failing due to #3996, should be ignored since the script is broken. |
Codecov Report
@@ Coverage Diff @@
## release-1.18 #4066 +/- ##
================================================
- Coverage 77.68% 77.65% -0.04%
================================================
Files 112 112
Lines 8999 8977 -22
================================================
- Hits 6991 6971 -20
+ Misses 1859 1857 -2
Partials 149 149
|
Member
|
@skriss codegen failed? |
Member
Author
See #4066 (comment) |
Member
|
Oh right, forgot about that! |
stevesloka
approved these changes
Oct 1, 2021
sunjayBhatia
approved these changes
Oct 1, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes code that walks the DAG looking for
a matching existing Service when adding a
new Service. This code is very inefficient
when the DAG is large and creates a
performance bottleneck. Some extra memory
may end up being used if duplicate Services
are created, but it's unlikely to be a
material issue in practice.
Closes #4058.
Signed-off-by: Steve Kriss [email protected]