Add BLE APIs to allow commissioning using concatenated QR codes. #38922
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #38922: Size comparison from ebe16b7 to b203ba3 Full report (27 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, qpg, stm32, telink, tizen)
|
jmartinez-silabs
approved these changes
May 13, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR introduces BLE APIs to support commissioning using concatenated QR codes by adding new connection methods based on discriminators.
- Added CancelBleIncompleteConnection API and updated documentation in BleLayer.h
- Introduced NewBleConnectionByDiscriminators API with corresponding implementation in BleLayer.cpp
- Updated BleConnectionDelegate.h to include a new NewConnection overload for multiple discriminators
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/ble/BleLayer.h | New BLE APIs declared and added include dependency for Span support |
| src/ble/BleLayer.cpp | Added implementation for NewBleConnectionByDiscriminators with state verification |
| src/ble/BleConnectionDelegate.h | Updated delegate interface with new connection callback for multiple discriminators |
For now not implemented; platforms will need to provide implementations.
b203ba3 to
080ec2e
Compare
|
PR #38922: Size comparison from fdacd16 to 080ec2e Full report (73 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
kiel-apple
approved these changes
May 13, 2025
heinsaar
pushed a commit
to heinsaar/connectedhomeip
that referenced
this pull request
May 15, 2025
…ject-chip#38922) For now not implemented; platforms will need to provide implementations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For now not implemented; platforms will need to provide implementations.
Testing
CI will test that this compiles. Nothing else to test yet.