[Closures] Update Closure dimension cluster as per latest specification #38424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9feb795 to
8fc31ed
Compare
mkardous-silabs
approved these changes
Apr 17, 2025
src/app/clusters/closure-dimension-server/closure-dimension-cluster-logic.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/closure-dimension-server/closure-dimension-cluster-logic.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/closure-dimension-server/closure-dimension-cluster-logic.cpp
Outdated
Show resolved
Hide resolved
|
PR #38424: Size comparison from 88bff31 to 4a396c5 Full report (3 builds for cc32xx, stm32)
|
andy31415
reviewed
Apr 17, 2025
src/app/zap-templates/zcl/data-model/chip/closure-dimension-cluster.xml
Outdated
Show resolved
Hide resolved
andy31415
approved these changes
Apr 17, 2025
arkq
pushed a commit
to arkq/connectedhomeip
that referenced
this pull request
Apr 22, 2025
…on (project-chip#38424) * Update Closure dimension cluster as per latest specification * Adding missing zap files * Updating server implementation as per new spec changes * Removing constrain check for boolean * Restyled by clang-format * Restyled by prettier-json * Add missing Git SHA in XML * Removing old struct files --------- Co-authored-by: sabollim <[email protected]> Co-authored-by: Restyled.io <[email protected]>
dsavitsky-dsr
pushed a commit
to popovdg/connectedhomeip
that referenced
this pull request
Apr 22, 2025
…on (project-chip#38424) * Update Closure dimension cluster as per latest specification * Adding missing zap files * Updating server implementation as per new spec changes * Removing constrain check for boolean * Restyled by clang-format * Restyled by prettier-json * Add missing Git SHA in XML * Removing old struct files --------- Co-authored-by: sabollim <[email protected]> Co-authored-by: Restyled.io <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add:
XML code generated using Alchemy for closure dimension cluster spec updates
ZAP-generated code based on the closure dimension specification updates.
Closure dimension server code updates as per the new specification
Reference Specification SHA ba6044ef35590c19ba55475654c16440ac2982bd used for this PR
Testing
New files are built successfully locally. (Closure App CI is currently disabled during the rework - local tests are the only validation)