Skip to content

Conversation

sabollim-silabs
Copy link
Contributor

@sabollim-silabs sabollim-silabs commented Apr 16, 2025

This PR aims to add:

XML code generated using Alchemy for closure dimension cluster spec updates
ZAP-generated code based on the closure dimension specification updates.
Closure dimension server code updates as per the new specification

Reference Specification SHA ba6044ef35590c19ba55475654c16440ac2982bd used for this PR

Testing

New files are built successfully locally. (Closure App CI is currently disabled during the rework - local tests are the only validation)

@sabollim-silabs sabollim-silabs requested review from a team as code owners April 16, 2025 09:55
@sabollim-silabs sabollim-silabs marked this pull request as draft April 16, 2025 09:55
@sabollim-silabs sabollim-silabs changed the title [Closures] Update Closure dimension cluster as per latest specification [Closures] [WIP] Update Closure dimension cluster as per latest specification Apr 16, 2025
@sabollim-silabs sabollim-silabs force-pushed the closure/closure_dimension_cluster_spec_update_changes branch from 9feb795 to 8fc31ed Compare April 17, 2025 14:18
Copy link

PR #38424: Size comparison from 88bff31 to 8fc31ed

Full report (1 build for stm32)
platform target config section 88bff31 8fc31ed change % change
stm32 light STM32WB5MM-DK FLASH 462928 462928 0 0.0
RAM 141488 141488 0 0.0

Copy link
Contributor

@mkardous-silabs mkardous-silabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With the nit of the valid boolean check

@mkardous-silabs mkardous-silabs marked this pull request as ready for review April 17, 2025 16:55
@mkardous-silabs mkardous-silabs changed the title [Closures] [WIP] Update Closure dimension cluster as per latest specification [Closures] Update Closure dimension cluster as per latest specification Apr 17, 2025
@mkardous-silabs mkardous-silabs added the skip-protocol-compatibility Marker that protocol backwards compatibility checks are to be skipped label Apr 17, 2025
Copy link

PR #38424: Size comparison from 88bff31 to 4a396c5

Full report (3 builds for cc32xx, stm32)
platform target config section 88bff31 4a396c5 change % change
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 542378 542378 0 0.0
RAM 205144 205144 0 0.0
lock CC3235SF_LAUNCHXL FLASH 576366 576366 0 0.0
RAM 205392 205392 0 0.0
stm32 light STM32WB5MM-DK FLASH 462928 462928 0 0.0
RAM 141488 141488 0 0.0

@mergify mergify bot merged commit ff5490a into project-chip:master Apr 19, 2025
75 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in [Platform] Darwin Apr 19, 2025
arkq pushed a commit to arkq/connectedhomeip that referenced this pull request Apr 22, 2025
…on (project-chip#38424)

* Update Closure dimension cluster as per latest specification

* Adding missing zap files

* Updating server implementation as per new spec changes

* Removing constrain check for boolean

* Restyled by clang-format

* Restyled by prettier-json

* Add missing Git SHA in XML

* Removing old struct files

---------

Co-authored-by: sabollim <[email protected]>
Co-authored-by: Restyled.io <[email protected]>
dsavitsky-dsr pushed a commit to popovdg/connectedhomeip that referenced this pull request Apr 22, 2025
…on (project-chip#38424)

* Update Closure dimension cluster as per latest specification

* Adding missing zap files

* Updating server implementation as per new spec changes

* Removing constrain check for boolean

* Restyled by clang-format

* Restyled by prettier-json

* Add missing Git SHA in XML

* Removing old struct files

---------

Co-authored-by: sabollim <[email protected]>
Co-authored-by: Restyled.io <[email protected]>
@sabollim-silabs sabollim-silabs deleted the closure/closure_dimension_cluster_spec_update_changes branch May 19, 2025 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app controller darwin review - approved skip-protocol-compatibility Marker that protocol backwards compatibility checks are to be skipped

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants