Skip to content

Additional RVC Operational States and Errors #38420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 24, 2025
Merged

Additional RVC Operational States and Errors #38420

merged 8 commits into from
Apr 24, 2025

Conversation

kiel-apple
Copy link
Contributor

Provisional additions for 1.5.

Testing

New enums should have no effect on existing code.

@kiel-apple kiel-apple added enhancement New feature or request examples spec Mismatch between spec and implementation robot vacuums v1.5 labels Apr 15, 2025
@kiel-apple kiel-apple self-assigned this Apr 15, 2025
@kiel-apple kiel-apple marked this pull request as ready for review April 15, 2025 22:25
@kiel-apple kiel-apple requested a review from a team as a code owner April 15, 2025 22:25
@kiel-apple kiel-apple requested review from hicklin and plauric April 15, 2025 23:12
@mergify mergify bot added the conflict label Apr 16, 2025
@kiel-apple kiel-apple force-pushed the new-rvc-opstate-errors branch from dd72142 to eb13715 Compare April 18, 2025 21:10
@mergify mergify bot removed the conflict label Apr 18, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 18, 2025 •
edited
Loading

PR #38420: Size comparison from 4a26ee2 to 90a6d4e

Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 4a26ee2 90a6d4e change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1098928 1098928 0 0.0
RAM 94850 94850 0 0.0
bl702 lighting-app bl702+eth FLASH 653844 653844 0 0.0
RAM 33533 33533 0 0.0
bl702+wifi FLASH 831096 831096 0 0.0
RAM 22257 22257 0 0.0
bl706+mfd+rpc+littlefs FLASH 1063620 1063620 0 0.0
RAM 32181 32181 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 894508 894508 0 0.0
RAM 26920 26920 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 977296 977296 0 0.0
RAM 24668 24668 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 818796 818796 0 0.0
RAM 120288 120288 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 827756 827756 0 0.0
RAM 125384 125384 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 774800 774800 0 0.0
RAM 113756 113756 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 759100 759100 0 0.0
RAM 113972 113972 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 542474 542474 0 0.0
RAM 205144 205144 0 0.0
lock CC3235SF_LAUNCHXL FLASH 576438 576438 0 0.0
RAM 205392 205392 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 660813 660813 0 0.0
RAM 77260 77260 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 680673 680673 0 0.0
RAM 79900 79900 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 680673 680673 0 0.0
RAM 79900 79900 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 637597 637597 0 0.0
RAM 72328 72328 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 620893 620893 0 0.0
RAM 73508 73508 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 640529 640529 0 0.0
RAM 76052 76052 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 640529 640529 0 0.0
RAM 76052 76052 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 640341 640341 0 0.0
RAM 76508 76508 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 660057 660057 0 0.0
RAM 79052 79052 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 660057 660057 0 0.0
RAM 79052 79052 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 616737 616737 0 0.0
RAM 70596 70596 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 636597 636597 0 0.0
RAM 73236 73236 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 636597 636597 0 0.0
RAM 73236 73236 0 0.0
efr32 lock-app BRD4187C FLASH 942008 942008 0 0.0
RAM 132008 132008 0 0.0
BRD4338a FLASH 735864 735864 0 0.0
RAM 206916 206916 0 0.0
window-app BRD4187C FLASH 1033632 1033632 0 0.0
RAM 128048 128048 0 0.0
esp32 all-clusters-app c3devkit DRAM 103408 103408 0 0.0
FLASH 1800048 1800048 0 0.0
IRAM 83846 83846 0 0.0
m5stack DRAM 121980 121980 0 0.0
FLASH 1765606 1765606 0 0.0
IRAM 117043 117043 0 0.0
linux air-purifier-app debug unknown 4848 4848 0 0.0
FLASH 2749687 2749687 0 0.0
RAM 114264 114264 0 0.0
all-clusters-app debug unknown 5656 5656 0 0.0
FLASH 6295040 6295232 192 0.0
RAM 532432 532784 352 0.1
all-clusters-minimal-app debug unknown 5528 5528 0 0.0
FLASH 5419840 5419840 0 0.0
RAM 224528 224528 0 0.0
bridge-app debug unknown 5544 5544 0 0.0
FLASH 4719680 4719680 0 0.0
RAM 202880 202880 0 0.0
camera-app debug unknown 8832 8832 0 0.0
FLASH 6793019 6793019 0 0.0
RAM 225264 225264 0 0.0
camera-controller debug unknown 9120 9120 0 0.0
FLASH 13890123 13890315 192 0.0
RAM 646352 646704 352 0.1
chip-tool debug unknown 6256 6256 0 0.0
FLASH 14316015 14316207 192 0.0
RAM 636544 636896 352 0.1
chip-tool-ipv6only arm64 unknown 39696 39696 0 0.0
FLASH 12349184 12349376 192 0.0
RAM 682720 683072 352 0.1
fabric-admin debug unknown 5936 5936 0 0.0
FLASH 12415827 12416019 192 0.0
RAM 635904 636256 352 0.1
fabric-bridge-app debug unknown 4800 4800 0 0.0
FLASH 4550444 4550444 0 0.0
RAM 190160 190160 0 0.0
fabric-sync debug unknown 5056 5056 0 0.0
FLASH 5690069 5690261 192 0.0
RAM 486664 487016 352 0.1
lighting-app debug+rpc+ui unknown 6264 6264 0 0.0
FLASH 5620433 5620433 0 0.0
RAM 207144 207144 0 0.0
lock-app debug unknown 5496 5496 0 0.0
FLASH 4788208 4788208 0 0.0
RAM 194272 194272 0 0.0
ota-provider-app debug unknown 4840 4840 0 0.0
FLASH 4407894 4407894 0 0.0
RAM 182992 182992 0 0.0
ota-requestor-app debug unknown 4792 4792 0 0.0
FLASH 4540234 4540234 0 0.0
RAM 187464 187464 0 0.0
shell debug unknown 4272 4272 0 0.0
FLASH 3055676 3055676 0 0.0
RAM 147824 147824 0 0.0
thermostat-no-ble arm64 unknown 9560 9560 0 0.0
FLASH 4206536 4206536 0 0.0
RAM 230856 230856 0 0.0
tv-app debug unknown 5832 5832 0 0.0
FLASH 6037173 6037365 192 0.0
RAM 610080 610432 352 0.1
tv-casting-app debug unknown 5416 5416 0 0.0
FLASH 12481789 12481981 192 0.0
RAM 754464 754816 352 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 917312 917312 0 0.0
RAM 167469 167469 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 909780 909780 0 0.0
RAM 145713 145713 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 853840 853840 0 0.0
RAM 141223 141223 0 0.0
nxp contact k32w0+release FLASH 589256 589256 0 0.0
RAM 72836 72836 0 0.0
mcxw71+release FLASH 621208 621208 0 0.0
RAM 63172 63172 0 0.0
light k32w0+release FLASH 615028 615028 0 0.0
RAM 72132 72132 0 0.0
k32w1+release FLASH 705304 705304 0 0.0
RAM 72020 72020 0 0.0
lock mcxw71+release FLASH 770320 770320 0 0.0
RAM 67588 67588 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1662140 1662140 0 0.0
RAM 212352 212352 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1566396 1566396 0 0.0
RAM 208544 208544 0 0.0
light cy8ckit_062s2_43012 FLASH 1442692 1442692 0 0.0
RAM 197312 197312 0 0.0
lock cy8ckit_062s2_43012 FLASH 1471468 1471468 0 0.0
RAM 224976 224976 0 0.0
qpg lighting-app qpg6105+debug FLASH 665820 665820 0 0.0
RAM 105188 105188 0 0.0
lock-app qpg6105+debug FLASH 624104 624104 0 0.0
RAM 99816 99816 0 0.0
stm32 light STM32WB5MM-DK FLASH 463016 463016 0 0.0
RAM 141488 141488 0 0.0
telink bridge-app tl7218x FLASH 673028 673028 0 0.0
696146 696146 0 0.0
RAM 90712 90712 0 0.0
101860 101860 0 0.0
light-app-ota-compress-lzma-factory-data tl3218x FLASH 777962 777962 0 0.0
RAM 50120 50120 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 768224 768224 0 0.0
RAM 40420 40420 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 756684 756684 0 0.0
784598 784598 0 0.0
RAM 97540 97540 0 0.0
109308 109308 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 683714 683714 0 0.0
705824 705824 0 0.0
RAM 51588 51588 0 0.0
62620 62620 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 712164 712164 0 0.0
742006 742006 0 0.0
RAM 73408 73408 0 0.0
85808 85808 0 0.0
light-switch-app-ota-shell-factory-data tl3218x_retention FLASH 709710 709710 0 0.0
RAM 37044 37044 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 604188 604188 0 0.0
603726 603726 0 0.0
RAM 138640 138640 0 0.0
148704 148704 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 791682 791686 4 0.0
819212 819216 4 0.0
RAM 96396 96396 0 0.0
107568 107568 0 0.0
tizen all-clusters-app arm unknown 5164 5164 0 0.0
FLASH 1801660 1801660 0 0.0
RAM 94528 94528 0 0.0
chip-tool-ubsan arm unknown 20272 20272 0 0.0
FLASH 20379990 20380206 216 0.0
RAM 8882592 8882856 264 0.0

@kiel-apple kiel-apple added the 1.5-te2-fc-review Review priority for TE2 FC deadline (Apr 25) label Apr 24, 2025
@mergify mergify bot merged commit bc7f2a4 into project-chip:master Apr 24, 2025
73 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in [Platform] Darwin Apr 24, 2025
dsavitsky-dsr pushed a commit to popovdg/connectedhomeip that referenced this pull request Apr 29, 2025
@kiel-apple @restyled-commits @dsavitsky-dsr
Additional RVC Operational States and Errors (project-chip#38420)
6475e43 
* additional operational states from 1.5 spec

* additional operational error states from 1.5 spec

* codegen: python

* codegen: darwin

* codegen: .matter files

* codegen:  zzz

* add timing note for provisional items

* Restyled by prettier-yaml

---------

Co-authored-by: Restyled.io <[email protected]>
@kiel-apple kiel-apple mentioned this pull request May 30, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bzbarsky-apple bzbarsky-apple bzbarsky-apple approved these changes

@andy31415 andy31415 andy31415 approved these changes

@hicklin hicklin Awaiting requested review from hicklin

@plauric plauric Awaiting requested review from plauric

Assignees

@kiel-apple kiel-apple

Labels

1.5-te2-fc-review Review priority for TE2 FC deadline (Apr 25) app controller darwin enhancement New feature or request examples review - approved robot vacuums spec Mismatch between spec and implementation v1.5

Projects

[Device Type] Robot Vacuums
Status: Done
[Platform] Darwin
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kiel-apple @andy31415 @bzbarsky-apple @restyled-commits