Skip to content

Add LargePayload flags to session establishment for WebRTC commands #38370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 17, 2025
Merged

Add LargePayload flags to session establishment for WebRTC commands #38370

merged 2 commits into from
Apr 17, 2025

Conversation

pidarped
Copy link
Contributor

All webrtc commands require a LargePayload session, so it is mandatory for all commands.
Ensure WebRTC Session establishment sets up a LargePayload secure session in camera-controller and chip-camera-app.

Testing

Local testing between chip-camera-app and camera-controller:

  • Pair chip-camera-app
  • Send WebRTC ProvideOffer command from controller over TCP based session.

@pidarped pidarped force-pushed the WebRTCCommandsLargePayload branch from a430823 to cce88c9 Compare April 11, 2025 19:41
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 11, 2025 •
edited
Loading

PR #38370: Size comparison from 659df72 to cce88c9

Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 659df72 cce88c9 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1098536 1098536 0 0.0
RAM 94850 94850 0 0.0
bl702 lighting-app bl702+eth FLASH 653450 653450 0 0.0
RAM 33533 33533 0 0.0
bl702+wifi FLASH 830706 830706 0 0.0
RAM 22257 22257 0 0.0
bl706+mfd+rpc+littlefs FLASH 1063488 1063488 0 0.0
RAM 32181 32181 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 894286 894286 0 0.0
RAM 26920 26920 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 976906 976906 0 0.0
RAM 24668 24668 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 818692 818692 0 0.0
RAM 120288 120288 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 827564 827564 0 0.0
RAM 125384 125384 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 774504 774504 0 0.0
RAM 113756 113756 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 758788 758788 0 0.0
RAM 113972 113972 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 542142 542142 0 0.0
RAM 205144 205144 0 0.0
lock CC3235SF_LAUNCHXL FLASH 576170 576170 0 0.0
RAM 205392 205392 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 660245 660245 0 0.0
RAM 75428 75428 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 680105 680105 0 0.0
RAM 78068 78068 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 680105 680105 0 0.0
RAM 78068 78068 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 637029 637029 0 0.0
RAM 70496 70496 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 620493 620493 0 0.0
RAM 71676 71676 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 640129 640129 0 0.0
RAM 74220 74220 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 640129 640129 0 0.0
RAM 74220 74220 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 639965 639965 0 0.0
RAM 74676 74676 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 659689 659689 0 0.0
RAM 77220 77220 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 659689 659689 0 0.0
RAM 77220 77220 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 616337 616337 0 0.0
RAM 68764 68764 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 636189 636189 0 0.0
RAM 71404 71404 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 636189 636189 0 0.0
RAM 71404 71404 0 0.0
efr32 lock-app BRD4187C FLASH 941160 941160 0 0.0
RAM 159944 159944 0 0.0
BRD4338a FLASH 735176 735176 0 0.0
RAM 234852 234852 0 0.0
window-app BRD4187C FLASH 1033648 1033640 -8 -0.0
RAM 128048 128048 0 0.0
esp32 all-clusters-app c3devkit DRAM 103408 103408 0 0.0
FLASH 1797962 1797962 0 0.0
IRAM 83846 83846 0 0.0
m5stack DRAM 121980 121980 0 0.0
FLASH 1763670 1763670 0 0.0
IRAM 117043 117043 0 0.0
linux air-purifier-app debug unknown 4848 4848 0 0.0
FLASH 2722093 2722093 0 0.0
RAM 114184 114184 0 0.0
all-clusters-app debug unknown 5656 5656 0 0.0
FLASH 6238652 6238652 0 0.0
RAM 531048 531048 0 0.0
all-clusters-minimal-app debug unknown 5528 5528 0 0.0
FLASH 5378120 5378120 0 0.0
RAM 224432 224432 0 0.0
bridge-app debug unknown 5544 5544 0 0.0
FLASH 4690872 4690872 0 0.0
RAM 202816 202816 0 0.0
camera-app debug unknown 8832 8832 0 0.0
FLASH 6705099 6705099 0 0.0
RAM 224336 224336 0 0.0
camera-controller debug unknown 9120 9120 0 0.0
FLASH 13689211 13689211 0 0.0
RAM 644272 644272 0 0.0
chip-tool debug unknown 6256 6256 0 0.0
FLASH 14070753 14070753 0 0.0
RAM 634448 634448 0 0.0
chip-tool-ipv6only arm64 unknown 22816 22816 0 0.0
FLASH 12158040 12158040 0 0.0
RAM 687080 687080 0 0.0
fabric-admin debug unknown 5936 5936 0 0.0
FLASH 12215543 12215543 0 0.0
RAM 633808 633808 0 0.0
fabric-bridge-app debug unknown 4800 4800 0 0.0
FLASH 4522796 4522796 0 0.0
RAM 190112 190112 0 0.0
fabric-sync debug unknown 5056 5056 0 0.0
FLASH 5661189 5661189 0 0.0
RAM 485416 485416 0 0.0
lighting-app debug+rpc+ui unknown 6264 6264 0 0.0
FLASH 5585921 5585921 0 0.0
RAM 207064 207064 0 0.0
lock-app debug unknown 5496 5496 0 0.0
FLASH 4758620 4758620 0 0.0
RAM 194208 194208 0 0.0
ota-provider-app debug unknown 4840 4840 0 0.0
FLASH 4380494 4380494 0 0.0
RAM 182928 182928 0 0.0
ota-requestor-app debug unknown 4792 4792 0 0.0
FLASH 4511062 4511062 0 0.0
RAM 187400 187400 0 0.0
shell debug unknown 4272 4272 0 0.0
FLASH 3013660 3013660 0 0.0
RAM 147712 147712 0 0.0
thermostat-no-ble arm64 unknown 9552 9552 0 0.0
FLASH 4200192 4200192 0 0.0
RAM 231912 231912 0 0.0
tv-app debug unknown 5832 5832 0 0.0
FLASH 5998021 5998021 0 0.0
RAM 608832 608832 0 0.0
tv-casting-app debug unknown 5416 5416 0 0.0
FLASH 12229933 12229933 0 0.0
RAM 752144 752144 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 916584 916584 0 0.0
RAM 167469 167469 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 909488 909488 0 0.0
RAM 145713 145713 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 852928 852928 0 0.0
RAM 141223 141223 0 0.0
nxp contact k32w0+release FLASH 588800 588800 0 0.0
RAM 70996 70996 0 0.0
mcxw71+release FLASH 607264 607264 0 0.0
RAM 63152 63152 0 0.0
light k32w0+release FLASH 614620 614620 0 0.0
RAM 70292 70292 0 0.0
k32w1+release FLASH 691432 691432 0 0.0
RAM 72000 72000 0 0.0
lock mcxw71+release FLASH 756480 756480 0 0.0
RAM 67564 67564 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1661788 1661788 0 0.0
RAM 212352 212352 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1565748 1565748 0 0.0
RAM 208544 208544 0 0.0
light cy8ckit_062s2_43012 FLASH 1442668 1442668 0 0.0
RAM 197312 197312 0 0.0
lock cy8ckit_062s2_43012 FLASH 1471516 1471516 0 0.0
RAM 224976 224976 0 0.0
qpg lighting-app qpg6105+debug FLASH 665316 665316 0 0.0
RAM 105172 105172 0 0.0
lock-app qpg6105+debug FLASH 623720 623720 0 0.0
RAM 99792 99792 0 0.0
stm32 light STM32WB5MM-DK FLASH 461384 461384 0 0.0
RAM 141488 141488 0 0.0
telink bridge-app tl7218x FLASH 672404 672404 0 0.0
695522 695522 0 0.0
RAM 90712 90712 0 0.0
101860 101860 0 0.0
light-app-ota-compress-lzma-factory-data tl3218x FLASH 777394 777394 0 0.0
RAM 50120 50120 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 767656 767656 0 0.0
RAM 40420 40420 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 756116 756116 0 0.0
784030 784030 0 0.0
RAM 97540 97540 0 0.0
109308 109308 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 683134 683134 0 0.0
705244 705244 0 0.0
RAM 51588 51588 0 0.0
62620 62620 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 711584 711584 0 0.0
741426 741426 0 0.0
RAM 73408 73408 0 0.0
85808 85808 0 0.0
light-switch-app-ota-shell-factory-data tl3218x_retention FLASH 709130 709130 0 0.0
RAM 37044 37044 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 603592 603592 0 0.0
603166 603166 0 0.0
RAM 138640 138640 0 0.0
148704 148704 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 791114 791118 4 0.0
818644 818648 4 0.0
RAM 96396 96396 0 0.0
107568 107568 0 0.0
tizen all-clusters-app arm unknown 5152 5152 0 0.0
FLASH 1791040 1791040 0 0.0
RAM 94472 94472 0 0.0
chip-tool-ubsan arm unknown 11836 11836 0 0.0
FLASH 20061694 20061694 0 0.0
RAM 8794384 8794384 0 0.0

@yufengwangca yufengwangca enabled auto-merge (squash) April 11, 2025 21:45
@bzbarsky-apple bzbarsky-apple mentioned this pull request Apr 14, 2025
Merged
@pidarped pidarped force-pushed the WebRTCCommandsLargePayload branch from cce88c9 to 42aa3e4 Compare April 15, 2025 03:14
@github-actions github-actions bot added the app label Apr 15, 2025
@pidarped pidarped requested a review from bzbarsky-apple April 15, 2025 03:16
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 15, 2025 •
edited
Loading

PR #38370: Size comparison from 4739fc1 to 42aa3e4

Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 4739fc1 42aa3e4 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1098550 1098550 0 0.0
RAM 94850 94850 0 0.0
bl702 lighting-app bl702+eth FLASH 653466 653466 0 0.0
RAM 33533 33533 0 0.0
bl702+wifi FLASH 830722 830722 0 0.0
RAM 22257 22257 0 0.0
bl706+mfd+rpc+littlefs FLASH 1063502 1063502 0 0.0
RAM 32181 32181 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 894304 894304 0 0.0
RAM 26920 26920 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 976922 976922 0 0.0
RAM 24668 24668 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 818692 818692 0 0.0
RAM 120288 120288 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 827564 827564 0 0.0
RAM 125384 125384 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 774504 774504 0 0.0
RAM 113756 113756 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 758788 758788 0 0.0
RAM 113972 113972 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 542142 542142 0 0.0
RAM 205144 205144 0 0.0
lock CC3235SF_LAUNCHXL FLASH 576170 576170 0 0.0
RAM 205392 205392 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 660645 660645 0 0.0
RAM 77260 77260 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 680505 680505 0 0.0
RAM 79900 79900 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 680505 680505 0 0.0
RAM 79900 79900 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 637429 637429 0 0.0
RAM 72328 72328 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 620613 620613 0 0.0
RAM 73508 73508 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 640249 640249 0 0.0
RAM 76052 76052 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 640249 640249 0 0.0
RAM 76052 76052 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 640085 640085 0 0.0
RAM 76508 76508 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 659801 659801 0 0.0
RAM 79052 79052 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 659801 659801 0 0.0
RAM 79052 79052 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 616441 616441 0 0.0
RAM 70596 70596 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 636301 636301 0 0.0
RAM 73236 73236 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 636301 636301 0 0.0
RAM 73236 73236 0 0.0
efr32 lock-app BRD4187C FLASH 941160 941160 0 0.0
RAM 159944 159944 0 0.0
BRD4338a FLASH 735328 735328 0 0.0
RAM 234852 234852 0 0.0
window-app BRD4187C FLASH 1033696 1033688 -8 -0.0
RAM 128048 128048 0 0.0
esp32 all-clusters-app c3devkit DRAM 103408 103408 0 0.0
FLASH 1797980 1797980 0 0.0
IRAM 83846 83846 0 0.0
m5stack DRAM 121980 121980 0 0.0
FLASH 1763658 1763658 0 0.0
IRAM 117043 117043 0 0.0
linux air-purifier-app debug unknown 4848 4848 0 0.0
FLASH 2722097 2722097 0 0.0
RAM 114184 114184 0 0.0
all-clusters-app debug unknown 5656 5656 0 0.0
FLASH 6238592 6238592 0 0.0
RAM 531112 531112 0 0.0
all-clusters-minimal-app debug unknown 5528 5528 0 0.0
FLASH 5378060 5378060 0 0.0
RAM 224432 224432 0 0.0
bridge-app debug unknown 5544 5544 0 0.0
FLASH 4690844 4690844 0 0.0
RAM 202816 202816 0 0.0
camera-app debug unknown 8832 8832 0 0.0
FLASH 6705035 6705099 64 0.0
RAM 224336 224336 0 0.0
camera-controller debug unknown 9120 9120 0 0.0
FLASH 13694411 13694459 48 0.0
RAM 644336 644336 0 0.0
chip-tool debug unknown 6256 6256 0 0.0
FLASH 14078551 14078551 0 0.0
RAM 634512 634512 0 0.0
chip-tool-ipv6only arm64 unknown 39504 39504 0 0.0
FLASH 12161696 12161696 0 0.0
RAM 687144 687144 0 0.0
fabric-admin debug unknown 5936 5936 0 0.0
FLASH 12220805 12220805 0 0.0
RAM 633872 633872 0 0.0
fabric-bridge-app debug unknown 4800 4800 0 0.0
FLASH 4522736 4522736 0 0.0
RAM 190112 190112 0 0.0
fabric-sync debug unknown 5056 5056 0 0.0
FLASH 5661157 5661157 0 0.0
RAM 485480 485480 0 0.0
lighting-app debug+rpc+ui unknown 6264 6264 0 0.0
FLASH 5585857 5585857 0 0.0
RAM 207064 207064 0 0.0
lock-app debug unknown 5496 5496 0 0.0
FLASH 4758560 4758560 0 0.0
RAM 194208 194208 0 0.0
ota-provider-app debug unknown 4840 4840 0 0.0
FLASH 4380464 4380464 0 0.0
RAM 182928 182928 0 0.0
ota-requestor-app debug unknown 4792 4792 0 0.0
FLASH 4511000 4511000 0 0.0
RAM 187400 187400 0 0.0
shell debug unknown 4272 4272 0 0.0
FLASH 3013644 3013644 0 0.0
RAM 147712 147712 0 0.0
thermostat-no-ble arm64 unknown 9552 9552 0 0.0
FLASH 4200160 4200160 0 0.0
RAM 231912 231912 0 0.0
tv-app debug unknown 5832 5832 0 0.0
FLASH 5997989 5997989 0 0.0
RAM 608896 608896 0 0.0
tv-casting-app debug unknown 5416 5416 0 0.0
FLASH 12237725 12237725 0 0.0
RAM 752208 752208 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 916584 916584 0 0.0
RAM 167469 167469 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 909492 909492 0 0.0
RAM 145713 145713 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 852924 852924 0 0.0
RAM 141223 141223 0 0.0
nxp contact k32w0+release FLASH 588960 588960 0 0.0
RAM 72836 72836 0 0.0
mcxw71+release FLASH 607256 607256 0 0.0
RAM 63152 63152 0 0.0
light k32w0+release FLASH 614780 614780 0 0.0
RAM 72132 72132 0 0.0
k32w1+release FLASH 691432 691432 0 0.0
RAM 72000 72000 0 0.0
lock mcxw71+release FLASH 756472 756472 0 0.0
RAM 67564 67564 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1661804 1661804 0 0.0
RAM 212352 212352 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1565748 1565748 0 0.0
RAM 208544 208544 0 0.0
light cy8ckit_062s2_43012 FLASH 1442668 1442668 0 0.0
RAM 197312 197312 0 0.0
lock cy8ckit_062s2_43012 FLASH 1471532 1471532 0 0.0
RAM 224976 224976 0 0.0
qpg lighting-app qpg6105+debug FLASH 665724 665724 0 0.0
RAM 105188 105188 0 0.0
lock-app qpg6105+debug FLASH 623856 623856 0 0.0
RAM 99816 99816 0 0.0
stm32 light STM32WB5MM-DK FLASH 461384 461384 0 0.0
RAM 141488 141488 0 0.0
telink bridge-app tl7218x FLASH 695540 672422 -23118 -3.3
695540 695540 0 0.0
RAM 101860 90712 -11148 -10.9
101860 101860 0 0.0
light-app-ota-compress-lzma-factory-data tl3218x FLASH 777412 777412 0 0.0
RAM 50120 50120 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 767674 767674 0 0.0
RAM 40420 40420 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 784048 756134 -27914 -3.6
784048 784048 0 0.0
RAM 109308 97540 -11768 -10.8
109308 109308 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 705262 683152 -22110 -3.1
705262 705262 0 0.0
RAM 62620 51588 -11032 -17.6
62620 62620 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 741444 711602 -29842 -4.0
741444 741444 0 0.0
RAM 85808 73408 -12400 -14.5
85808 85808 0 0.0
light-switch-app-ota-shell-factory-data tl3218x_retention FLASH 709148 709148 0 0.0
RAM 37044 37044 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 603184 603610 426 0.1
603184 603184 0 0.0
RAM 148704 138640 -10064 -6.8
148704 148704 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 818662 791136 -27526 -3.4
818662 818666 4 0.0
RAM 107568 96396 -11172 -10.4
107568 107568 0 0.0
tizen all-clusters-app arm unknown 5160 5160 0 0.0
FLASH 1791048 1791048 0 0.0
RAM 94472 94472 0 0.0
chip-tool-ubsan arm unknown 20180 20180 0 0.0
FLASH 20072182 20072182 0 0.0
RAM 8799832 8799832 0 0.0

bzbarsky-apple
bzbarsky-apple previously requested changes Apr 15, 2025
View reviewed changes
@pidarped pidarped requested a review from bzbarsky-apple April 16, 2025 19:19
pidarped added 2 commits April 16, 2025 20:30
@pidarped
Add LargePayload flags to session establishment for WebRTC commands.
1c629c4 
All webrtc commands require a LargePayload session, so it is mandatory
for all commands.
@pidarped
Update FindOrEstablishSession() API to the new one without the CASE r…
1211a54 
…etries.
@pidarped pidarped force-pushed the WebRTCCommandsLargePayload branch from 42aa3e4 to 1211a54 Compare April 17, 2025 03:41
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 17, 2025 •
edited
Loading

PR #38370: Size comparison from 6367083 to 1211a54

Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 6367083 1211a54 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1098928 1098928 0 0.0
RAM 94850 94850 0 0.0
bl702 lighting-app bl702+eth FLASH 653588 653588 0 0.0
RAM 33533 33533 0 0.0
bl702+wifi FLASH 830840 830840 0 0.0
RAM 22257 22257 0 0.0
bl706+mfd+rpc+littlefs FLASH 1063620 1063620 0 0.0
RAM 32181 32181 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 894508 894508 0 0.0
RAM 26920 26920 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 977040 977040 0 0.0
RAM 24668 24668 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 818708 818708 0 0.0
RAM 120288 120288 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 827668 827668 0 0.0
RAM 125384 125384 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 774728 774728 0 0.0
RAM 113756 113756 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 759028 759028 0 0.0
RAM 113972 113972 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 542386 542386 0 0.0
RAM 205144 205144 0 0.0
lock CC3235SF_LAUNCHXL FLASH 576366 576366 0 0.0
RAM 205392 205392 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 660693 660693 0 0.0
RAM 77260 77260 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 680545 680545 0 0.0
RAM 79900 79900 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 680545 680545 0 0.0
RAM 79900 79900 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 637477 637477 0 0.0
RAM 72328 72328 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 620773 620773 0 0.0
RAM 73508 73508 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 640409 640409 0 0.0
RAM 76052 76052 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 640409 640409 0 0.0
RAM 76052 76052 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 640213 640213 0 0.0
RAM 76508 76508 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 659937 659937 0 0.0
RAM 79052 79052 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 659937 659937 0 0.0
RAM 79052 79052 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 616617 616617 0 0.0
RAM 70596 70596 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 636469 636469 0 0.0
RAM 73236 73236 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 636469 636469 0 0.0
RAM 73236 73236 0 0.0
efr32 lock-app BRD4187C FLASH 941280 941280 0 0.0
RAM 159944 159944 0 0.0
BRD4338a FLASH 735128 735120 -8 -0.0
RAM 234852 234852 0 0.0
window-app BRD4187C FLASH 1033568 1033568 0 0.0
RAM 128048 128048 0 0.0
esp32 all-clusters-app c3devkit DRAM 103408 103408 0 0.0
FLASH 1799328 1799328 0 0.0
IRAM 83846 83846 0 0.0
m5stack DRAM 121980 121980 0 0.0
FLASH 1764974 1764974 0 0.0
IRAM 117043 117043 0 0.0
linux air-purifier-app debug unknown 4848 4848 0 0.0
FLASH 2749157 2749157 0 0.0
RAM 114264 114264 0 0.0
all-clusters-app debug unknown 5656 5656 0 0.0
FLASH 6290122 6290122 0 0.0
RAM 532400 532400 0 0.0
all-clusters-minimal-app debug unknown 5528 5528 0 0.0
FLASH 5419310 5419310 0 0.0
RAM 224528 224528 0 0.0
bridge-app debug unknown 5544 5544 0 0.0
FLASH 4719150 4719150 0 0.0
RAM 202880 202880 0 0.0
camera-app debug unknown 8832 8832 0 0.0
FLASH 6787147 6787211 64 0.0
RAM 225200 225200 0 0.0
camera-controller debug unknown 9120 9120 0 0.0
FLASH 13751131 13751179 48 0.0
RAM 646352 646352 0 0.0
chip-tool debug unknown 6256 6256 0 0.0
FLASH 14178353 14178353 0 0.0
RAM 636544 636544 0 0.0
chip-tool-ipv6only arm64 unknown 39696 39696 0 0.0
FLASH 12240128 12240128 0 0.0
RAM 680368 680368 0 0.0
fabric-admin debug unknown 5936 5936 0 0.0
FLASH 12277135 12277135 0 0.0
RAM 635904 635904 0 0.0
fabric-bridge-app debug unknown 4800 4800 0 0.0
FLASH 4549914 4549914 0 0.0
RAM 190160 190160 0 0.0
fabric-sync debug unknown 5056 5056 0 0.0
FLASH 5689541 5689541 0 0.0
RAM 486664 486664 0 0.0
lighting-app debug+rpc+ui unknown 6264 6264 0 0.0
FLASH 5616465 5616465 0 0.0
RAM 207144 207144 0 0.0
lock-app debug unknown 5496 5496 0 0.0
FLASH 4787710 4787710 0 0.0
RAM 194272 194272 0 0.0
ota-provider-app debug unknown 4840 4840 0 0.0
FLASH 4407364 4407364 0 0.0
RAM 182992 182992 0 0.0
ota-requestor-app debug unknown 4792 4792 0 0.0
FLASH 4539704 4539704 0 0.0
RAM 187464 187464 0 0.0
shell debug unknown 4272 4272 0 0.0
FLASH 3054796 3054796 0 0.0
RAM 147824 147824 0 0.0
thermostat-no-ble arm64 unknown 9560 9560 0 0.0
FLASH 4206168 4206168 0 0.0
RAM 230856 230856 0 0.0
tv-app debug unknown 5832 5832 0 0.0
FLASH 6033749 6033749 0 0.0
RAM 610080 610080 0 0.0
tv-casting-app debug unknown 5416 5416 0 0.0
FLASH 12343709 12343709 0 0.0
RAM 754464 754464 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 917244 917244 0 0.0
RAM 167469 167469 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 909720 909720 0 0.0
RAM 145713 145713 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 853768 853768 0 0.0
RAM 141223 141223 0 0.0
nxp contact k32w0+release FLASH 589176 589176 0 0.0
RAM 72836 72836 0 0.0
mcxw71+release FLASH 607488 607488 0 0.0
RAM 63152 63152 0 0.0
light k32w0+release FLASH 614948 614948 0 0.0
RAM 72132 72132 0 0.0
k32w1+release FLASH 691592 691592 0 0.0
RAM 72000 72000 0 0.0
lock mcxw71+release FLASH 756600 756600 0 0.0
RAM 67564 67564 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1662044 1662044 0 0.0
RAM 212352 212352 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1566300 1566300 0 0.0
RAM 208544 208544 0 0.0
light cy8ckit_062s2_43012 FLASH 1442596 1442596 0 0.0
RAM 197312 197312 0 0.0
lock cy8ckit_062s2_43012 FLASH 1471372 1471372 0 0.0
RAM 224976 224976 0 0.0
qpg lighting-app qpg6105+debug FLASH 665748 665748 0 0.0
RAM 105188 105188 0 0.0
lock-app qpg6105+debug FLASH 624024 624024 0 0.0
RAM 99816 99816 0 0.0
stm32 light STM32WB5MM-DK FLASH 461432 461432 0 0.0
RAM 141488 141488 0 0.0
telink bridge-app tl7218x FLASH 672932 672932 0 0.0
696050 696050 0 0.0
RAM 90712 90712 0 0.0
101860 101860 0 0.0
light-app-ota-compress-lzma-factory-data tl3218x FLASH 777866 777866 0 0.0
RAM 50120 50120 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 768128 768128 0 0.0
RAM 40420 40420 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 756588 756588 0 0.0
784502 784502 0 0.0
RAM 97540 97540 0 0.0
109308 109308 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 683618 683618 0 0.0
705728 705728 0 0.0
RAM 51588 51588 0 0.0
62620 62620 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 712068 712068 0 0.0
741910 741910 0 0.0
RAM 73408 73408 0 0.0
85808 85808 0 0.0
light-switch-app-ota-shell-factory-data tl3218x_retention FLASH 709614 709614 0 0.0
RAM 37044 37044 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 604092 604092 0 0.0
603630 603630 0 0.0
RAM 138640 138640 0 0.0
148704 148704 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 791586 791590 4 0.0
819116 819120 4 0.0
RAM 96396 96396 0 0.0
107568 107568 0 0.0
tizen all-clusters-app arm unknown 5164 5164 0 0.0
FLASH 1801132 1801132 0 0.0
RAM 94528 94528 0 0.0
chip-tool-ubsan arm unknown 20272 20272 0 0.0
FLASH 20198334 20198334 0 0.0
RAM 8809700 8809700 0 0.0

@pidarped pidarped requested a review from aronrosenberg April 17, 2025 04:03
@andy31415 andy31415 dismissed bzbarsky-apple’s stale review April 17, 2025 17:49

Dismissing review: requested changes made and PR is blocked while people OOO. We can do followups if needed on this side.

@yufengwangca yufengwangca merged commit ce89076 into project-chip:master Apr 17, 2025
72 checks passed
dsavitsky-dsr pushed a commit to popovdg/connectedhomeip that referenced this pull request Apr 22, 2025
@pidarped @dsavitsky-dsr
Add LargePayload flags to session establishment for WebRTC commands. (p…
84cb6b9 
…roject-chip#38370)

All webrtc commands require a LargePayload session, so it is mandatory
for all commands.
@pidarped pidarped deleted the WebRTCCommandsLargePayload branch May 22, 2025 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aronrosenberg aronrosenberg aronrosenberg approved these changes

@chulspro chulspro chulspro approved these changes

@yufengwangca yufengwangca yufengwangca approved these changes

@bzbarsky-apple bzbarsky-apple Awaiting requested review from bzbarsky-apple

+1 more reviewer

@raveendra-karu raveendra-karu raveendra-karu approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

app examples review - approved

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@pidarped @aronrosenberg @chulspro @yufengwangca @bzbarsky-apple @raveendra-karu