-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Generate AccessControl cluster with Alchemy #38249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mergify
merged 5 commits into
project-chip:master
from
tersal:generate-AccessControl-cluster-with-Alchemy
Apr 22, 2025
Merged
Generate AccessControl cluster with Alchemy #38249
mergify
merged 5 commits into
project-chip:master
from
tersal:generate-AccessControl-cluster-with-Alchemy
Apr 22, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #38249: Size comparison from b6ade9c to bccfb2e Full report (3 builds for cc32xx, stm32)
|
PR #38249: Size comparison from 75a426f to 29df324 Full report (3 builds for cc32xx, stm32)
|
PR #38249: Size comparison from 75a426f to c5ebe5e Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
andy31415
approved these changes
Apr 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks ok. Some notes:
- structs shared with Joint Fabric Datastore Cluster is probably ok
- Array length of 65535 in the XML is awkward but unused. I am unsure why alchemy does that @hasty
bzbarsky-apple
requested changes
Apr 7, 2025
src/app/zap-templates/zcl/data-model/chip/access-control-cluster.xml
Outdated
Show resolved
Hide resolved
PR #38249: Size comparison from dc07b29 to 3f384c8 Full report (3 builds for cc32xx, stm32)
|
PR #38249: Size comparison from dc07b29 to b9bb9f9 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
bzbarsky-apple
approved these changes
Apr 22, 2025
dsavitsky-dsr
pushed a commit
to dsavitsky-dsr/connectedhomeip
that referenced
this pull request
Apr 24, 2025
* Generate AccessControl cluster with Alchemy * Add matter files generated by ZAP * Update generated files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #37391
Generation of Access control cluster (ACL-Cluster) with Alchemy.
Testing
Tested with UnitTest and CI checks.