-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Generate ConcentrationMeasurement cluster with Alchemy #37930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate ConcentrationMeasurement cluster with Alchemy #37930
Conversation
PR #37930: Size comparison from 36a1bbd to 0a28542 Full report (3 builds for cc32xx, stm32)
|
src/app/zap-templates/zcl/data-model/chip/concentration-measurement-cluster.xml
Outdated
Show resolved
Hide resolved
src/app/zap-templates/zcl/data-model/chip/concentration-measurement-cluster.xml
Show resolved
Hide resolved
PR #37930: Size comparison from c0e580c to e971a0d Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not a problem with this actual PR, but I think there might be a spec problem here that this PR is exposing and I want to make sure that's addressed before this goes in.
The conformance for MeasuredValue is MEA.
The MeasurementMedium attribute defines itself as:
This attribute SHALL represent the medium in which MeasuredValue is being measured
So how can that be M if MeasuredValue is not?
Good catch! I believe this is more or less a wording oversight. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will make a spec change to clarify MeasurementMedium
PR #37930: Size comparison from dc07b29 to e7aa632 Full report (75 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
|
…37930) * Generate ConcentrationMeasurement cluster with Alchemy * Regenerate cluster with new alchemy * Add missing ZAP generated files
Part of #37391
Generate ConcentrationMeasurement cluster using Alchemy.
Testing
Ran Unit tests and CI checks with Python and YAML tests