-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[ICD] Remove user active mode trigger attributes from the external list #30980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mkardous-silabs
merged 6 commits into
project-chip:master
from
mkardous-silabs:fix/user_active_mode
Dec 14, 2023
Merged
[ICD] Remove user active mode trigger attributes from the external list #30980
mkardous-silabs
merged 6 commits into
project-chip:master
from
mkardous-silabs:fix/user_active_mode
Dec 14, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmartinez-silabs
approved these changes
Dec 13, 2023
536c23f
to
6bddeb8
Compare
PR #30980: Size comparison from a9ad2c4 to 6bddeb8 Full report (8 builds for cc32xx, mbed, nrfconnect, qpg)
|
andy31415
approved these changes
Dec 13, 2023
andy31415
reviewed
Dec 13, 2023
a213a03
to
197bf68
Compare
PR #30980: Size comparison from a9ad2c4 to 197bf68 Full report (52 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg)
|
bzbarsky-apple
approved these changes
Dec 13, 2023
197bf68
to
4767311
Compare
PR #30980: Size comparison from b6e465a to 4767311 Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
PR #30980: Size comparison from b6e465a to 3216f19 Decreases (1 build for efr32)
Full report (72 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
User active mode trigger attribute where added to the list of attribute that were forced to external when they should not have been.
#30053 was the PR that addeed the attributes.
Issue was not catched because we were not testing the attributes.
Tests
Added Integration tests to validate attributes