Skip to content

find entry first, then createObject to avoid too many unreference entry alloced #29998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

find entry first, then createObject to avoid too many unreference entry alloced #29998

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions src/transport/UnauthenticatedSessionTable.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,16 +213,18 @@ class UnauthenticatedSessionTable
CHIP_ERROR AllocEntry(UnauthenticatedSession::SessionRole sessionRole, NodeId ephemeralInitiatorNodeID,
const ReliableMessageProtocolConfig & config, UnauthenticatedSession *& entry)
{
entry = mEntries.CreateObject(sessionRole, ephemeralInitiatorNodeID, config);
if (entry != nullptr)
return CHIP_NO_ERROR;

entry = FindLeastRecentUsedEntry();
if (entry == nullptr)
{
return CHIP_ERROR_NO_MEMORY;
entry = mEntries.CreateObject(sessionRole, ephemeralInitiatorNodeID, config);
if (entry != nullptr)
return CHIP_NO_ERROR;
else
return CHIP_ERROR_NO_MEMORY;
}

ChipLogProgress(ExchangeManager, "Allocated new session. Current session count: %zu", mEntries.Allocated());
mEntries.ResetObject(entry, sessionRole, ephemeralInitiatorNodeID, config);
return CHIP_NO_ERROR;
}
Expand Down