Skip to content

Conversation

bzbarsky-apple
Copy link
Contributor

If we happened to do a BLE scan after doing a BLE connect, and then during the BLE scan one of two things happens:

  1. Bluetooth is shut down (e.g. by just turning it off via the menubar).
  2. The scan is a delegate-less scan and times out.

then we would try to use the error handler that expects a SetUpCodePairer but without an actual non-null SetUpCodePairer to pass it. And then that would crash.

The fix is to not call an error handler that we're not supposed to be calling; scans do not call the connection error handler.

If we happened to do a BLE scan after doing a BLE connect, and then during the
BLE scan one of two things happens:

1. Bluetooth is shut down (e.g. by just turning it off via the menubar).
2. The scan is a delegate-less scan and times out.

then we would try to use the error handler that expects a SetUpCodePairer but
without an actual non-null SetUpCodePairer to pass it.  And then that would
crash.

The fix is to not call an error handler that we're not supposed to be calling;
scans do not call the _connection_ error handler.
@github-actions
Copy link

github-actions bot commented Aug 3, 2023

PR #28505: Size comparison from f0123d5 to d8869e4

Increases (11 builds for bl602, cc32xx, cyw30739, nrfconnect, psoc6, telink)
platform target config section f0123d5 d8869e4 change % change
bl602 lighting-app bl602 .text 1056868 1056870 2 0.0
bl602+rpc .text 1088802 1088806 4 0.0
cc32xx lock CC3235SF_LAUNCHXL .debug_info 19347127 19347128 1 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 549991 549999 8 0.0
.app_xip_area 441241 441249 8 0.0
nrfconnect all-clusters-minimal-app nrf52840dk_nrf52840 text 809620 809624 4 0.0
psoc6 lock cy8ckit_062s2_43012 .debug_info 22207712 22207713 1 0.0
telink all-clusters-minimal-app tlsr9518adk80d text 669086 669088 2 0.0
contact-sensor-app tlsr9518adk80d text 590052 590054 2 0.0
lighting-app-shell tlsr9518adk80d text 750588 750590 2 0.0
thermostat tlsr9518adk80d text 621226 621228 2 0.0
window-covering tlsr9518adk80d text 616098 616100 2 0.0
Decreases (12 builds for bl702, cyw30739, esp32, psoc6, telink)
platform target config section f0123d5 d8869e4 change % change
bl702 lighting-app bl702+rpc (read/write) 1265603 1265599 -4 -0.0
.debug_info 46329617 46329616 -1 -0.0
.text 1028578 1028576 -2 -0.0
cyw30739 lock cyw930739m2evb_01 (read/write) 536519 536511 -8 -0.0
.app_xip_area 422761 422753 -8 -0.0
esp32 all-clusters-app c3devkit (read only) 1149146 1149144 -2 -0.0
.flash.text 1149146 1149144 -2 -0.0
psoc6 all-clusters cy8ckit_062s2_43012 .debug_info 30050781 30050780 -1 -0.0
light cy8ckit_062s2_43012 .debug_info 22303015 22303013 -2 -0.0
telink lighting-app tlsr9518adk80d text 685552 685550 -2 -0.0
lighting-app-factory-data tlsr9518adk80d text 693068 693066 -2 -0.0
lighting-app-rpc tlsr9518adk80d text 730488 730486 -2 -0.0
ota-requestor-app tlsr9518adk80d text 611938 611936 -2 -0.0
pump-app tlsr9518adk80d (read/write) 881288 881280 -8 -0.0
text 595746 595744 -2 -0.0
shell tlsr9518adk80d (read/write) 744236 744228 -8 -0.0
text 478646 478644 -2 -0.0
temperature-measurement-app tlsr9518adk80d text 581784 581782 -2 -0.0
Full report (60 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
platform target config section f0123d5 d8869e4 change % change
bl602 lighting-app bl602 (read/write) 1363778 1363778 0 0.0
.bss 73670 73670 0 0.0
.data 9552 9552 0 0.0
.text 1056868 1056870 2 0.0
bl602+rpc (read/write) 1411246 1411246 0 0.0
.bss 81710 81710 0 0.0
.data 9952 9952 0 0.0
.text 1088802 1088806 4 0.0
bl702 lighting-app bl702 (read only) 3358 3358 0 0.0
(read/write) 1166699 1166699 0 0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 41285 41285 0 0.0
.bss_psram 43488 43488 0 0.0
.comment 48 48 0 0.0
.data 3544 3544 0 0.0
.debug_abbrev 1566249 1566249 0 0.0
.debug_aranges 140336 140336 0 0.0
.debug_frame 516340 516340 0 0.0
.debug_info 41434671 41434671 0 0.0
.debug_line 5479037 5479037 0 0.0
.debug_loc 3563905 3563905 0 0.0
.debug_ranges 384608 384608 0 0.0
.debug_str 4011881 4011881 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 144 144 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 106812 106812 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 589190 589190 0 0.0
.symtab 175552 175552 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
953894 953894 0 0.0
bl702+rpc (read only) 3358 3358 0 0.0
(read/write) 1265603 1265599 -4 -0.0
.bleromro 6342 6342 0 0.0
.bleromrw 124 124 0 0.0
.boot2 328 328 0 0.0
.bss 49749 49749 0 0.0
.bss_psram 43488 43488 0 0.0
.comment 48 48 0 0.0
.data 4088 4088 0 0.0
.debug_abbrev 1743379 1743379 0 0.0
.debug_aranges 148880 148880 0 0.0
.debug_frame 545244 545244 0 0.0
.debug_info 46329617 46329616 -1 -0.0
.debug_line 5891572 5891572 0 0.0
.debug_loc 3770052 3770052 0 0.0
.debug_ranges 410360 410360 0 0.0
.debug_str 4431746 4431746 0 0.0
.hbn 544 544 0 0.0
.hbn_noinit 260 260 0 0.0
.init 342 342 0 0.0
.init_array 160 160 0 0.0
.psram 0 0 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 121464 121464 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 304 304 0 0.0
.stack 2048 2048 0 0.0
.strtab 652153 652153 0 0.0
.symtab 194480 194480 0 0.0
.tcm_data 28 28 0 0.0
.tcmcode 3358 3358 0 0.0
.text 0 0 0 0.0
1028578 1028576 -2 -0.0
bl702l lighting-app bl702l (read only) 278 278 0 0.0
(read/write) 1152608 1152608 0 0.0
.boot2 292 292 0 0.0
.bss 15988 15988 0 0.0
.bss_psram 77904 77904 0 0.0
.comment 48 48 0 0.0
.data 4512 4512 0 0.0
.debug_abbrev 1568468 1568468 0 0.0
.debug_aranges 134840 134840 0 0.0
.debug_frame 496028 496028 0 0.0
.debug_info 41435780 41435780 0 0.0
.debug_line 5394705 5394705 0 0.0
.debug_loc 3500073 3500073 0 0.0
.debug_ranges 389816 389816 0 0.0
.debug_str 4024350 4024350 0 0.0
.hbn 3244 3244 0 0.0
.hbn_noinit 308 308 0 0.0
.init 408 408 0 0.0
.init_array 144 144 0 0.0
.riscv.attributes 47 47 0 0.0
.rodata 100696 100696 0 0.0
.romdata 3224 3224 0 0.0
.rsvd 4 4 0 0.0
.sha_ocram 72 72 0 0.0
.shstrtab 286 286 0 0.0
.stack 2048 2048 0 0.0
.strtab 589415 589415 0 0.0
.symtab 175120 175120 0 0.0
.tcm_data 692 692 0 0.0
.tcmcode 278 278 0 0.0
.text 0 0 0 0.0
942964 942964 0 0.0
cc32xx lock CC3235SF_LAUNCHXL (blank) 0 0 0 0.0
(read only) 615170 615170 0 0.0
(read/write) 207832 207832 0 0.0
.ARM.attributes 44 44 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 201280 201280 0 0.0
.comment 206 206 0 0.0
.data 1432 1432 0 0.0
.debug_abbrev 959363 959363 0 0.0
.debug_aranges 108896 108896 0 0.0
.debug_frame 369428 369428 0 0.0
.debug_info 19347127 19347128 1 0.0
.debug_line 2809586 2809586 0 0.0
.debug_line_str 513 513 0 0.0
.debug_loc 33340 33340 0 0.0
.debug_loclists 1594328 1594328 0 0.0
.debug_ranges 4984 4984 0 0.0
.debug_rnglists 100559 100559 0 0.0
.debug_str 3423483 3423483 0 0.0
.ramVecs 780 780 0 0.0
.resetVecs 64 64 0 0.0
.rodata 106242 106242 0 0.0
.shstrtab 265 265 0 0.0
.stack 2048 2048 0 0.0
.strtab 495568 495568 0 0.0
.symtab 292960 292960 0 0.0
.text 506808 506808 0 0.0
cyw30739 light cyw930739m2evb_01 (read/write) 549991 549999 8 0.0
.app_xip_area 441241 441249 8 0.0
.bss 63776 63776 0 0.0
.data 656 656 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
lock cyw930739m2evb_01 (read/write) 536519 536511 -8 -0.0
.app_xip_area 422761 422753 -8 -0.0
.bss 68760 68760 0 0.0
.data 684 684 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
ota-requestor cyw930739m2evb_01 (read/write) 573703 573703 0 0.0
.app_xip_area 466033 466033 0 0.0
.bss 62768 62768 0 0.0
.data 584 584 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
switch cyw930739m2evb_01 (read/write) 546375 546375 0 0.0
.app_xip_area 435753 435753 0 0.0
.bss 65648 65648 0 0.0
.data 660 660 0 0.0
.rodata 0 0 0 0.0
.text 112 112 0 0.0
efr32 lighting-app BRD4161A+rs9116 (read/write) 1010504 1010504 0 0.0
.bss 183532 183532 0 0.0
.data 2640 2640 0 0.0
.text 824312 824312 0 0.0
BRD4187C (read/write) 1035200 1035200 0 0.0
.bss 163148 163148 0 0.0
.data 3236 3236 0 0.0
.text 868796 868796 0 0.0
lock-app BRD4161A+wf200 (read/write) 1086892 1086892 0 0.0
.bss 177580 177580 0 0.0
.data 2660 2660 0 0.0
.text 906632 906632 0 0.0
window-app BRD4187C (read/write) 1106468 1106468 0 0.0
.bss 146164 146164 0 0.0
.data 3120 3120 0 0.0
.text 957164 957164 0 0.0
esp32 all-clusters-app c3devkit (read only) 1149146 1149144 -2 -0.0
(read/write) 1701908 1701908 0 0.0
.dram0.bss 79032 79032 0 0.0
.dram0.data 13076 13076 0 0.0
.flash.rodata 266048 266048 0 0.0
.flash.text 1149146 1149144 -2 -0.0
.iram0.text 75262 75262 0 0.0
m5stack (read only) 1191231 1191231 0 0.0
(read/write) 550114 550114 0 0.0
.dram0.bss 85408 85408 0 0.0
.dram0.data 34020 34020 0 0.0
.flash.rodata 297044 297044 0 0.0
.flash.text 1185847 1185847 0 0.0
.iram0.text 123311 123311 0 0.0
k32w contact k32w0+release (read only) 590100 590100 0 0.0
(read/write) 91320 91320 0 0.0
.bss 67372 67372 0 0.0
.data 2116 2116 0 0.0
.text 589564 589564 0 0.0
light k32w0+release (read only) 588788 588788 0 0.0
(read/write) 90952 90952 0 0.0
.bss 67020 67020 0 0.0
.data 2104 2104 0 0.0
.text 588252 588252 0 0.0
lock k32w0+release (read only) 561340 561340 0 0.0
(read/write) 88784 88784 0 0.0
.bss 64908 64908 0 0.0
.data 2048 2048 0 0.0
.text 560804 560804 0 0.0
linux all-clusters-app debug (read only) 5483761 5483761 0 0.0
(read/write) 417456 417456 0 0.0
.bss 130368 130368 0 0.0
.data 3984 3984 0 0.0
.data.rel.ro 275776 275776 0 0.0
.dynamic 624 624 0 0.0
.got 5384 5384 0 0.0
.init 27 27 0 0.0
.init_array 1288 1288 0 0.0
.rodata 333712 333712 0 0.0
.text 4773235 4773235 0 0.0
all-clusters-minimal-app debug (read only) 4898777 4898777 0 0.0
(read/write) 231408 231408 0 0.0
.bss 126048 126048 0 0.0
.data 3856 3856 0 0.0
.data.rel.ro 94376 94376 0 0.0
.dynamic 624 624 0 0.0
.got 5344 5344 0 0.0
.init 27 27 0 0.0
.init_array 1128 1128 0 0.0
.rodata 271814 271814 0 0.0
.text 4396835 4396835 0 0.0
bridge-app debug (read only) 2767969 2767969 0 0.0
(read/write) 133064 133064 0 0.0
.bss 51768 51768 0 0.0
.data 3792 3792 0 0.0
.data.rel.ro 71400 71400 0 0.0
.dynamic 624 624 0 0.0
.got 4640 4640 0 0.0
.init 27 27 0 0.0
.init_array 808 808 0 0.0
.rodata 214376 214376 0 0.0
.text 2376115 2376115 0 0.0
chip-tool debug (read only) 17767825 17767825 0 0.0
(read/write) 1055160 1055160 0 0.0
.bss 93688 93688 0 0.0
.data 5090 5090 0 0.0
.data.rel.ro 949040 949040 0 0.0
.dynamic 624 624 0 0.0
.got 5880 5880 0 0.0
.init 27 27 0 0.0
.init_array 792 792 0 0.0
.rodata 916561 916561 0 0.0
.text 14796259 14796259 0 0.0
chip-tool-ipv6only arm64 (read only) 16980620 16980620 0 0.0
(read/write) 1122712 1122712 0 0.0
.bss 103064 103064 0 0.0
.data 4392 4392 0 0.0
.data.rel.ro 986400 986400 0 0.0
.dynamic 512 512 0 0.0
.got 23360 23360 0 0.0
.init 24 24 0 0.0
.init_array 248 248 0 0.0
.rodata 827432 827432 0 0.0
.text 13913368 13913368 0 0.0
lighting-app debug+rpc+ui (read only) 5276953 5276953 0 0.0
(read/write) 222344 222344 0 0.0
.bss 118000 118000 0 0.0
.data 4528 4528 0 0.0
.data.rel.ro 92240 92240 0 0.0
.dynamic 672 672 0 0.0
.got 5928 5928 0 0.0
.init 27 27 0 0.0
.init_array 944 944 0 0.0
.rodata 338420 338420 0 0.0
.text 4696483 4696483 0 0.0
lock-app debug (read only) 4469121 4469121 0 0.0
(read/write) 202864 202864 0 0.0
.bss 113392 113392 0 0.0
.data 3728 3728 0 0.0
.data.rel.ro 78960 78960 0 0.0
.dynamic 624 624 0 0.0
.got 5264 5264 0 0.0
.init 27 27 0 0.0
.init_array 856 856 0 0.0
.rodata 247750 247750 0 0.0
.text 4012067 4012067 0 0.0
ota-provider-app debug (read only) 4126665 4126665 0 0.0
(read/write) 192152 192152 0 0.0
.bss 113792 113792 0 0.0
.data 4000 4000 0 0.0
.data.rel.ro 68448 68448 0 0.0
.dynamic 624 624 0 0.0
.got 4544 4544 0 0.0
.init 27 27 0 0.0
.init_array 720 720 0 0.0
.rodata 200934 200934 0 0.0
.text 3735459 3735459 0 0.0
ota-requestor-app debug (read only) 4220545 4220545 0 0.0
(read/write) 196464 196464 0 0.0
.bss 114848 114848 0 0.0
.data 4240 4240 0 0.0
.data.rel.ro 71448 71448 0 0.0
.dynamic 624 624 0 0.0
.got 4480 4480 0 0.0
.init 27 27 0 0.0
.init_array 776 776 0 0.0
.rodata 204326 204326 0 0.0
.text 3821619 3821619 0 0.0
shell debug (read only) 2928001 2928001 0 0.0
(read/write) 150712 150712 0 0.0
.bss 60040 60040 0 0.0
.data 784 784 0 0.0
.data.rel.ro 84024 84024 0 0.0
.dynamic 592 592 0 0.0
.got 4112 4112 0 0.0
.init 27 27 0 0.0
.init_array 1128 1128 0 0.0
.rodata 210642 210642 0 0.0
.text 2546514 2546514 0 0.0
thermostat-no-ble arm64 (read only) 4449908 4449908 0 0.0
(read/write) 244168 244168 0 0.0
.bss 122552 122552 0 0.0
.data 2864 2864 0 0.0
.data.rel.ro 102296 102296 0 0.0
.dynamic 512 512 0 0.0
.got 11976 11976 0 0.0
.init 24 24 0 0.0
.init_array 440 440 0 0.0
.rodata 161948 161948 0 0.0
.text 3949784 3949784 0 0.0
tv-app debug (read only) 5314433 5314433 0 0.0
(read/write) 350136 350136 0 0.0
.bss 241568 241568 0 0.0
.data 5104 5104 0 0.0
.data.rel.ro 96048 96048 0 0.0
.dynamic 624 624 0 0.0
.got 5616 5616 0 0.0
.init 27 27 0 0.0
.init_array 1136 1136 0 0.0
.rodata 272374 272374 0 0.0
.text 4798467 4798467 0 0.0
tv-casting-app debug (read only) 8294177 8294177 0 0.0
(read/write) 210848 210848 0 0.0
.bss 54496 54496 0 0.0
.data 2544 2544 0 0.0
.data.rel.ro 147016 147016 0 0.0
.dynamic 624 624 0 0.0
.got 5096 5096 0 0.0
.init 27 27 0 0.0
.init_array 1048 1048 0 0.0
.rodata 367612 367612 0 0.0
.text 7526451 7526451 0 0.0
mbed lock-app-release cy8cproto_062_4343w (read only) 6224 6224 0 0.0
(read/write) 2521192 2521192 0 0.0
.bss 220008 220008 0 0.0
.data 5120 5120 0 0.0
.text 1483876 1483876 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1218080 1218080 0 0.0
bss 154611 154611 0 0.0
rodata 141348 141348 0 0.0
text 843180 843180 0 0.0
nrf7002dk_nrf5340_cpuapp (read only) 4 4 0 0.0
(read/write) 1336808 1336808 0 0.0
bss 140069 140069 0 0.0
rodata 135440 135440 0 0.0
text 770628 770628 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 (read only) 4 4 0 0.0
(read/write) 1156120 1156120 0 0.0
bss 154790 154790 0 0.0
rodata 112732 112732 0 0.0
text 809620 809624 4 0.0
psoc6 all-clusters cy8ckit_062s2_43012 (read only) 837624 837624 0 0.0
(read/write) 1766476 1766476 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 193196 193196 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2520 2520 0 0.0
.debug_abbrev 1377935 1377935 0 0.0
.debug_aranges 143744 143744 0 0.0
.debug_frame 478872 478872 0 0.0
.debug_info 30050781 30050780 -1 -0.0
.debug_line 4139922 4139922 0 0.0
.debug_line_str 957 957 0 0.0
.debug_loclists 2245744 2245744 0 0.0
.debug_rnglists 142326 142326 0 0.0
.debug_str 4116156 4116156 0 0.0
.heap 837624 837624 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 801943 801943 0 0.0
.symtab 499808 499808 0 0.0
.text 0 0 0 0.0
1562372 1562372 0 0.0
.zero.table 8 8 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 (read only) 839576 839576 0 0.0
(read/write) 1673916 1673916 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 191308 191308 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2456 2456 0 0.0
.debug_abbrev 1283553 1283553 0 0.0
.debug_aranges 137048 137048 0 0.0
.debug_frame 461960 461960 0 0.0
.debug_info 27147086 27147086 0 0.0
.debug_line 3956811 3956811 0 0.0
.debug_line_str 981 981 0 0.0
.debug_loclists 2146632 2146632 0 0.0
.debug_rnglists 135447 135447 0 0.0
.debug_str 3975705 3975705 0 0.0
.heap 839576 839576 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 712577 712577 0 0.0
.symtab 465456 465456 0 0.0
.text 1471764 1471764 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
light cy8ckit_062s2_43012 (read only) 845784 845784 0 0.0
(read/write) 1605756 1605756 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 185212 185212 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2344 2344 0 0.0
.debug_abbrev 1124168 1124168 0 0.0
.debug_aranges 127320 127320 0 0.0
.debug_frame 425592 425592 0 0.0
.debug_info 22303015 22303013 -2 -0.0
.debug_line 3523405 3523405 0 0.0
.debug_line_str 942 942 0 0.0
.debug_loclists 1985853 1985853 0 0.0
.debug_rnglists 125337 125337 0 0.0
.debug_str 3786878 3786878 0 0.0
.heap 845784 845784 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 634185 634185 0 0.0
.symtab 430416 430416 0 0.0
.text 1409812 1409812 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
lock cy8ckit_062s2_43012 (read only) 818304 818304 0 0.0
(read/write) 1638796 1638796 0 0.0
.ARM.attributes 46 46 0 0.0
.ARM.exidx 8 8 0 0.0
.bss 212676 212676 0 0.0
.comment 212 212 0 0.0
.copy.table 24 24 0 0.0
.cy_m0p_image 6216 6216 0 0.0
.cy_sharedmem 8 8 0 0.0
.data 2360 2360 0 0.0
.debug_abbrev 1115472 1115472 0 0.0
.debug_aranges 126088 126088 0 0.0
.debug_frame 421140 421140 0 0.0
.debug_info 22207712 22207713 1 0.0
.debug_line 3477491 3477491 0 0.0
.debug_line_str 933 933 0 0.0
.debug_loclists 1963992 1963992 0 0.0
.debug_rnglists 123415 123415 0 0.0
.debug_str 3748315 3748315 0 0.0
.heap 818304 818304 0 0.0
.noinit 148 148 0 0.0
.ramVectors 736 736 0 0.0
.shstrtab 296 296 0 0.0
.stack_dummy 4096 4096 0 0.0
.strtab 607469 607469 0 0.0
.symtab 422224 422224 0 0.0
.text 1415372 1415372 0 0.0
.zero.table 0 0 0 0.0
8 8 0 0.0
qpg lighting-app qpg6105+debug (read/write) 1177572 1177572 0 0.0
.bss 101232 101232 0 0.0
.data 736 736 0 0.0
.text 624416 624416 0 0.0
lock-app qpg6105+debug (read/write) 1134628 1134628 0 0.0
.bss 95952 95952 0 0.0
.data 740 740 0 0.0
.text 581468 581468 0 0.0
telink all-clusters-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1069592 1069592 0 0.0
bss 107300 107300 0 0.0
text 728460 728460 0 0.0
all-clusters-minimal-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 976052 976052 0 0.0
bss 105276 105276 0 0.0
text 669086 669088 2 0.0
bridge-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 943876 943876 0 0.0
bss 109716 109716 0 0.0
text 646704 646704 0 0.0
contact-sensor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 875792 875792 0 0.0
bss 98896 98896 0 0.0
text 590052 590054 2 0.0
light-switch-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 904676 904676 0 0.0
bss 99488 99488 0 0.0
text 615684 615684 0 0.0
lighting-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 982220 982220 0 0.0
bss 107572 107572 0 0.0
text 685552 685550 -2 -0.0
lighting-app-factory-data tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 993592 993592 0 0.0
bss 111820 111820 0 0.0
text 693068 693066 -2 -0.0
lighting-app-rpc tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1051752 1051752 0 0.0
bss 109144 109144 0 0.0
text 730488 730486 -2 -0.0
lighting-app-shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 1083080 1083080 0 0.0
bss 120220 120220 0 0.0
text 750588 750590 2 0.0
lock-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 932780 932780 0 0.0
bss 99576 99576 0 0.0
text 620300 620300 0 0.0
ota-requestor-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 898420 898420 0 0.0
bss 100196 100196 0 0.0
text 611938 611936 -2 -0.0
pump-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 881288 881280 -8 -0.0
bss 99028 99028 0 0.0
text 595746 595744 -2 -0.0
pump-controller-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 868436 868436 0 0.0
bss 98828 98828 0 0.0
text 586182 586182 0 0.0
shell tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 744236 744228 -8 -0.0
bss 97256 97256 0 0.0
text 478646 478644 -2 -0.0
smoke_co_alarm-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 877852 877852 0 0.0
bss 98984 98984 0 0.0
text 593114 593114 0 0.0
temperature-measurement-app tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 864560 864560 0 0.0
bss 98736 98736 0 0.0
text 581784 581782 -2 -0.0
thermostat tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 910512 910512 0 0.0
bss 99280 99280 0 0.0
text 621226 621228 2 0.0
window-covering tlsr9518adk80d (read only) 4 4 0 0.0
(read/write) 905836 905836 0 0.0
bss 99592 99592 0 0.0
text 616098 616100 2 0.0

@mergify mergify bot merged commit b3d3685 into project-chip:master Aug 3, 2023
@bzbarsky-apple bzbarsky-apple deleted the fix-ble-shutdown-crash branch August 3, 2023 20:58
ajoletta-amzn pushed a commit to ajoletta-amzn/connectedhomeip that referenced this pull request Aug 4, 2023
Added the ability to transmit and display device name in the Matter SDK

Re-run zap_convert_all.py (project-chip#28459)

Add an API to get the list of running controllers from a controller factory. (project-chip#28461)

Add utilities for converting CATValues to/from NSSet. (project-chip#28453)

* Add utilities for converting CATValues to/from NSSet.

* Address review comments.

* Address more review comments.

[esp32 m5-stack light] move freertos functions to flash instead of iram (project-chip#28455)

* Move freertos functions out if iram.

This is because linkage fails with out of IRAM.

Following https://docs.espressif.com/projects/esp-idf/en/latest/esp32/api-guides/performance/ram-usage.html#optimizing-iram-usage

* Add newline at the end of the file

---------

Co-authored-by: Andrei Litvin <[email protected]>

virtual-device-app: Add LoadingFragment for commissioning establish started event (project-chip#28428)

Signed-off-by: Jaehoon You <[email protected]>

Add openiot clean steps (project-chip#28473)

Co-authored-by: Andrei Litvin <[email protected]>

[cloudbuild] switch to v2 of our build images. (project-chip#28476)

Co-authored-by: Andrei Litvin <[email protected]>

Update ZAP to pick up UI for multiple device types on an endpoint. (project-chip#28423)

tv-casting-app: Implementing PASE related callbacks (project-chip#28342)

* Linux tv-casting-app: Implementing AppDelegate

* Android tv-casting-app: Implementing AppDelegate

* iOS tv-casting-app: Implementing AppDelegate

[TC-RVC-2.1] Fix PIXIT codes to match the test plan (project-chip#28481)

* fix PIXIT codes to match tp

* fix PIXIT

Stop using controllerID for internal XPC bookkeeping. (project-chip#28480)

We want to use controllerID for client-assigned controller IDs.

Add functions to set Parent Endpoint and Composition Type for an Endpoint (project-chip#28410)

* Added endpointCompositionType to the EmberAfDefinedEndpoint structure to be used to hold whether an endpoint is flat or tree composed - defaults to Flat to assume previous behaviour as default

* Added functions to support setting and getting composition type and also to set an endpoints parent endpoint

* updated Read handler for parts list to make its else branch for Flat composition and then added a further branch to handle Tree composition

* Restyled by clang-format

* Fixed mistake in return type of emberAfEndpointCompositionTypeForEndpoint

* Removing debug logs

* Restyled by clang-format

* Moved new API funciotns to chip::app namespace and removed ember naming. Made endpoint struct use a proper bitmask as it was basically using an enum in a weird way

* Moved Read for Parts List to use new function naming

* Restyled by clang-format

* Replaced EmberAfStatus with CHIP_ERROR

* Restyled by clang-format

---------

Co-authored-by: Restyled.io <[email protected]>

Add macro to set alignment of sha256 context (project-chip#28426)

Fix uninitialised values in KeySet and AttributePathExpandIterator (project-chip#28356)

* Fix uninitialised value in KeySet

* Fix uninitilised mGlobalAttributeEndIndex

* Restyled by clang-format

* Review proposed change initilize mGlobalAttributeEndIndex

* Change initialize values in KeySet to initilize only start_time in EpochKey

* Restyled by clang-format

* Review proposed change initilize IPK keyset start_time

---------

Co-authored-by: Restyled.io <[email protected]>

Add a controller argument to the storage checker function. (project-chip#28488)

Most of the changes are just reindenting.

CASE: Send busy status report if we receive a sigma1 and we are in the middle of handshake (project-chip#28153)

* CASE: Send busy status report if we receive a sigma1 and we are in the
middle of handshake

* Apply suggestions from code review

Co-authored-by: Boris Zbarsky <[email protected]>

* Addressing review comments

* few more review comments

* Addressed reviews and added the unit tests

* Restyled by clang-format

* Few more review comments

* Apply suggestions from code review

Co-authored-by: Tennessee Carmel-Veilleux <[email protected]>

* Moved todo to better place

---------

Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Restyled.io <[email protected]>
Co-authored-by: Tennessee Carmel-Veilleux <[email protected]>

doc: chip_tool_guide: fix the order of arguments in (project-chip#28494)

`pairing code` command

chip-tool expects the node-id to be passed before payload.

Signed-off-by: Marcin Kajor <[email protected]>

add event For messages acks, Request ICD active mode when waiting on a ack (project-chip#28380)

[ReadHandler] Removal of test flags (project-chip#28421)

* Removed reportScheduler test flags and made TestReadInteractin.cpp wait for min/max instead of setting flags. Modified subscription times in the test to minimise the impact of waiting.

* Restyled by clang-format

* Added a driveAndServiceIO after waiting for max in test where we should wait for max to expire to ensure the run gets scheduled reliably

* Moved ctx.GetIOContext().DriveIO(); after each tests to garantee this will run after maxInterval is expired

* Implemented a mock clock in TestReadInteraction to reduce wait loops

* Removed more loops and added comment on loop left in the code

---------

Co-authored-by: Restyled.io <[email protected]>

[Silabs] Add SIT ICD configurations to silabs lock example (project-chip#28474)

* rename SED for ICD

* Delete ICD subscription callback since default behavior is merged

* Enable ICD default configuration for DL
Update configs to support ICDs

* Add ICDM attributes for SIT ICD config

* generated files

* update wordlist

* update readme

* update default config comments

* add define block for ICD configs

* fix esp

* try to fix esp again

* try to fix esp again

Add an example room air conditioner configuration to chef devices (project-chip#28485)

* Add an example room air conditioner configuration to chef devices

* Remove unuseful cluster in ep 0

* fix ci bug

* Revert "fix ci bug"

This reverts commit e31432e.

[docker] Use gcc 10 in chip build (project-chip#28478)

* Switch to gcc10 instead of gcc9 for chip build base

* Bump up version file

* Add -Dtests=false

---------

Co-authored-by: Andrei Litvin <[email protected]>

Reduce type character size of SceneTableImpl types (project-chip#28448)

virtual-device-app: Add control module for virtual device's detail view (project-chip#28486)

Signed-off-by: Jaehoon You <[email protected]>
Signed-off-by: Charles Kim <[email protected]>

Add `__test__ = False` to hooks (project-chip#28477)

Improve Silabs Matter shell functionality/stability (project-chip#28475)

* Re-worked matter shell to allow for copy/paste, fix varying platform functionality, and increase stability

* Update src/lib/shell/MainLoopSilabs.cpp

Co-authored-by: mkardous-silabs <[email protected]>

* Added further clarification in comments

---------

Co-authored-by: mkardous-silabs <[email protected]>

fix define (project-chip#28502)

Update python logic for executing work in chip main loop (project-chip#28449)

* Add python main loop work method

* Fix typo and restyle

* Fix typo

* Code review updates

* Comment update

* Restyle

---------

Co-authored-by: Andrei Litvin <[email protected]>

Fix crash when an error happens during a BLE scan on darwin. (project-chip#28505)

If we happened to do a BLE scan after doing a BLE connect, and then during the
BLE scan one of two things happens:

1. Bluetooth is shut down (e.g. by just turning it off via the menubar).
2. The scan is a delegate-less scan and times out.

then we would try to use the error handler that expects a SetUpCodePairer but
without an actual non-null SetUpCodePairer to pass it.  And then that would
crash.

The fix is to not call an error handler that we're not supposed to be calling;
scans do not call the _connection_ error handler.

Fix RESOURCE_EXHAUSTED in KeySetWrite (project-chip#28456)

* Fix RESOURCE_EXHAUSTED in KeySetWrite

* Restyled by prettier-yaml

---------

Co-authored-by: [email protected] <[email protected]>
Co-authored-by: Restyled.io <[email protected]>
Co-authored-by: Andrei Litvin <[email protected]>

Power source: Implementation of dynamic endpoint list setter (project-chip#28110)

* Implementation of dynamic endpoint list setter

Test: tested by adding a call to set endpoint list in all clusters
      with chip-tool. Also see TestPowerSourceCluster.cpp

* Restyled by whitespace

* Restyled by gn

* Remove the define

Some platforms run these tests, but don't have that define defined.
Instead, just change the function name to test only.

* Address review comments

* free is being called, man, where's the leak?

* Restyled by clang-format

* Address some review comments.

* Fix leak.

* Deal with zero-length arrays.

* shutdown -> clear

* Use EncodeList for list

* test fix.

* types need to match

---------

Co-authored-by: Restyled.io <[email protected]>

* Refine the laundry-washer-control server implementation and add laundry-washer-controls-delegate-impl (project-chip#28264)

* * Refine the laundry-washer-control server implementation
* Add laundry-washer-controls-delegate-impl

Signed-off-by: Chin-Ran Lo <[email protected]>

* Restyled by whitespace

* Restyled by clang-format

* Restyled by gn

* Update src/app/clusters/laundry-washer-controls-server/laundry-washer-controls-delegate.h

Co-authored-by: Boris Zbarsky <[email protected]>

* Update examples/all-clusters-app/all-clusters-common/include/laundry-washer-controls-delegate-impl.h

Co-authored-by: Boris Zbarsky <[email protected]>

* * Remove the unused code and refine the comment

Signed-off-by: Chin-Ran Lo <[email protected]>

* Update examples/all-clusters-app/all-clusters-common/include/laundry-washer-controls-delegate-impl.h

Co-authored-by: Arkadiusz Bokowy <[email protected]>

* Restyled by clang-format

---------

Signed-off-by: Chin-Ran Lo <[email protected]>
Co-authored-by: Restyled.io <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: Arkadiusz Bokowy <[email protected]>

Fix selector for status update on CHIPToolDeviceControllerDelegate. (project-chip#28506)

This did not get correctly updated in
project-chip#23665, so it was not
getting the status update callbacks.

[app] Add option to disable read client (project-chip#28149)

* app : Add option to disable Read Client

* Restyled by gn

* Format changes

* Restyled by clang-format

---------

Co-authored-by: Restyled.io <[email protected]>

enable android platform configuration (project-chip#28451)

Skip building python modules as part of Matter.framework build. (project-chip#28514)

We don't need them there, but also they unconditionally pull in perfetto bits,
which is also undesirable.

[mode-base-cluster]fix: build error while not enable On/Off cluster server (project-chip#28388)

* fix build error while not enable onOff cluster server

* fix include file bug

[Ameba] Update docker image (project-chip#28441)

* Update Dockerfile

* Update version

[K32W0] Use west tool to get SDK (project-chip#28431)

Signed-off-by: Marius Tache <[email protected]>

[Ameba] Upgrade cpp17 (project-chip#28438)

* fix cmake workaround for ameba
- upgrade pigweed app to c++17

* Update Dockerfile

* Update version

* Move to chip-build-ameba version 4 instead of 1, to suppor c++17

---------

Co-authored-by: Andrei Litvin <[email protected]>
Co-authored-by: Andrei Litvin <[email protected]>

Remove ICDM cluster for lighting app (project-chip#28522)

[Silabs] Rename SED build target to ICD for python scripts (project-chip#28504)

* rename sed to icd in build targets

* update txt tagets

* rename targets

[chef] disable Groups and Switch from example devices (project-chip#28501)

* A set of manual edits

* zap regen

* Script-disable groups and switch from EP0

* Zap regen
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants