-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[Scripts] Add to flake8 in workflow and fix python files (part #25193) #27887
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
arkq
merged 1 commit into
project-chip:master
from
DamMicSzm:flake8-fix-python-scripts-dir
Jul 11, 2023
Merged
[Scripts] Add to flake8 in workflow and fix python files (part #25193) #27887
arkq
merged 1 commit into
project-chip:master
from
DamMicSzm:flake8-fix-python-scripts-dir
Jul 11, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Damian-Nordic
approved these changes
Jul 11, 2023
PR #27887: Size comparison from aaa2542 to 5b02b1e Increases (7 builds for bl702, bl702l, psoc6, qpg, telink)
Decreases (14 builds for bl602, bl702, cc32xx, esp32, nrfconnect, psoc6, qpg, telink)
Full report (58 builds for bl602, bl702, bl702l, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
arkq
approved these changes
Jul 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is a part of #25193 ( part fix python files in python scripts dir )
Problem
Python files need prevent things like syntax errors, typos, bad style, etc... it saves time for reviewing your code. Many python files needed bug fixes.
Changes
Fix all python files in python tools where linter find problem. Adding python tests to check with flake8.
Testing
CI will test and maybe some another manual testing