-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[Matter_yamltests] Add to flake8 in workflow and fix python files (part #25193) #25250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PR #25250: Size comparison from 92d86d5 to 71e7686 Decreases (1 build for cc32xx)
Full report (2 builds for cc32xx, mbed)
|
71e7686
to
fb80638
Compare
PR #25250: Size comparison from eff5773 to fb80638 Decreases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
fb80638
to
f3ef482
Compare
PR #25250: Size comparison from 3957377 to f3ef482 Decreases (2 builds for cc32xx, qpg)
Full report (3 builds for cc32xx, qpg)
|
f3ef482
to
41f8137
Compare
PR #25250: Size comparison from 1a1d0c3 to 41f8137 Increases (1 build for cc32xx)
Full report (1 build for cc32xx)
|
41f8137
to
c1e7df2
Compare
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
ping @DamMicSzm |
ac95ca7
to
bcaed44
Compare
PR #25250: Size comparison from da148bc to bcaed44 Increases (5 builds for esp32, nrfconnect, psoc6, telink)
Decreases (11 builds for bl602, cc32xx, esp32, psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
bcaed44
to
20794be
Compare
PR #25250: Size comparison from c8b49b9 to 20794be Increases (15 builds for bl702, cc32xx, nrfconnect, psoc6, qpg, telink)
Decreases (6 builds for psoc6, telink)
Full report (57 builds for bl602, bl702, cc32xx, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, psoc6, qpg, telink)
|
|
||
from matter_idl import matter_idl_types | ||
|
||
__ALL__ = (matter_idl_types) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why this?
EDIT: Unfortunately the PR was merged automatically when I've resolved a conversation.... Anyway I think that you might remove this in some other PR related to flake8.
This pull request is a part of #25193 ( part fix python files in Matter_yamltests )
Problem
Python files need prevent things like syntax errors, typos, bad style, etc... it saves time for reviewing your code. Many python files needed bug fixes.
Changes
Fix all python files in Matter_yamltests where linter find problem. Adding Matter_yamltests to check with flake8.
Testing
CI will test and maybe some another manual testing