[nrfconnect] Fix compilation warnings and turn on -Werror for examples #4528
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename BIT/BYTE_x macros from the ember code to fix the BIT macro redeclaration (the same macro is provided by Zephyr).
saurabhst
approved these changes
Jan 27, 2021
andy31415
approved these changes
Jan 27, 2021
woody-apple
approved these changes
Jan 27, 2021
| list[listLen] = LOW_BYTE(entry.groupId); | ||
| list[listLen + 1] = HIGH_BYTE(entry.groupId); | ||
| list[listLen] = EMBER_LOW_BYTE(entry.groupId); | ||
| list[listLen + 1] = EMBER_HIGH_BYTE(entry.groupId); |
There was a problem hiding this comment.
Adding a reference to this issue, for when this is done :)
#1610
austinh0
pushed a commit
to austinh0/connectedhomeip
that referenced
this pull request
Jan 28, 2021
project-chip#4528) Rename BIT/BYTE_x macros from the ember code to fix the BIT macro redeclaration (the same macro is provided by Zephyr).
austinh0
pushed a commit
to austinh0/connectedhomeip
that referenced
this pull request
Jan 28, 2021
project-chip#4528) Rename BIT/BYTE_x macros from the ember code to fix the BIT macro redeclaration (the same macro is provided by Zephyr).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Building nRF Connect examples results in the following warnings:
due to the
BITmacro defined both in the Zephyr andsrc/app/util/types_stub.h.Summary of Changes
Rename BIT/BYTE_x macros in the ember code to fix the BIT macro redefinition.