Skip to content

nodiscard ChipError Batch #3: example apps J-Z #41861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

nodiscard ChipError Batch #3: example apps J-Z #41861

wants to merge 2 commits into from
+284 −242

Conversation

@gmarcosb
Copy link
Contributor

@gmarcosb gmarcosb commented Nov 7, 2025 •
edited
Loading

Summary

Batch 3 of ignored ChipError for #41629

Related issues

#41629

Testing

CI

Readability checklist

The checklist below will help the reviewer finish PR review in time and keep the
code readable:

  • PR title is
    descriptive
  • Apply the
    “When in Rome…”
    rule (coding style)
  • PR size is short
  • Try to avoid "squashing" and "force-update" in commit history
  • CI time didn't increase

See: Pull Request Guidelines

@github-actions
Copy link

github-actions bot commented Nov 7, 2025 •
edited
Loading

PR #41861: Size comparison from 1eb1102 to 0af43aa

Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
platform target config section 1eb1102b 0af43aa change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1106354 1106354 0 0.0
RAM 178930 178930 0 0.0
bl702 lighting-app bl702+eth FLASH 661428 661428 0 0.0
RAM 135025 135025 0 0.0
bl702+wifi FLASH 837022 837022 0 0.0
RAM 124445 124445 0 0.0
bl706+mfd+rpc+littlefs FLASH 1070624 1070624 0 0.0
RAM 117317 117317 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 900056 900056 0 0.0
RAM 105612 105612 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 983370 983370 0 0.0
RAM 109796 109796 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 770820 770820 0 0.0
RAM 103360 103360 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 782672 782672 0 0.0
RAM 108528 108528 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 728604 728604 0 0.0
RAM 97420 97420 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 713080 713080 0 0.0
RAM 97636 97636 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 554922 554922 0 0.0
RAM 205776 205776 0 0.0
lock CC3235SF_LAUNCHXL FLASH 587802 587802 0 0.0
RAM 205872 205872 0 0.0
efr32 lock-app BRD4187C FLASH 963496 963496 0 0.0
RAM 123572 123572 0 0.0
BRD4338a FLASH 757752 757752 0 0.0
RAM 254196 254196 0 0.0
window-app BRD4187C FLASH 1058820 1058820 0 0.0
RAM 119800 119800 0 0.0
esp32 all-clusters-app c3devkit DRAM 102572 102572 0 0.0
FLASH 1836848 1836848 0 0.0
IRAM 93540 93540 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 933456 933456 0 0.0
RAM 161377 161377 0 0.0
nxp contact mcxw71+release FLASH 692512 692512 0 0.0
RAM 61552 61552 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1678092 1678092 0 0.0
RAM 213956 213956 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1594492 1594492 0 0.0
RAM 211156 211156 0 0.0
light cy8ckit_062s2_43012 FLASH 1460732 1460732 0 0.0
RAM 197776 197776 0 0.0
lock cy8ckit_062s2_43012 FLASH 1493420 1493420 0 0.0
RAM 225496 225496 0 0.0
qpg lighting-app qpg6200+debug FLASH 837760 837760 0 0.0
RAM 127768 127768 0 0.0
lock-app qpg6200+debug FLASH 774588 774588 0 0.0
RAM 118736 118736 0 0.0
realtek light-switch-app rtl8777g FLASH 706960 706960 0 0.0
RAM 106964 106964 0 0.0
lighting-app rtl8777g FLASH 757912 757912 0 0.0
RAM 127296 127296 0 0.0
stm32 light STM32WB5MM-DK FLASH 470232 470232 0 0.0
RAM 141352 141352 0 0.0
telink bridge-app tl7218x FLASH 710622 710622 0 0.0
RAM 90600 90600 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 797098 797098 0 0.0
RAM 41024 41024 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 788300 788300 0 0.0
RAM 93700 93700 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 715300 715300 0 0.0
RAM 51892 51892 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 748596 748596 0 0.0
RAM 70932 70932 0 0.0
light-switch-app-ota-factory-data tl3218x_retention FLASH 725450 725450 0 0.0
RAM 34624 34624 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 602686 602686 0 0.0
RAM 108928 108928 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 820932 820936 4 0.0
RAM 92096 92096 0 0.0

@gmarcosb
Copy link
Contributor Author

gmarcosb commented Nov 7, 2025

/gemini-review

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Nov 7, 2025

Thank you for addressing the nodiscard ChipError warnings across these example applications. The changes consistently apply TEMPORARY_RETURN_IGNORED, SuccessOrDie, or ReturnErrorOnFailure where appropriate, which significantly improves error handling and code robustness. This batch effectively tackles the identified issues in the specified files.

@gmarcosb gmarcosb marked this pull request as ready for review November 7, 2025 19:40
@github-actions
Copy link

github-actions bot commented Nov 7, 2025 •
edited
Loading

PR #41861: Size comparison from 1eb1102 to ff7c20a

Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
platform target config section 1eb1102b ff7c20a change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1106354 1106378 24 0.0
RAM 178930 178930 0 0.0
bl702 lighting-app bl702+eth FLASH 661428 661452 24 0.0
RAM 135025 135025 0 0.0
bl702+wifi FLASH 837022 837046 24 0.0
RAM 124445 124445 0 0.0
bl706+mfd+rpc+littlefs FLASH 1070624 1070648 24 0.0
RAM 117317 117317 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 900056 900080 24 0.0
RAM 105612 105612 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 983370 983394 24 0.0
RAM 109796 109796 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 770820 770840 20 0.0
RAM 103360 103360 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 782672 782692 20 0.0
RAM 108528 108528 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 728604 728624 20 0.0
RAM 97420 97420 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 713080 713100 20 0.0
RAM 97636 97636 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 554922 554946 24 0.0
RAM 205776 205776 0 0.0
lock CC3235SF_LAUNCHXL FLASH 587802 587818 16 0.0
RAM 205872 205872 0 0.0
efr32 lock-app BRD4187C FLASH 963496 963528 32 0.0
RAM 123572 123572 0 0.0
BRD4338a FLASH 757752 757768 16 0.0
RAM 254196 254196 0 0.0
window-app BRD4187C FLASH 1058820 1058852 32 0.0
RAM 119800 119800 0 0.0
esp32 all-clusters-app c3devkit DRAM 102572 102572 0 0.0
FLASH 1836848 1836880 32 0.0
IRAM 93540 93540 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 933456 933476 20 0.0
RAM 161377 161377 0 0.0
nxp contact mcxw71+release FLASH 692512 692520 8 0.0
RAM 61552 61552 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1678092 1678124 32 0.0
RAM 213956 213956 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1594492 1594508 16 0.0
RAM 211156 211156 0 0.0
light cy8ckit_062s2_43012 FLASH 1460732 1460748 16 0.0
RAM 197776 197776 0 0.0
lock cy8ckit_062s2_43012 FLASH 1493420 1493436 16 0.0
RAM 225496 225496 0 0.0
qpg lighting-app qpg6200+debug FLASH 837760 837792 32 0.0
RAM 127768 127768 0 0.0
lock-app qpg6200+debug FLASH 774588 774604 16 0.0
RAM 118736 118736 0 0.0
realtek light-switch-app rtl8777g FLASH 706960 706984 24 0.0
RAM 106964 106964 0 0.0
lighting-app rtl8777g FLASH 757912 757928 16 0.0
RAM 127296 127296 0 0.0
stm32 light STM32WB5MM-DK FLASH 470232 470252 20 0.0
RAM 141352 141352 0 0.0
telink bridge-app tl7218x FLASH 710622 710646 24 0.0
RAM 90600 90600 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 797098 797122 24 0.0
RAM 41024 41024 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 788300 788324 24 0.0
RAM 93700 93700 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 715300 715324 24 0.0
RAM 51892 51892 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 748596 748620 24 0.0
RAM 70932 70932 0 0.0
light-switch-app-ota-factory-data tl3218x_retention FLASH 725450 725474 24 0.0
RAM 34624 34624 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 602686 602710 24 0.0
RAM 108928 108928 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 820932 820960 28 0.0
RAM 92096 92096 0 0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

examples linux platform review - pending

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@gmarcosb