ESP32: fix nimble initialization for ESP32-P4 and add instruction doc for ESP-Hosted #41422
+61
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes BLE initialization for ESP32-P4 when using ESP-Hosted and adds documentation for ESP-Hosted setup. The changes enable proper BT controller initialization on co-processor systems and provide user guidance for setting up ESP32-P4 with ESP-Hosted.
Key changes:
- Added ESP-Hosted BT controller initialization code for ESP32-P4
- Removed obsolete ESP32-P4 stub function that's no longer needed
- Added comprehensive ESP-Hosted setup documentation
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| src/platform/ESP32/nimble/BLEManagerImpl.cpp | Added ESP-Hosted BT controller initialization and removed obsolete ESP32-P4 stub |
| docs/platforms/esp32/index.md | Added reference to new ESP-Hosted documentation |
| docs/platforms/esp32/esp_hosted.md | Created comprehensive ESP-Hosted setup guide for ESP32-P4 |
| config/esp32/components/chip/idf_component.yml | Added ESP-Hosted component dependency for ESP32-P4 |
There was a problem hiding this comment.
Code Review
This pull request updates the esp-hosted component and adds the necessary initialization for the BLE controller on the ESP32-P4. It also includes new documentation for using ESP-Hosted. My review focuses on improving error handling in the initialization logic and fixing some typos in the new documentation. The changes are generally good, but the error handling for the new esp-hosted initialization calls should be made more robust to prevent potential issues.
|
PR #41422: Size comparison from 5a37876 to aa7ca17 Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #41422 +/- ##
==========================================
- Coverage 50.95% 50.94% -0.02%
==========================================
Files 1378 1378
Lines 100635 100698 +63
Branches 13023 13058 +35
==========================================
+ Hits 51280 51302 +22
- Misses 49355 49396 +41 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
42feb27 to
aa7ca17
Compare
|
PR #41422: Size comparison from 966e378 to 860bd80 Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The esp-hosted has been updated to v2.5.11, we should enable the BLE controller on co-processor manually for ESP32-P4, as described in https://github.com/espressif/esp-hosted-mcu/blob/main/docs/migration_guide.md#migrating-to-v252
Related issues
N/A
Testing
Tested matter commissioning with ESP32-P4 Function EV board using the all-clusters-app.