Skip to content

[Realtek] add CONFIG_DAC_KEY_ENC #41421

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 14, 2025
Merged

[Realtek] add CONFIG_DAC_KEY_ENC #41421

merged 2 commits into from
Oct 14, 2025
+7 −2

Conversation

pankore
Copy link
Contributor

@pankore pankore commented Oct 11, 2025

Summary

This pull request adds CONFIG_DAC_KEY_ENC

Testing

Tested the build locally and performed basic sanity.

gemini-code-assist[bot]
gemini-code-assist bot reviewed Oct 11, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds the CONFIG_DAC_KEY_ENC build flag for Realtek platforms. The changes correctly add the compiler definition in CMake and update the preprocessor logic in RTKDACVendorProvider.cpp. I have one minor suggestion to improve code maintainability.

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 11, 2025 •
edited
Loading

PR #41421: Size comparison from 5a37876 to c5465f3

Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
platform target config section 5a37876 c5465f3 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1105406 1105406 0 0.0
RAM 178754 178754 0 0.0
bl702 lighting-app bl702+eth FLASH 659894 659894 0 0.0
RAM 134825 134825 0 0.0
bl702+wifi FLASH 835978 835978 0 0.0
RAM 124301 124301 0 0.0
bl706+mfd+rpc+littlefs FLASH 1069114 1069114 0 0.0
RAM 117141 117141 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 899328 899328 0 0.0
RAM 105476 105476 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 981876 981876 0 0.0
RAM 109628 109628 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 769432 769432 0 0.0
RAM 103208 103208 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 781076 781076 0 0.0
RAM 108360 108360 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 727072 727072 0 0.0
RAM 97276 97276 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 711540 711540 0 0.0
RAM 97484 97484 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 554310 554310 0 0.0
RAM 205544 205544 0 0.0
lock CC3235SF_LAUNCHXL FLASH 587034 587034 0 0.0
RAM 205768 205768 0 0.0
efr32 lock-app BRD4187C FLASH 961168 961168 0 0.0
RAM 126228 126228 0 0.0
BRD4338a FLASH 755896 755888 -8 -0.0
RAM 255516 255516 0 0.0
window-app BRD4187C FLASH 1055508 1055508 0 0.0
RAM 122424 122424 0 0.0
esp32 all-clusters-app c3devkit DRAM 103016 103016 0 0.0
FLASH 1792516 1792516 0 0.0
IRAM 83862 83862 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 929968 929968 0 0.0
RAM 160987 160987 0 0.0
nxp contact mcxw71+release FLASH 691800 691800 0 0.0
RAM 61440 61440 0 0.0
lighting mcxw71+release FLASH 723368 723368 0 0.0
RAM 68100 68100 0 0.0
lock mcxw71+release FLASH 770592 770592 0 0.0
RAM 61804 61804 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1672460 1672460 0 0.0
RAM 213620 213620 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1589940 1589940 0 0.0
RAM 210900 210900 0 0.0
light cy8ckit_062s2_43012 FLASH 1456772 1456772 0 0.0
RAM 197616 197616 0 0.0
lock cy8ckit_062s2_43012 FLASH 1489084 1489084 0 0.0
RAM 225328 225328 0 0.0
qpg lighting-app qpg6200+debug FLASH 835432 835432 0 0.0
RAM 127604 127604 0 0.0
lock-app qpg6200+debug FLASH 772180 772180 0 0.0
RAM 118580 118580 0 0.0
realtek light-switch-app rtl8777g FLASH 705368 705368 0 0.0
RAM 106784 106784 0 0.0
lighting-app rtl8777g FLASH 756568 756568 0 0.0
RAM 127132 127132 0 0.0
stm32 light STM32WB5MM-DK FLASH 469068 469068 0 0.0
RAM 141208 141208 0 0.0
telink bridge-app tl7218x FLASH 708408 708408 0 0.0
RAM 90356 90356 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 795940 795940 0 0.0
RAM 40908 40908 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 787136 787136 0 0.0
RAM 93552 93552 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 713942 713942 0 0.0
RAM 51724 51724 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 747246 747246 0 0.0
RAM 70772 70772 0 0.0
light-switch-app-ota-factory-data tl3218x_retention FLASH 724098 724098 0 0.0
RAM 34472 34472 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 601366 601366 0 0.0
RAM 108600 108600 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 819756 819760 4 0.0
RAM 91948 91948 0 0.0

@codecov Codecov
Copy link

codecov bot commented Oct 11, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 50.94%. Comparing base (5a37876) to head (c5465f3).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #41421   +/-   ##
=======================================
  Coverage   50.94%   50.94%           
=======================================
  Files        1378     1378           
  Lines      100698   100698           
  Branches    13058    13058           
=======================================
  Hits        51302    51302           
  Misses      49396    49396

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@andy31415 andy31415 added the sdk-maintainer-approved PR marked by `matter-sdk-maintainers` as suitable for MERGE - meets guideline & sufficient reviews. label Oct 14, 2025
@mergify mergify bot merged commit 5784ffe into project-chip:master Oct 14, 2025
75 checks passed
@pankore pankore deleted the bee_pr_20251011 branch October 14, 2025 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andy31415 andy31415 andy31415 approved these changes

+1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

config platform realtek review - pending sdk-maintainer-approved PR marked by `matter-sdk-maintainers` as suitable for MERGE - meets guideline & sufficient reviews.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pankore @andy31415