-
Notifications
You must be signed in to change notification settings - Fork 2.3k
[NXP] enable mbedtls 3.x for mcxw72 #41443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NXP] enable mbedtls 3.x for mcxw72 #41443
Conversation
Signed-off-by: Marius Preda <[email protected]>
Signed-off-by: Martin Girardot <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request enables the use of mbedTLS 3.x for the NXP MCXW72 platform, providing flexibility to switch between mbedTLS versions. The changes primarily involve updating submodules and modifying the build configuration to remove platform-specific mbedtls include paths. A necessary header, mbedtls/version.h
, is also included in CHIPCryptoPalS200.cpp
to support version-dependent compilation. My review includes a minor suggestion to maintain consistency in header inclusion style. Overall, the changes appear correct and well-aligned with the goal of improving mbedTLS version flexibility.
PR #41443: Size comparison from f902839 to e453422 Full report (10 builds for cc13x4_26x4, cc32xx, nrfconnect, realtek, stm32)
|
Signed-off-by: Martin Girardot <[email protected]>
PR #41443: Size comparison from f902839 to 2707e23 Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #41443 +/- ##
=======================================
Coverage 50.94% 50.94%
=======================================
Files 1378 1378
Lines 100698 100698
Branches 13058 13058
=======================================
Hits 51302 51302
Misses 49396 49396 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving because it has platform owner approval
Summary
This PR adds support for using mbedTLS 3.x with the NXP MCXW72 platform. By default, the platform uses mbedTLS 2.x, but users can use version 3.x by passing the following argument to the west build command:
-DCONFIG_CHIP_MBEDTLS_3X=y
This flexibility allows to migrate to mbedTLS 3.x while maintaining compatibility with existing setups.
Testing
BLE thread commissioning with contact sensor mcxw72 example, 1 commissioning with mbedtls 2.X and 1 commissioning with mbedtls 3.x completed successfully
Readability checklist
The checklist below will help the reviewer finish PR review in time and keep the
code readable:
descriptive
“When in Rome…”
rule (coding style)
See: Pull Request Guidelines