[SILABS] Carry-over support code from matter_support into SPAM #41441
+54
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR #41441: Size comparison from f902839 to 0f32bf0 Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #41441 +/- ##
==========================================
+ Coverage 50.95% 50.98% +0.02%
==========================================
Files 1378 1379 +1
Lines 100635 100765 +130
Branches 13023 13059 +36
==========================================
+ Hits 51280 51375 +95
- Misses 49355 49390 +35 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR moves code from the matter_support submodule to the appropriate location within SPAM (Silicon Labs Platform Abstraction Module). The main purpose is to integrate silicon labs specific support code directly into the codebase rather than relying on a submodule.
- Updates the matter_support submodule to a new commit
- Removes dependency on external HAL file from matter_support
- Adds clock configuration and button ISR functionality directly to WiseMcuSpam.cpp
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| third_party/silabs/matter_support | Updates submodule to new commit hash |
| third_party/silabs/SiWx917_sdk.gni | Removes external HAL file dependency |
| src/platform/silabs/platformAbstraction/WiseMcuSpam.cpp | Adds clock configuration defines, PLL setup function, and button ISR implementation |
jmartinez-silabs
approved these changes
Oct 14, 2025
|
PR #41441: Size comparison from f902839 to ef06a27 Increases above 0.2%:
Full report (34 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moving the code from the submodule to the correct place inside SPAM.
Related issues
N/A
Testing
Manually tested with lock and lighting application with basic commissioning.
Readability checklist
The checklist below will help the reviewer finish PR review in time and keep the
code readable:
descriptive
“When in Rome…”
rule (coding style)
See: Pull Request Guidelines