[Ameba][v1.4-branch] Add OnConnectWiFiNetworkFailed to AmebaWiFiDriver #40941
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a fix for commissioning retries on Ameba platforms after a failed connection attempt. The approach of adding an OnConnectWiFiNetworkFailed callback to reset the commissioning state is correct. My review includes suggestions to enhance this new callback by passing the failure reason, which will allow for more accurate error reporting to the client (e.g., distinguishing between 'network not found' and 'authentication failure'). This will improve the robustness and user experience of the commissioning process.
* OnConnectWiFiNetworkFailed is called when Ameba failed to connect into the network * This fixes issue when chip-tool failed to commission Ameba after one failed attempt
b0b5dbd to
d7c6142
Compare
|
@pankore please add to the PR summary what parts in the master branch were cherrypicked here or if no cherrypicks applied, an explanation on why these changes do not apply to master. The reason for this is that we want to ensure that all fixes are also contained on master, so we ask for fixes to master first. |
There was a problem hiding this comment.
I do not see similar changes in master: https://github.com/project-chip/connectedhomeip/blob/master/src/platform/Ameba/ConnectivityManagerImpl.cpp
|
Hi @andy31415, I just raised PR #41002 with the same changes to master, please help to check |
|
Approved after master PR merged. |
Summary
Testing
Before changes
After changes