-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Decouple OperationalCredentials cluster. #40804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decouple OperationalCredentials cluster. #40804
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #40804 +/- ##
==========================================
+ Coverage 50.96% 50.99% +0.02%
==========================================
Files 1375 1377 +2
Lines 100512 100540 +28
Branches 13006 13006
==========================================
+ Hits 51227 51268 +41
+ Misses 49285 49272 -13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
src/app/clusters/operational-credentials-server/CodegenIntegration.cpp
Outdated
Show resolved
Hide resolved
PR #40804: Size comparison from c34cb1b to b32c261 Full report (36 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
PR #40804: Size comparison from c34cb1b to 8e39c4c Full report (36 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
scripts/tools/zap/tests/outputs/all-clusters-app/app-templates/endpoint_config.h
Outdated
Show resolved
Hide resolved
src/app/clusters/operational-credentials-server/operational-credentials-cluster.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/operational-credentials-server/operational-credentials-cluster.cpp
Show resolved
Hide resolved
src/app/clusters/operational-credentials-server/operational-credentials-cluster.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/operational-credentials-server/operational-credentials-cluster.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/operational-credentials-server/operational-credentials-cluster.cpp
Show resolved
Hide resolved
src/app/clusters/operational-credentials-server/operational-credentials-cluster.cpp
Show resolved
Hide resolved
src/app/clusters/operational-credentials-server/operational-credentials-cluster.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/operational-credentials-server/operational-credentials-cluster.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/operational-credentials-server/operational-credentials-cluster.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/operational-credentials-server/operational-credentials-cluster.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/operational-credentials-server/operational-credentials-cluster.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/operational-credentials-server/operational-credentials-cluster.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/operational-credentials-server/operational-credentials-cluster.cpp
Show resolved
Hide resolved
src/app/clusters/operational-credentials-server/operational-credentials-cluster.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/operational-credentials-server/operational-credentials-cluster.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/operational-credentials-server/operational-credentials-cluster.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/operational-credentials-server/operational-credentials-cluster.cpp
Outdated
Show resolved
Hide resolved
src/app/clusters/operational-credentials-server/operational-credentials-cluster.cpp
Show resolved
Hide resolved
src/app/clusters/operational-credentials-server/operational-credentials-cluster.cpp
Outdated
Show resolved
Hide resolved
PR #40804: Size comparison from 33e249b to 9ff4b2a Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
PR #40804: Size comparison from 8abc4a6 to 29810e5 Full report (36 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nxp, psoc6, qpg, realtek, stm32, telink)
|
PR #40804: Size comparison from 3e2f37e to 6bba628 Full report (34 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, psoc6, qpg, realtek, stm32, telink)
|
PR #40804: Size comparison from 7f4a7da to d90c19d Full report (30 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, nrfconnect, psoc6, qpg, realtek, stm32, telink)
|
PR #40804: Size comparison from 4d75089 to c762d61 Full report (34 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, psoc6, qpg, realtek, stm32, telink)
|
PR #40804: Size comparison from 7cc850d to 01de80a Full report (37 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
|
Summary
Cluster decoupling for OperationalCredential
Still need to confirm if some changes and implementations are correct. Also I suspect that some functions shouldn't be called from the decoupled implementation.
Related issues
Fixes #40695
Testing
Tested manually commissioning with matter-repl and CI checks to confirm backwards compatibility.