Skip to content

Conversation

lboue
Copy link
Contributor

@lboue lboue commented Aug 18, 2025

Summary

Fix Matter Refrigerator and Temperature Controlled Example

  • Remove white space
  • Fix anchor link's

Related issues

N/A

Testing

Rendering the markdown page.

Readability checklist

The checklist below will help the reviewer finish PR review in time and keep the
code readable:

  • PR title is
    descriptive
  • Apply the
    “When in Rome…”
    rule (coding style)
  • PR size is short
  • Try to avoid "squashing" and "force-update" in commit history
  • CI time didn't increase

See: Pull Request Guidelines

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly removes an extra whitespace from a markdown link anchor in README.md, which fixes a broken link. I've added one suggestion to further improve the link by normalizing the anchor's casing to all lowercase. This is a best practice that improves portability across different markdown parsers and makes it consistent with other links in the file.

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@lboue lboue changed the title Remove white space Fix Matter Refrigerator and Temperature Controlled Example Aug 18, 2025
Copy link

github-actions bot commented Aug 18, 2025

PR #40625: Size comparison from 97920ba to 874a504

Full report (57 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 97920ba 874a504 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1105864 1105864 0 0.0
RAM 179018 179018 0 0.0
bl702 lighting-app bl702+eth FLASH 658740 658740 0 0.0
RAM 134929 134929 0 0.0
bl702+wifi FLASH 836370 836370 0 0.0
RAM 124509 124509 0 0.0
bl706+mfd+rpc+littlefs FLASH 1068378 1068378 0 0.0
RAM 117349 117349 0 0.0
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 897816 897816 0 0.0
RAM 105660 105660 0 0.0
lighting-app bl702l+mfd+littlefs FLASH 981530 981530 0 0.0
RAM 109844 109844 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 767932 767932 0 0.0
RAM 103368 103368 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 779536 779536 0 0.0
RAM 108536 108536 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 725516 725516 0 0.0
RAM 96932 96932 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 709992 709992 0 0.0
RAM 97140 97140 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 552230 552230 0 0.0
RAM 205120 205120 0 0.0
lock CC3235SF_LAUNCHXL FLASH 584162 584162 0 0.0
RAM 205328 205328 0 0.0
efr32 lock-app BRD4187C FLASH 959328 959328 0 0.0
RAM 122644 122644 0 0.0
BRD4338a FLASH 755184 755184 0 0.0
RAM 251908 251908 0 0.0
window-app BRD4187C FLASH 1053036 1053036 0 0.0
RAM 118872 118872 0 0.0
esp32 all-clusters-app c3devkit DRAM 102512 102512 0 0.0
FLASH 1768960 1768960 0 0.0
IRAM 83862 83862 0 0.0
m5stack DRAM 121364 121364 0 0.0
FLASH 1716262 1716262 0 0.0
IRAM 117051 117051 0 0.0
linux air-purifier-app debug unknown 4864 4864 0 0.0
FLASH 2598788 2598788 0 0.0
RAM 117264 117264 0 0.0
all-clusters-app debug unknown 5696 5696 0 0.0
FLASH 6080300 6080300 0 0.0
RAM 537928 537928 0 0.0
all-clusters-minimal-app debug unknown 5536 5536 0 0.0
FLASH 5214120 5214120 0 0.0
RAM 228832 228832 0 0.0
bridge-app debug unknown 5568 5568 0 0.0
FLASH 4600380 4600380 0 0.0
RAM 209080 209080 0 0.0
camera-app debug unknown 9296 9296 0 0.0
FLASH 6969707 6969707 0 0.0
RAM 234992 234992 0 0.0
camera-controller debug unknown 9216 9216 0 0.0
FLASH 13645051 13645051 0 0.0
RAM 668960 668960 0 0.0
chip-tool debug unknown 6264 6264 0 0.0
FLASH 13693669 13693669 0 0.0
RAM 655864 655864 0 0.0
chip-tool-ipv6only arm64 unknown 40736 40736 0 0.0
FLASH 12721239 12721239 0 0.0
RAM 690824 690824 0 0.0
closure-app debug unknown 5536 5536 0 0.0
FLASH 4582194 4582194 0 0.0
RAM 200976 200976 0 0.0
fabric-admin debug unknown 5944 5944 0 0.0
FLASH 12038144 12038144 0 0.0
RAM 654872 654872 0 0.0
fabric-bridge-app debug unknown 4816 4816 0 0.0
FLASH 4399290 4399290 0 0.0
RAM 194792 194792 0 0.0
fabric-sync debug unknown 5056 5056 0 0.0
FLASH 5485669 5485669 0 0.0
RAM 494520 494520 0 0.0
lighting-app debug+rpc+ui unknown 6272 6272 0 0.0
FLASH 5470273 5470273 0 0.0
RAM 210296 210296 0 0.0
lock-app debug unknown 5496 5496 0 0.0
FLASH 4629084 4629084 0 0.0
RAM 197488 197488 0 0.0
ota-provider-app debug unknown 4856 4856 0 0.0
FLASH 4257988 4257988 0 0.0
RAM 186120 186120 0 0.0
ota-requestor-app debug unknown 4736 4736 0 0.0
FLASH 4321068 4321068 0 0.0
RAM 188928 188928 0 0.0
shell debug unknown 4312 4312 0 0.0
FLASH 2942467 2942467 0 0.0
RAM 149704 149704 0 0.0
thermostat-no-ble arm64 unknown 9880 9880 0 0.0
FLASH 4236703 4236703 0 0.0
RAM 227256 227256 0 0.0
tv-app debug unknown 5824 5824 0 0.0
FLASH 5814005 5814005 0 0.0
RAM 618896 618896 0 0.0
tv-casting-app debug unknown 5352 5352 0 0.0
FLASH 11841493 11841493 0 0.0
RAM 773304 773304 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 911424 911424 0 0.0
RAM 152872 152872 0 0.0
nxp contact mcxw71+release FLASH 632424 632424 0 0.0
RAM 64124 64124 0 0.0
lock mcxw71+release FLASH 742208 742208 0 0.0
RAM 65200 65200 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1661092 1661092 0 0.0
RAM 211192 211192 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1582412 1582412 0 0.0
RAM 208456 208456 0 0.0
light cy8ckit_062s2_43012 FLASH 1453356 1453356 0 0.0
RAM 197184 197184 0 0.0
lock cy8ckit_062s2_43012 FLASH 1485684 1485684 0 0.0
RAM 224896 224896 0 0.0
qpg lighting-app qpg6200+debug FLASH 820952 820952 0 0.0
RAM 127644 127644 0 0.0
lock-app qpg6200+debug FLASH 758284 758284 0 0.0
RAM 118604 118604 0 0.0
stm32 light STM32WB5MM-DK FLASH 467628 467628 0 0.0
RAM 141376 141376 0 0.0
telink bridge-app tl7218x FLASH 709606 709606 0 0.0
RAM 93452 93452 0 0.0
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 798518 798518 0 0.0
RAM 44012 44012 0 0.0
light-app-ota-shell-factory-data tl7218x FLASH 789732 789732 0 0.0
RAM 100756 100756 0 0.0
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 715888 715888 0 0.0
RAM 54236 54236 0 0.0
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 749244 749244 0 0.0
RAM 77384 77384 0 0.0
light-switch-app-ota-factory-data tl3218x_retention FLASH 726034 726034 0 0.0
RAM 36984 36984 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 606024 606024 0 0.0
RAM 112564 112564 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 822452 822456 4 0.0
RAM 99152 99152 0 0.0
tizen all-clusters-app arm unknown 5136 5136 0 0.0
FLASH 1772860 1772860 0 0.0
RAM 92704 92704 0 0.0
chip-tool-ubsan arm unknown 20772 20772 0 0.0
FLASH 21108954 21108954 0 0.0
RAM 9183200 9183200 0 0.0

Copy link

codecov bot commented Aug 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (master@97920ba). Learn more about missing BASE report.
⚠️ Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##             master   #40625   +/-   ##
=========================================
  Coverage          ?   50.70%           
=========================================
  Files             ?     1355           
  Lines             ?    99288           
  Branches          ?    12879           
=========================================
  Hits              ?    50346           
  Misses            ?    48942           
  Partials          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lboue lboue marked this pull request as ready for review August 18, 2025 10:44
@lboue lboue requested a review from a team as a code owner August 18, 2025 10:44
@mergify mergify bot merged commit a67066c into project-chip:master Aug 18, 2025
75 of 82 checks passed
dsavitsky-dsr pushed a commit to dsavitsky-dsr/connectedhomeip that referenced this pull request Aug 19, 2025
…hip#40625)

* Remove white space

* Fix anchor link's

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Update README.md

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@lboue lboue deleted the patch-29 branch September 2, 2025 06:49
jamesharrow added a commit that referenced this pull request Sep 10, 2025
* Sixed some build errors under gcc/Linux

* Revert accidentally changed line

* Improvemets of the timeshift test feature in server sources

* Improvemets of the timeshift test feature in example sources

* Removed floor

* changed default tariff sample file

* Restyled

* Added include file for size_t

* Restyled

* Update src/app/clusters/commodity-tariff-server/commodity-tariff-server.cpp

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Update src/app/clusters/commodity-tariff-server/commodity-tariff-server.cpp

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Update src/app/clusters/commodity-tariff-server/CommodityTariffAttrsDataMgmt.cpp

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Update src/app/clusters/commodity-tariff-server/commodity-tariff-server.cpp

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Update src/app/clusters/commodity-tariff-server/commodity-tariff-server.cpp

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Restyled by clang-format

* Restyled fixes

* Fixes by Gemini's CR notes

* Restyle fix

* Fixes by Gemini's CR motes

* Added thr call - clearEndpointInEventTrigger

* Renamed optional structs comparison helpers

* Restyled fix

* Restyled

* Some fixes by failed CI checks

* Applied some fixes by CR requests

* Fixes by CR requests

* Applied code style fix

* The Json samples has been moved into C-header as string constans

* Applied code style fix

* Update CommodityTariffAttrsDataMgmt.cpp

Removed commented line

* Removed static_assert

* Fix for #40085 & #40104

* Fix for #40098,#40100,#40103

* Fix for #40112

* Fix for #40089

* Fix for #40110 (Updated description)

* Fix for #40117

* Removed some Json related sources. Added new data samples as C++ structs

* server srcs. Update of DataMgmt API

* example app srcs. Update of DataMgmt API

* Fixes/Iproves for AttrDataMgmt (Change reporting behavior)

* Fixes and improvements for time depends attrs update logic

* Fixes and improvements in example app for time depends attrs updating

* Example app. CR notes fix

* Server implementation. CR notes fix

* Tariff data samples upd:  C++ Array Conversion with Designated Initializers

* Improvements and fixes for server sources

* Improvements and fixes for example app

* Fixed build issues for linux

* server srcs. Small code improvements

* Server srcs. Fixes/Improvements for data mgmt template

* Fix for: #40120, #40121, #40122 - used AttrId type, removed some redundant args In Attrs update flow methods
Fix for: #40087 - fixed IsStruct trait
Fix for: #40109, #40113, #40114, #40116, #40118, #40123 - Fixed issues with CTC_BaseDataClass removed some redundant API calls
Fix for: #40124,#40125,#40126   - the values comparison performs only with to operators == / !=

* Fix for: #40091,#40105,#40111- the types has renamed

* Server srcs. Fix for: #40111 - types has renaming

* Fixes for Gemini's CR notes

* Update examples/energy-gateway-app/commodity-tariff/include/CommodityTariffSamples.h

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Server srcs. code style fix

* Example srcs. code style fix

* Fixes for Gemini's CR notes. upd

* Fixes to support some declared thread-safe features: #40107,#40108, Fix by comment from #40085

* Server srcs. code style fix

* Server srcs. Upd by CR nootes

* example srcs. The issue ##40128 probably fixed here

* Example app. Restyled

* Sync with upstream. Conflict fixes

* Fixed the field type in tariff samples

* Server srcs. Fixed linux build issue

* small style fix

* Server srcs. Restyled

* Server srcs. Some changes related with fix for the isse #39961

* Example app srcs. Some changes related with fix for the isse #39961

* Server srcs. Fixed errs at building for ESP32

* Added CTCs sources paths into ESP32 project cmake

* Srv srcs. Code fixes and improvements

* The map and unordered_set types has been allowed for CTC in linter checks

* Enable Energy-gateway and Energy Management apps run ESP32 CI (#40327)

* Made Energy-gateway and Energy Management apps run ESP32 CI

* Update .github/workflows/examples-esp32.yaml

Co-authored-by: Copilot <[email protected]>

* Updated examples-esp32.yaml so it only runs the build if there have been changes in particular folders.

* Test commit to check if code changes trigger build of EGA / EMA. Will revert this commit later.

* Restyled by clang-format

* Revert "Test commit to check if code changes trigger build of EGA / EMA. Will revert this commit later."

This reverts commit 797e2d8.

---------

Co-authored-by: Copilot <[email protected]>
Co-authored-by: Restyled.io <[email protected]>

* [OpenSSL] Removing deprecated functions + Adding missing nullptr check (#40590)

* changing deprecated functions to new functions

* Adding nullptr check and stop using strlen

* integrate gemini comments

* cast int to size_t since triggering macOs build error

* Automating TC-LWM-2.1 (step 7) and updating pics (#39972)

* Automating step 7 and updating pics

* Restyle

* Restyle

* Move defaults vars to its own file. (#39696)

* Moved _DEFAULTS_ to single file

* Update file name

* Trying new import type

* Fix lint

* Removed _ prefix from DEFAULT variables

* Updated name from matter_global_defaults to matter_testing_defaults

* isort fix

* Update matter_test_config to use variables from matter_testing_defaults

* Restyled by isort

* Restyled by isort

* Conflict typo

* Fix from CI jo

* Restyled by gn

* Restyled by isort

* Fix import path

* Restyled by gn

* Restyled by isort

* Update file name to match new path matter/testing instead of chip

* Restyled by gn

---------

Co-authored-by: Restyled.io <[email protected]>

* esp32: remove unused Wi-Fi AP settings (#39734)

* Enable HardPrivacy mode in the CameraDevice to enable optional attribute HardPrivacyModeOn. (#40598)

This is to allow a successful wildcard read of all attributes on the AVSM cluster.

* Increase unit test code coverage of `credentials/attestation_verifier/` by 4.3% (#40540)

* Add tests for PartialDACVerifier

- Added tests to check PartialDACVerifier with invalid parameters (empty attestation info) and with.
- Added tests to check PartialDACVerifier with an overly large attestationElements buffer.
- Updated build.gn to include the new test file in the build.

* Refactor callback function formatting and add comments

* Add tests for the DacOnlyPartialAttestationVerifier

- TestWithValidAttestation: Tests verifier with valid certificate assets
- TestWithVIDPIDMismatch: Tests handling of mismatched Vendor/Product IDs
- TestWithNonceMismatch: Tests nonce validation scenarios
- TestWithValidDACButInvalidPAI: Tests invalid PAI certificate handling
- TestWithMismatchedVendorIDs: Tests DAC/PAI vendor ID mismatch detection
- TestPassingVIDPIDChecks: Tests certificates that pass VID/PID validation
- TestWithMatchingPAIAndDACProductIDs: Tests matching product ID scenarios
- TestWithMismatchedPAIAndDACProductIDs: Tests product ID mismatch detection
- TestWithInvalidAttestationSignatureFormat: Tests oversized signature handling

* Add comments for readability

- Added comments for improve code readbility

- Removed a useless test case

- Refactored some part of the code

* Refactor TestDacOnlyPartialAttestationVerifier to reduce boilerplate

- Moved common objects (PartialDACVerifier, attestationResult, attestationCallback) into the test fixture as member variables.
- Updated all test cases to use these members directly.
- This makes the tests cleaner, easier to maintain, and follows the style guide's advice to avoid repetition.

* Cleanup and fix unit tests

- Deleted all useless and incorrect tests that did not exercise the intended code paths.
- Added missing tests to cover important error conditions and certificate validation scenarios.
- Replaced hardcoded vendor/product IDs with descriptive constants for clarity.
- Improved naming of alternate vendor/product ID constants for mismatch scenarios.
- Changed some comments

* Migrate Group Key Management Cluster to be Code Driven (#40504)

* Initial seperation of cluster

* Update config

* Codegen

* Complete initial cluster impl, update build files

* Add codegen integration

* Fix build issues

* Use codegen mandatory attributes

* Use anon namespace, remove old cluster code

* Add unit tests

* Restyled by whitespace

* Restyled by clang-format

* Restyled by gn

* Remove old header includes

* Remove unused variable

* Update BUILD.gn for test

* Update config and CodegenIntegration

* Codegen

* Remove unneeded chip::app references

* Restyled by clang-format

* Codegen

* Add NotifyAttributeChangedIfSuccess on WriteAttribute

* Fix CodegenIntegration callback

* Update src/app/clusters/group-key-mgmt-server/group-key-mgmt-cluster.cpp

Co-authored-by: Andrei Litvin <[email protected]>

* Address review comments

* Restyled by whitespace

* Restyled by clang-format

---------

Co-authored-by: Restyled.io <[email protected]>
Co-authored-by: Andrei Litvin <[email protected]>

* [Test Update] ACL_2_8 test module changes for testing ACL override List method (#40238)

* Rebasing changes from master into TC_ACL_2_8_Update and squashing commits

Adding support for flag forceLegacyListEncoding, useful when writing Attributes with Legacy Write Request

Combining prior commits into one im order to merge latest changes

WIP: Example of forcing old Write Encoding

fixing typehint

Update TC_ACL_2_3.py

- Added force_legacy_encoding parameter to TC_ACL_2_3 test

- Added support for controlling the forceLegacyListEncoding parameter in the TC_ACL_2_3 test through the existing --bool-arg CLI infrastructure. The parameter defaults to True if not specified and can be set via: --bool-arg force_legacy_encoding:false

- This allows testing both legacy and non-legacy list encoding behaviors through the test runner.

Update TC_ACL_2_3.py

Changed expected result for test step 18, as the result should be D_OK_EMPTY if forced legacy encoding, otherwise it should be D_OK_FULL if using the new encoding

restyle

Updated TC_ACL_2_3 test module:
- Changing to establishing a new local function to contain test code
- Running the new local function from the main test function, changing the bool value for the force_legacy_encoding var between iterations

Restyled by autopep8

clang-tidy fixes: use make_unique to create unique_ptrs

making forceLegacyListEncoding default to False

Updating TC_ACL_2_8 python3 test module:
- Added legacy mode rerun loop to verify that the test will work for both the new and legacy list write methods.
- Added test step 11 to show that the test will be rerun after the new list method has completed.
- Added resetting the fabrics inbetween the loops of running the new and legacy write list test runs.
- This is for easier review of modified ACL_2_6 test module for override PR here: [38693](#38693)
- Test Plan PR Link: *To be added*

Restoring minor changes noticed during rebase

* Update TC_ACL_2_3.py

* Update TC_ACL_2_3.py

* Stylizer fixes applied

* Resolving linting error

* Combining teardown th logic between tests into an async function as suggested by Gemini AI

* Refactor test steps 9 and 10 in TC_ACL_2_8 to remove code duplication and improve maintainability:

- Unified event extraction and verification logic for both legacy and new encoding modes
- Always verify the initial 'added' event outside the encoding-specific logic
- Consolidated fabricIndex checks into a single loop for all relevant events
- Improved readability and maintainability by reducing duplicated code in steps 9 (TH1) and 10 (TH2)

* Re-adding test step 11

* Restyled by autopep8

* Updating verbiage for expected results for test steps 9 and 10

---------

Co-authored-by: Alami-Amine <[email protected]>
Co-authored-by: Restyled.io <[email protected]>

* [Test Update] Updating TC_ACL_2_6 test module to include validation for legacy override list write method (#40267)

* Updating TC_ACL_2_6 test module to include validation for legacy override list write method:

- Update ACL_2_6 python3 test module to add override for list write methods
- Updated test steps to match override for legacy and new write lists methods
- Created test loop to run test with override then without override
- Updated test step 5 to validate override works as expected for this test
- Test Plan PR Link: 5183 (Already Merged)

* autopep8 and isort fixes implemented

* Apply suggestions from code review by Gemini

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Updating test step 5 to remove redundant check no longer needed

* Refactor: add _validate_event_fields helper for TC_ACL_2_6 test step 5 event validation

* Apply suggestions from code review from Amine

Updating test to rerun with legacy write list encoding mechanism, instead of with the new write list encoding mechanism

Co-authored-by: Amine Alami <[email protected]>

* Resetting ACL events to only admin/case before re-running test with legacy list encoding mechanism

* Swapping if statement order in test step 8

* Restyled by autopep8

* Added comment in code for urgency delivery flag for read event and set a new var to hold the magic value

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Amine Alami <[email protected]>
Co-authored-by: Restyled.io <[email protected]>

* Adding WiFi Validation (#39573)

* Adding WiFi Validation

* Update PICS from CNET.S to CNET.S.F00 and remove internal check

* Centralize codegen integration (#40553)

* Start some prototypes

* More integration

* More work

* Restyle

* Update attributes sets a bit to help for more generic code

* Comment update

* General diangostics integration: this seems to cost too much right now

* Start seeing some savings afte wifi cluste migration. We are now at 212 bytes of overhead on efr32 and with much better logging

* Another update, we are at 124 bytes of overhead

* Code size diff is now 100% a wash

* All attributes logic...

* Slight API cleanup

* Add some unit tests

* Slightly shorter code

* Restyled by clang-format

* Use maxendpointcount be 1

* Fix conditional

* Fix typo

* Fix copy and paste

* Update data type

* Fix typo

* Remove %u check ... althouhg this is silly...

* Add file names to gni file

* Fix ota provider

* Also convert basic information

* slight arrange

* Undo submodule update

* Add one more ember override in dynamic dispatcher

* Restyled by clang-format

* Fix ifdef not being defined

* Fix typo

* Fix typo

* Update src/app/server-cluster/tests/TestOptionalAttributeSet.cpp

Co-authored-by: Copilot <[email protected]>

* Slight clarity update

* Ameba does not like typeof

* Also convert the pushav stream transport server

* fix compiles

* fix compiles

* Logic fix in pushav stream server

* Slight test adjustment: better comments and looks like a better test

* Update src/data-model-providers/codegen/ClusterIntegration.h

Co-authored-by: Sergio Soares <[email protected]>

* Update src/data-model-providers/codegen/ClusterIntegration.cpp

Co-authored-by: Sergio Soares <[email protected]>

* Update comments

* Restyled by clang-format

* Update some comments to have better capitalization

* More comment updates

* Some review feedback: updated variable name, added more comment on destroy interface

* More renames based on review feedback

* A few comment updates

* place logging on a configuration flag

* Convert group key management cluster as well

* make feature map return a value

* Restyled by clang-format

* Restyled by gn

* Fix comment

---------

Co-authored-by: Andrei Litvin <[email protected]>
Co-authored-by: Restyled.io <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Sergio Soares <[email protected]>

* Update Video/Snapshot streams to adjust range parameters when reusing streams during allocations (#40572)

* Adjust IsCompatible for Video and Snapshot streams.

* Update the Video and Snapshot streams to adjust the range parameters
when an already allocated stream is being re-used.

-Minor update to bitRates in scripts and device for AudioStream
 allocation.

* Add test script to validate a narrower range setting of the
SnapshotStream min/max resolution during Stream allocation reuse.

* Rename variables

* Fix BUILD.gn detecting host platform as linux-x86_64 on macOS (#40613)

* [Camera] Refactor the AllocateVideoStream method to config camera parameters (#40606)

* Refactor the AllocateVideoStream method to accept optional parameters for minimum width, height, frame rate, and bit rate.

* Address review comments

* Address review comments

* Address review lef comment

* Implementation of PushAVTransport and PushAVStreamTransportDelegate (#38331)

* Implement PushAVTransport and PushAVStreamTransportDelegate.

Co-Author: Tushant Yadav <[email protected]>
Co-Author: Chayan Ailawalia <[email protected]>

Signed-off-by: Raveendra Karu <[email protected]>

* Restyled by clang-format

* Restyled by gn

* addressed build issue

Co-Author: Tushant Yadav <[email protected]>

* Implemented delegate API

Co-Author: Tushant Yadav <[email protected]>

* restyled and commented cluster dependent code

Co-Author: Tushant Yadav <[email protected]>

* Restyled by clang-format

* Restyled by gn

* code cleanup

Co-Author: Tushant Yadav <[email protected]>

* Implement PushAVTransport integration and code cleanup

- Add PushAVTransport cluster support to camera-app
- Remove TODO comments as dependencies are now resolved
- Clean up BUILD.gn files and remove outdated comments

Author: Tushant Yadav <[email protected]>

* Updated namespace

Author: Tushant Yadav <[email protected]>

* Rebase to latest code.

Signed-off-by: Raveendra Karu <[email protected]>

* Restyled by clang-format

* Restyled by gn

* Address LINT errors.

Signed-off-by: Raveendra Karu <[email protected]>

* Fix compile erros to unblock CI

* Fix compile error

---------

Signed-off-by: Raveendra Karu <[email protected]>
Co-authored-by: Restyled.io <[email protected]>
Co-authored-by: Yufeng Wang <[email protected]>

* ESP32: Add APIs to get random values from secure cert partition (#40563)

* ESP32: Add APIs to get random values from secure cert partition

* address review from gemini

* add some comments and fix names

* ESP32: remove redundant c++17 flag setting from example's main component (#40586)

All examples already set the C++ standard in the project-level
CMakeLists.txt. The main component redundantly sets it again.
As per the ESP-IDF C++ support guide, a component should only
override the C++ version if it intends to use a different one.
We want to keep a consistent version across the project, so
the redundant setting is removed.

* [Realtek] Support ci test (#40561)

* [Realtek] Support ci test

* [Realtek] add subset ci build

* [Realtek] Add bloat report

* [Realtek] Fix build error

* [Realtek] Fix build error

* [Realtek] Add upload reports

* [Tizen] Disable CI size report since it is not necessary (#40627)

* Fix Matter Refrigerator and Temperature Controlled Example (#40625)

* Remove white space

* Fix anchor link's

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Update README.md

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* [TC_EEVSE_2.7] - Fix test script - Fails if run after another test without rebooting DUT (#40498)

* Added step 4 (shuffling step numbering) - which sends Disable to EVSE to ensure it is in known state at beginning of test.

* Update src/python_testing/TC_EEVSE_2_7.py

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Update src/python_testing/TC_EEVSE_2_7.py

Co-authored-by: Copilot <[email protected]>

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Hasty Granbery <[email protected]>

* Additional AGP 8.5.1+ NDK r28 changes (#40462)

* [Linux] Disable CI size report since it is not necessary (#40633)

* [Create Test] Create ACL 2 9 python3 test module (#39792)

* [Create test] Create python3 test module for TC_ACL_2_9
- Create python3 test module for TC_ACL_2_9 for matter-test-scripts task #[620](project-chip/matter-test-scripts#620)
- Test steps 1-11 fully implemented and functional
- Currently WIP as we need to find a way to cleanup after test steps are run as this test leaves the TH with manage access only and not admin access once this test completes

* Added TODO for resetting ACL back to admin rights at end of test steps

* Apply suggestions from code review from Gemini-AI

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>

* Updating TC_ACL_2_9 python3 test module:
- Resolving issue noticed with latest changes suggested by Gemini-AI bot
- isort and autopep8 run to resolve sytle issues noticed

* Resolving linting errors

* Restyled by autopep8

* Updating TC_ACL_2_9 python3 test module:
- Changed to establishing TH2 and ran TH2 through the test steps in place of TH1
- Had TH1 remove TH2 fabric index at the end of the test as a final clean up step

* Resolving style issues with autopep8 and isort

* Removed Test_TC_ACL_2_9 yaml module and references in test runner docs

* Update TC_ACL_2_9.py

updating chip namespace imports to matter

* Restyled by isort

* Update src/python_testing/TC_ACL_2_9.py

Co-authored-by: C Freeman <[email protected]>

---------

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Restyled.io <[email protected]>
Co-authored-by: C Freeman <[email protected]>

* Fix crash if JSON Revocation Set is malformed (#40630)

* Fix Crash if JSON Revocation Set is malformed

* Adding a testcase that covers the failure

* integrate AI

* Integrating Comment

* Removing timeout ceiling from GetConnectedDevice (#40632)

* [Camera] Revert Create Video Pipeline change (#40619)

* Revert Create Video Pipeline change

* Update examples/camera-app/linux/src/camera-device.cpp

Co-authored-by: Copilot <[email protected]>

* Address gemini comments

---------

Co-authored-by: Copilot <[email protected]>

* Integrate PushAvStreamTransport into camera app (#40573)

* Fix StreamUsage constraint checks for Audio and Video stream allocation (#40617)

* Fix StreamUsage constraint checks for Audio and Video stream allocation

* Adjust test scripts for the new constraints around StreamUsage enum.

* Return DynamicConstraintError if the StreamUSage for the de-allocated
streamID is Internal.

* [Android][Docker] Upgrade Android API level 30 to 34 (#40615)

Fix SDK Platform 34 download link

* [Camera-Controller] Add instructions for uploading video clip via Push AV Transport (#40624)

* Add instructions for uploading video clip via Push AV Transport

* Update examples/camera-controller/README.md

Co-authored-by: Copilot <[email protected]>

* Update examples/camera-controller/README.md

Co-authored-by: Copilot <[email protected]>

* Update examples/camera-controller/README.md

Co-authored-by: Pradip De <[email protected]>

* Update examples/camera-controller/README.md

Co-authored-by: Pradip De <[email protected]>

* Address review comments

---------

Co-authored-by: Copilot <[email protected]>
Co-authored-by: Pradip De <[email protected]>

* Add enum handling in AttributePersistence. (#40568)

* Add enum check and unit tests

* Change AttributePersistence UT

* Restyled by whitespace

* Restyled by clang-format

* Make explicit change in handling for enums

* Add missing file to BUILD.gn

* Add explicit initialization to avoid static analysis error

* Remove TestEnum logic

* Change macros for tests

* Separate template for enums

* Fix header order and add additional Assert for enums

---------

Co-authored-by: Restyled.io <[email protected]>

* [Closures] Add secure state field validation check. (#40276)

* add secure state feild validation

* Add test cases

* Restyled by whitespace

* Restyled by clang-format

---------

Co-authored-by: Restyled.io <[email protected]>

* [Chef] [Minor fix] [Roomairconditioner] Fix few ZAP initialisation values for setpoint ranges (#40597)

* String type has been allowed for CTC in linter checks

* Example app. Restyled

* Server srcs. Restyled

* Updated AtrrMgmt template

* Improve by CR request

* Server srcs. Restyled

* Just to keep changes

* Added new tests path

* Added actual test cases.

* Added few test cases

* Upd by Gemeni CR notes

* Fixed a Linux build issue

* Code style fix

* Fixed some build erros in Linux/gcc

* Another one fix for CI passing

* Code style fix

* Removed unused namespace

* To save current changes

* Fixes to passing some CI checks

* Ussed fet test casses in UT set

* Bixes build issue in linux env

* Applied restyler fix

* Few minoe fixes by Gemini CR

* Added blockMode fieald in ctx

* Just to same progress

* Updated some lists len constraints

* Added new UT case

* Code style upd

* Reverted an unwanted edit

* Just to save last changes

* Just to save last changes in example

* Add docs explaining problems in ScanNetworks handling during commissioning. (#40761)

* [NXP] Enable Zigbee (#40513)

Signed-off-by: Mihnea Pascu <[email protected]>

* [ESP32] Fix the BLE advertisement data parsing for BLE scanner (#40733)

* ESP32: Fix the BLE advertisement data parsing for BLE scanner

* Restyled by clang-format

* AI review changes

---------

Co-authored-by: Restyled.io <[email protected]>

* \ No newline at end of file

* \ No newline at end of file

* Changed the way to finding of values for  Current/Next DayEntryDate attrs

* Updated the tariff data sample for NoBlock case

* Small improvements in definition of attr validators helpers

* Example app. Updates in attr validation context

* Upd validator for Tariff Period values

* Just to save last changes

* Update the GetTariffComponet response

* Small updates in validation

* Fix to avoid build issues in Linux

* Server implementation. Restyled

* Example app. Restyled

* Fixed comment

* Added another variant for ListToMap template

* Small fixes by Gemini's CR notes

* Fixed log message

* Fixed msg format

* Restyler update

* Server implementation. Removig if X-pattern macro

* Just to save last changes

* Fixed few critical issues

* Update examples/energy-gateway-app/commodity-tariff/src/CommodityTariffEventTriggers.cpp

Co-authored-by: Hasty Granbery <[email protected]>

* Server sources. Fixes and improvements by last CR

* Server sources. Fixed log messages to AppServer

* Server sources. Fixed log messages to AppServer

* Reverted path's changhing

* Samll code improvements

* Upd the xml

* Restyled

* Removed X-pattern macro

* Fixed log message format

* Code style fix

* Code style fix

* Removed asserts and fixed some comments

* Fixed some build issues in ESP32 build env

* Restyled by whitespace

* Fixed XMLs

* Update examples/energy-gateway-app/commodity-tariff/include/CommodityTariffSamples.h

Co-authored-by: jamesharrow <[email protected]>

* Removed unnecessary lines

* ESP32 build fix

* Upd log messages type

* Small arg name fix

* Restyled by clang-format

* Patch some compile errors in commodity-tariff-server

* unwrapped the X-pattern macro

* Template dummies mark as not implemented

* Fixed naming in function args

* Added ret code for the current attr updating methods

* Upd ret value for SpanCopiers<>

* Removed unused func declaration

* big function from a .h file moved to cpp

* Jost to store last changhes

* Added common GetMgmtObj method to access for all Atts mgmt objs by enum key

* Restyler fix

* Fixed rotating day checks

* Upd xml's for MereId and CMC

* Upd xml's for CTC

---------

Signed-off-by: Raveendra Karu <[email protected]>
Signed-off-by: Mihnea Pascu <[email protected]>
Co-authored-by: Hasty Granbery <[email protected]>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: Restyled.io <[email protected]>
Co-authored-by: Hasty Granbery <[email protected]>
Co-authored-by: jamesharrow <[email protected]>
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Amine Alami <[email protected]>
Co-authored-by: Ramiro Recchia <[email protected]>
Co-authored-by: jtrejoespinoza-grid <[email protected]>
Co-authored-by: Dejin <[email protected]>
Co-authored-by: Pradip De <[email protected]>
Co-authored-by: Lyudmila Kostanyan <[email protected]>
Co-authored-by: Zaid Omer <[email protected]>
Co-authored-by: Andrei Litvin <[email protected]>
Co-authored-by: Jake Ororke <[email protected]>
Co-authored-by: Alami-Amine <[email protected]>
Co-authored-by: Andrei Litvin <[email protected]>
Co-authored-by: Sergio Soares <[email protected]>
Co-authored-by: Philip Gregor <[email protected]>
Co-authored-by: Yufeng Wang <[email protected]>
Co-authored-by: [Samsung] Raveendra Karu <[email protected]>
Co-authored-by: Shubham Patil <[email protected]>
Co-authored-by: Realtek-pankore <[email protected]>
Co-authored-by: Arkadiusz Bokowy <[email protected]>
Co-authored-by: Ludovic BOUÉ <[email protected]>
Co-authored-by: C Freeman <[email protected]>
Co-authored-by: Pradip De <[email protected]>
Co-authored-by: Moises Terrones <[email protected]>
Co-authored-by: sabollim-silabs <[email protected]>
Co-authored-by: Shreyas Balakrishna Bhandare <[email protected]>
Co-authored-by: Boris Zbarsky <[email protected]>
Co-authored-by: MihneaP-nxp <[email protected]>
Co-authored-by: Wang Qixiang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants