[v1.4] ESP32: Add APIs to get random values from secure cert partition (#40563) #40621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ect-chip#40563) * ESP32: Add APIs to get random values from secure cert partition * address review from gemini * add some comments and fix names
There was a problem hiding this comment.
Code Review
This pull request adds APIs to retrieve two 32-byte fixed random values from the secure certificate partition on ESP32 devices. The changes introduce new MatterTLVSubType enum values for these random values and add GetFixedRandom1 and GetFixedRandom2 static methods to ESP32SecureCertDataProvider. The implementation is straightforward and consistent with the existing code style in the file. The changes look good and have been implemented correctly.
wqx6
approved these changes
Aug 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ESP32: Add APIs to get random values from secure cert partition
address review from gemini
add some comments and fix names
Summary
Back porting #40563 to v1.4-branch
Related issues
Testing
Flashed a partition which contains the random values and verified that the same random values are being read using the newly introduced APIs.