Skip to content

Conversation

wqx6
Copy link
Contributor

@wqx6 wqx6 commented Aug 15, 2025

Summary

  1. Move binding table out from src/app/utils/
  2. Move the unit test to the cluster directory
  3. Migrate binding cluster to be code driven and add some unit test

Related issues

Part of #36538

Testing

  • Unit test exists
  • CI is expected to pass

@Copilot Copilot AI review requested due to automatic review settings August 15, 2025 11:12
@wqx6 wqx6 requested review from a team and s07641069 as code owners August 15, 2025 11:12
@wqx6 wqx6 marked this pull request as draft August 15, 2025 11:12
@mergify mergify bot added the conflict label Aug 15, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the binding cluster from using generated code patterns to a code-driven implementation, centralizing all binding-related functionality under the cluster directory.

  • Migrates binding cluster to use the new code-driven architecture with a dedicated BindingCluster class
  • Moves and renames EmberBindingTableEntry to BindingTableEntry in the cluster directory
  • Relocates unit tests from the app/tests directory to the cluster-specific test directory

Reviewed Changes

Copilot reviewed 80 out of 81 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
src/lib/core/CHIPConfig.h Adds configuration for maximum binding entries per fabric
src/app/clusters/binding-server/binding-cluster.h New cluster implementation with attribute handling methods
src/app/clusters/binding-server/binding-cluster.cpp Implementation of the code-driven binding cluster with read/write handling
src/app/clusters/binding-server/binding-table.h Moved and renamed binding table structures and class
src/app/clusters/binding-server/binding-table.cpp Moved binding table implementation with namespace updates
src/app/clusters/binding-server/CodegenIntegration.cpp New integration file for registering code-driven cluster
src/app/util/types_stub.h Removes old binding type definitions
zzz_generated/app-common/app-common/zap-generated/attributes/Accessors.h Removes generated attribute accessors for binding
Comments suppressed due to low confidence (1)

src/app/clusters/binding-server/CodegenIntegration.cpp:79

  • Error message incorrectly mentions 'OTA' instead of 'Binding' when logging unregistration failure
        ChipLogError(AppServer, "Failed to unregister OTA on endpoint %u: %" CHIP_ERROR_FORMAT, endpointId, err.Format());

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request is a significant and well-executed refactoring to migrate the Binding cluster to be a code-driven implementation. The changes are extensive, involving moving the binding table implementation, renaming EmberBindingTableEntry to BindingTableEntry, and updating numerous files to use the new structure. The new implementation is more modular and robust. I've found one issue in the new binding cluster implementation that could cause valid write operations to fail.

@wqx6 wqx6 force-pushed the binding/code_driven branch from d2c1645 to 3516539 Compare September 10, 2025 09:02
@github-actions
Copy link

github-actions bot commented Sep 10, 2025

PR #40607: Size comparison from b58b999 to 3516539

Increases above 0.2%:

platform target config section b58b999e 3516539 change % change
cc13x4_26x4 pump-app LP_EM_CC1354P10_6 RAM 96932 97220 288 0.3
pump-controller-app LP_EM_CC1354P10_6 RAM 97140 97436 296 0.3
esp32 all-clusters-app c3devkit DRAM 102552 102880 328 0.3
psoc6 all-clusters cy8ckit_062s2_43012 RAM 211288 212932 1644 0.8
all-clusters-minimal cy8ckit_062s2_43012 RAM 208560 210204 1644 0.8
telink light-switch-app-ota-compress-lzma-factory-data tl7218x_retention RAM 54256 54584 328 0.6
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a RAM 77404 77732 328 0.4
light-switch-app-ota-factory-data tl3218x_retention RAM 37004 37332 328 0.9
Full report (35 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nxp, psoc6, qpg, realtek, stm32, telink)
platform target config section b58b999e 3516539 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1104520 1104520 0 0.0
RAM 178970 178706 -264 -0.1
bl702 lighting-app bl702+eth FLASH 659090 658896 -194 -0.0
RAM 135025 134769 -256 -0.2
bl702+wifi FLASH 835158 835220 62 0.0
RAM 124509 124237 -272 -0.2
bl706+mfd+rpc+littlefs FLASH 1068168 1068230 62 0.0
RAM 117333 117077 -256 -0.2
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 898408 898464 56 0.0
RAM 105676 105420 -256 -0.2
lighting-app bl702l+mfd+littlefs FLASH 981320 980870 -450 -0.0
RAM 109828 109572 -256 -0.2
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 768172 768120 -52 -0.0
RAM 103392 103128 -264 -0.3
lock-ftd LP_EM_CC1354P10_6 FLASH 779800 779748 -52 -0.0
RAM 108560 108288 -272 -0.3
pump-app LP_EM_CC1354P10_6 FLASH 725396 726164 768 0.1
RAM 96932 97220 288 0.3
pump-controller-app LP_EM_CC1354P10_6 FLASH 709888 710640 752 0.1
RAM 97140 97436 296 0.3
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 553162 553094 -68 -0.0
RAM 205168 204904 -264 -0.1
lock CC3235SF_LAUNCHXL FLASH 585854 585786 -68 -0.0
RAM 205400 205136 -264 -0.1
efr32 lock-app BRD4187C FLASH 959752 959720 -32 -0.0
RAM 126408 126148 -260 -0.2
BRD4338a FLASH 755176 755072 -104 -0.0
RAM 255732 255464 -268 -0.1
window-app BRD4187C FLASH 1053988 1053892 -96 -0.0
RAM 122604 122344 -260 -0.2
esp32 all-clusters-app c3devkit DRAM 102552 102880 328 0.3
FLASH 1774904 1775712 808 0.0
IRAM 83862 83862 0 0.0
nxp contact mcxw71+release FLASH 633096 633040 -56 -0.0
RAM 64148 63884 -264 -0.4
lock mcxw71+release FLASH 742168 742112 -56 -0.0
RAM 65200 64936 -264 -0.4
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1664660 1665460 800 0.0
RAM 211288 212932 1644 0.8
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1584644 1585468 824 0.1
RAM 208560 210204 1644 0.8
light cy8ckit_062s2_43012 FLASH 1455108 1454996 -112 -0.0
RAM 197248 196984 -264 -0.1
lock cy8ckit_062s2_43012 FLASH 1487436 1487324 -112 -0.0
RAM 224968 224704 -264 -0.1
qpg lighting-app qpg6200+debug FLASH 831400 831336 -64 -0.0
RAM 127788 127512 -276 -0.2
lock-app qpg6200+debug FLASH 768452 768388 -64 -0.0
RAM 118748 118480 -268 -0.2
realtek light-switch-app rtl8777g FLASH 703608 704376 768 0.1
RAM 106660 106692 32 0.0
lighting-app rtl8777g FLASH 755368 755368 0 0.0
RAM 127040 127040 0 0.0
stm32 light STM32WB5MM-DK FLASH 467876 467820 -56 -0.0
RAM 141400 141128 -272 -0.2
telink bridge-app tl7218x FLASH 709726 709674 -52 -0.0
RAM 93468 93204 -264 -0.3
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 798740 798688 -52 -0.0
RAM 44028 43764 -264 -0.6
light-app-ota-shell-factory-data tl7218x FLASH 789954 789902 -52 -0.0
RAM 100772 100508 -264 -0.3
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 716136 716784 648 0.1
RAM 54256 54584 328 0.6
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 749490 750138 648 0.1
RAM 77404 77732 328 0.4
light-switch-app-ota-factory-data tl3218x_retention FLASH 726282 726930 648 0.1
RAM 37004 37332 328 0.9
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 606350 606298 -52 -0.0
RAM 112580 112316 -264 -0.2
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 822674 822626 -48 -0.0
RAM 99168 98904 -264 -0.3

@github-actions
Copy link

github-actions bot commented Sep 12, 2025

PR #40607: Size comparison from 49cf915 to 6b7be68

Increases above 0.2%:

platform target config section 49cf915 6b7be68 change % change
cc13x4_26x4 pump-app LP_EM_CC1354P10_6 RAM 96932 97220 288 0.3
pump-controller-app LP_EM_CC1354P10_6 RAM 97140 97436 296 0.3
esp32 all-clusters-app c3devkit DRAM 102552 102880 328 0.3
nrfconnect light-switch-app nrf52840dk_nrf52840 RAM 117902 118230 328 0.3
pump-app nrf52840dk_nrf52840 RAM 117114 117416 302 0.3
pump-controller-app nrf52840dk_nrf52840 RAM 116873 117175 302 0.3
psoc6 all-clusters cy8ckit_062s2_43012 RAM 211288 212932 1644 0.8
all-clusters-minimal cy8ckit_062s2_43012 RAM 208560 210204 1644 0.8
telink light-switch-app-ota-compress-lzma-factory-data tl7218x_retention RAM 54256 54584 328 0.6
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a RAM 77404 77732 328 0.4
light-switch-app-ota-factory-data tl3218x_retention RAM 37004 37332 328 0.9
Full report (43 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
platform target config section 49cf915 6b7be68 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1104520 1104520 0 0.0
RAM 178970 178706 -264 -0.1
bl702 lighting-app bl702+eth FLASH 659090 658896 -194 -0.0
RAM 135025 134769 -256 -0.2
bl702+wifi FLASH 835158 835220 62 0.0
RAM 124509 124237 -272 -0.2
bl706+mfd+rpc+littlefs FLASH 1068168 1068230 62 0.0
RAM 117333 117077 -256 -0.2
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 898408 898464 56 0.0
RAM 105676 105420 -256 -0.2
lighting-app bl702l+mfd+littlefs FLASH 981320 980870 -450 -0.0
RAM 109828 109572 -256 -0.2
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 768172 768120 -52 -0.0
RAM 103392 103128 -264 -0.3
lock-ftd LP_EM_CC1354P10_6 FLASH 779800 779748 -52 -0.0
RAM 108560 108288 -272 -0.3
pump-app LP_EM_CC1354P10_6 FLASH 725396 726004 608 0.1
RAM 96932 97220 288 0.3
pump-controller-app LP_EM_CC1354P10_6 FLASH 709888 710480 592 0.1
RAM 97140 97436 296 0.3
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 553162 553094 -68 -0.0
RAM 205168 204904 -264 -0.1
lock CC3235SF_LAUNCHXL FLASH 585854 585786 -68 -0.0
RAM 205400 205136 -264 -0.1
efr32 lock-app BRD4187C FLASH 959752 959720 -32 -0.0
RAM 126408 126148 -260 -0.2
BRD4338a FLASH 755176 755072 -104 -0.0
RAM 255732 255464 -268 -0.1
window-app BRD4187C FLASH 1053988 1053892 -96 -0.0
RAM 122604 122344 -260 -0.2
esp32 all-clusters-app c3devkit DRAM 102552 102880 328 0.3
FLASH 1775084 1775658 574 0.0
IRAM 83862 83862 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 913964 914568 604 0.1
RAM 152928 153256 328 0.2
nrf5340dk_nrf5340_cpuapp FLASH 677144 677612 468 0.1
RAM 153452 153780 328 0.2
light-switch-app nrf52840dk_nrf52840 FLASH 798356 798956 600 0.1
RAM 117902 118230 328 0.3
lighting-app nrf52840dk_nrf52840+rpc FLASH 857036 856980 -56 -0.0
RAM 133118 132854 -264 -0.2
nrf52840dongle_nrf52840 FLASH 793564 793508 -56 -0.0
RAM 140937 140673 -264 -0.2
lock-app nrf52840dk_nrf52840 FLASH 788752 788696 -56 -0.0
RAM 118447 118183 -264 -0.2
pump-app nrf52840dk_nrf52840 FLASH 766260 766844 584 0.1
RAM 117114 117416 302 0.3
pump-controller-app nrf52840dk_nrf52840 FLASH 751704 752288 584 0.1
RAM 116873 117175 302 0.3
nxp contact mcxw71+release FLASH 633264 633208 -56 -0.0
RAM 64204 63940 -264 -0.4
lock mcxw71+release FLASH 742392 742336 -56 -0.0
RAM 65240 64976 -264 -0.4
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1664660 1665340 680 0.0
RAM 211288 212932 1644 0.8
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1584644 1585348 704 0.0
RAM 208560 210204 1644 0.8
light cy8ckit_062s2_43012 FLASH 1455108 1454996 -112 -0.0
RAM 197248 196984 -264 -0.1
lock cy8ckit_062s2_43012 FLASH 1487436 1487324 -112 -0.0
RAM 224968 224704 -264 -0.1
qpg lighting-app qpg6200+debug FLASH 831400 831336 -64 -0.0
RAM 127788 127512 -276 -0.2
lock-app qpg6200+debug FLASH 768452 768388 -64 -0.0
RAM 118748 118480 -268 -0.2
realtek light-switch-app rtl8777g FLASH 703608 704208 600 0.1
RAM 106660 106692 32 0.0
lighting-app rtl8777g FLASH 755368 755368 0 0.0
RAM 127040 127040 0 0.0
stm32 light STM32WB5MM-DK FLASH 467876 467820 -56 -0.0
RAM 141400 141128 -272 -0.2
telink bridge-app tl7218x FLASH 709726 709674 -52 -0.0
RAM 93468 93204 -264 -0.3
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 798740 798688 -52 -0.0
RAM 44028 43764 -264 -0.6
light-app-ota-shell-factory-data tl7218x FLASH 789954 789902 -52 -0.0
RAM 100772 100508 -264 -0.3
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 716136 716682 546 0.1
RAM 54256 54584 328 0.6
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 749490 750036 546 0.1
RAM 77404 77732 328 0.4
light-switch-app-ota-factory-data tl3218x_retention FLASH 726282 726828 546 0.1
RAM 37004 37332 328 0.9
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 606350 606298 -52 -0.0
RAM 112580 112316 -264 -0.2
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 822674 822626 -48 -0.0
RAM 99168 98904 -264 -0.3

@andy31415 andy31415 added the cluster-decoupling Work for cluster decoupling: remove direct app-specific code dependency and allow unit testing label Sep 17, 2025
@github-actions
Copy link

PR #40607: Size comparison from 2f77e85 to a2f6196

Full report (1 build for stm32)
platform target config section 2f77e85 a2f6196 change % change
stm32 light STM32WB5MM-DK FLASH 467724 467668 -56 -0.0
RAM 141400 141128 -272 -0.2

@github-actions
Copy link

github-actions bot commented Sep 18, 2025

PR #40607: Size comparison from 2f77e85 to f6200c3

Full report (5 builds for cc32xx, realtek, stm32)
platform target config section 2f77e85 f6200c3 change % change
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 552970 552918 -52 -0.0
RAM 205168 204904 -264 -0.1
lock CC3235SF_LAUNCHXL FLASH 585694 585626 -68 -0.0
RAM 205400 205136 -264 -0.1
realtek light-switch-app rtl8777g FLASH 703464 704080 616 0.1
RAM 106660 106692 32 0.0
lighting-app rtl8777g FLASH 755224 755224 0 0.0
RAM 127040 127040 0 0.0
stm32 light STM32WB5MM-DK FLASH 467724 467668 -56 -0.0
RAM 141400 141128 -272 -0.2

@github-actions
Copy link

github-actions bot commented Sep 18, 2025

PR #40607: Size comparison from 2f77e85 to 799f5d0

Increases above 0.2%:

platform target config section 2f77e85 799f5d0 change % change
cc13x4_26x4 pump-app LP_EM_CC1354P10_6 RAM 96932 97220 288 0.3
pump-controller-app LP_EM_CC1354P10_6 RAM 97140 97436 296 0.3
esp32 all-clusters-app c3devkit DRAM 102592 102912 320 0.3
nrfconnect light-switch-app nrf52840dk_nrf52840 RAM 117902 118230 328 0.3
pump-app nrf52840dk_nrf52840 RAM 117114 117416 302 0.3
pump-controller-app nrf52840dk_nrf52840 RAM 116873 117175 302 0.3
psoc6 all-clusters cy8ckit_062s2_43012 RAM 211328 212972 1644 0.8
all-clusters-minimal cy8ckit_062s2_43012 RAM 208592 210236 1644 0.8
telink light-switch-app-ota-compress-lzma-factory-data tl7218x_retention RAM 52228 52556 328 0.6
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a RAM 71276 71604 328 0.5
light-switch-app-ota-factory-data tl3218x_retention RAM 34976 35304 328 0.9
Full report (44 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
platform target config section 2f77e85 799f5d0 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1104392 1104392 0 0.0
RAM 178970 178706 -264 -0.1
bl702 lighting-app bl702+eth FLASH 658958 658764 -194 -0.0
RAM 135025 134769 -256 -0.2
bl702+wifi FLASH 835026 834832 -194 -0.0
RAM 124509 124237 -272 -0.2
bl706+mfd+rpc+littlefs FLASH 1068036 1067842 -194 -0.0
RAM 117333 117077 -256 -0.2
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 898276 898076 -200 -0.0
RAM 105676 105420 -256 -0.2
lighting-app bl702l+mfd+littlefs FLASH 981188 980738 -450 -0.0
RAM 109828 109572 -256 -0.2
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 768028 767976 -52 -0.0
RAM 103392 103128 -264 -0.3
lock-ftd LP_EM_CC1354P10_6 FLASH 779656 779604 -52 -0.0
RAM 108560 108288 -272 -0.3
pump-app LP_EM_CC1354P10_6 FLASH 725236 725836 600 0.1
RAM 96932 97220 288 0.3
pump-controller-app LP_EM_CC1354P10_6 FLASH 709712 710328 616 0.1
RAM 97140 97436 296 0.3
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 552970 552918 -52 -0.0
RAM 205168 204904 -264 -0.1
lock CC3235SF_LAUNCHXL FLASH 585694 585626 -68 -0.0
RAM 205400 205136 -264 -0.1
efr32 lock-app BRD4187C FLASH 959624 959560 -64 -0.0
RAM 126408 126148 -260 -0.2
BRD4338a FLASH 754960 754848 -112 -0.0
RAM 255732 255464 -268 -0.1
window-app BRD4187C FLASH 1053764 1053660 -104 -0.0
RAM 122604 122344 -260 -0.2
esp32 all-clusters-app c3devkit DRAM 102592 102912 320 0.3
FLASH 1775748 1776352 604 0.0
IRAM 83862 83862 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 914684 915308 624 0.1
RAM 152960 153288 328 0.2
nrf5340dk_nrf5340_cpuapp FLASH 677872 678364 492 0.1
RAM 153484 153812 328 0.2
light-switch-app nrf52840dk_nrf52840 FLASH 798208 798824 616 0.1
RAM 117902 118230 328 0.3
lighting-app nrf52840dk_nrf52840+rpc FLASH 856888 856832 -56 -0.0
RAM 133118 132854 -264 -0.2
nrf52840dongle_nrf52840 FLASH 793416 793360 -56 -0.0
RAM 140937 140673 -264 -0.2
lock-app nrf52840dk_nrf52840 FLASH 788604 788548 -56 -0.0
RAM 118447 118183 -264 -0.2
pump-app nrf52840dk_nrf52840 FLASH 766084 766688 604 0.1
RAM 117114 117416 302 0.3
pump-controller-app nrf52840dk_nrf52840 FLASH 751528 752128 600 0.1
RAM 116873 117175 302 0.3
nxp contact mcxw71+release FLASH 690400 690296 -104 -0.0
RAM 61640 61376 -264 -0.4
lighting mcxw71+release FLASH 722208 722104 -104 -0.0
RAM 68308 68036 -272 -0.4
lock mcxw71+release FLASH 769008 768912 -96 -0.0
RAM 62004 61740 -264 -0.4
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1665436 1666148 712 0.0
RAM 211328 212972 1644 0.8
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1585012 1585716 704 0.0
RAM 208592 210236 1644 0.8
light cy8ckit_062s2_43012 FLASH 1454876 1454780 -96 -0.0
RAM 197248 196984 -264 -0.1
lock cy8ckit_062s2_43012 FLASH 1487204 1487108 -96 -0.0
RAM 224968 224704 -264 -0.1
qpg lighting-app qpg6200+debug FLASH 831224 831160 -64 -0.0
RAM 127788 127512 -276 -0.2
lock-app qpg6200+debug FLASH 768276 768228 -48 -0.0
RAM 118748 118480 -268 -0.2
realtek light-switch-app rtl8777g FLASH 703464 704080 616 0.1
RAM 106660 106692 32 0.0
lighting-app rtl8777g FLASH 755224 755224 0 0.0
RAM 127040 127040 0 0.0
stm32 light STM32WB5MM-DK FLASH 467724 467668 -56 -0.0
RAM 141400 141128 -272 -0.2
telink bridge-app tl7218x FLASH 708694 708642 -52 -0.0
RAM 91428 91164 -264 -0.3
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 797920 797868 -52 -0.0
RAM 42000 41736 -264 -0.6
light-app-ota-shell-factory-data tl7218x FLASH 789134 789082 -52 -0.0
RAM 94644 94380 -264 -0.3
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 715336 715904 568 0.1
RAM 52228 52556 328 0.6
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 748642 749210 568 0.1
RAM 71276 71604 328 0.5
light-switch-app-ota-factory-data tl3218x_retention FLASH 725482 726050 568 0.1
RAM 34976 35304 328 0.9
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 603346 603294 -52 -0.0
RAM 107436 107172 -264 -0.2
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 821756 821708 -48 -0.0
RAM 93040 92776 -264 -0.3

@github-actions
Copy link

github-actions bot commented Sep 18, 2025

PR #40607: Size comparison from 2f77e85 to e243577

Increases above 0.2%:

platform target config section 2f77e85 e243577 change % change
cc13x4_26x4 pump-app LP_EM_CC1354P10_6 RAM 96932 97220 288 0.3
pump-controller-app LP_EM_CC1354P10_6 RAM 97140 97436 296 0.3
esp32 all-clusters-app c3devkit DRAM 102592 102912 320 0.3
nrfconnect light-switch-app nrf52840dk_nrf52840 RAM 117902 118230 328 0.3
pump-app nrf52840dk_nrf52840 RAM 117114 117416 302 0.3
pump-controller-app nrf52840dk_nrf52840 RAM 116873 117175 302 0.3
psoc6 all-clusters cy8ckit_062s2_43012 RAM 211328 212972 1644 0.8
all-clusters-minimal cy8ckit_062s2_43012 RAM 208592 210236 1644 0.8
telink light-switch-app-ota-compress-lzma-factory-data tl7218x_retention RAM 52228 52556 328 0.6
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a RAM 71276 71604 328 0.5
light-switch-app-ota-factory-data tl3218x_retention RAM 34976 35304 328 0.9
Full report (44 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, efr32, esp32, nrfconnect, nxp, psoc6, qpg, realtek, stm32, telink)
platform target config section 2f77e85 e243577 change % change
bl602 lighting-app bl602+mfd+littlefs+rpc FLASH 1104392 1104392 0 0.0
RAM 178970 178706 -264 -0.1
bl702 lighting-app bl702+eth FLASH 658958 658764 -194 -0.0
RAM 135025 134769 -256 -0.2
bl702+wifi FLASH 835026 834832 -194 -0.0
RAM 124509 124237 -272 -0.2
bl706+mfd+rpc+littlefs FLASH 1068036 1067842 -194 -0.0
RAM 117333 117077 -256 -0.2
bl702l contact-sensor-app bl702l+mfd+littlefs FLASH 898276 898076 -200 -0.0
RAM 105676 105420 -256 -0.2
lighting-app bl702l+mfd+littlefs FLASH 981188 980738 -450 -0.0
RAM 109828 109572 -256 -0.2
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 768028 767976 -52 -0.0
RAM 103392 103128 -264 -0.3
lock-ftd LP_EM_CC1354P10_6 FLASH 779656 779604 -52 -0.0
RAM 108560 108288 -272 -0.3
pump-app LP_EM_CC1354P10_6 FLASH 725236 725836 600 0.1
RAM 96932 97220 288 0.3
pump-controller-app LP_EM_CC1354P10_6 FLASH 709712 710328 616 0.1
RAM 97140 97436 296 0.3
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 552970 552918 -52 -0.0
RAM 205168 204904 -264 -0.1
lock CC3235SF_LAUNCHXL FLASH 585694 585626 -68 -0.0
RAM 205400 205136 -264 -0.1
efr32 lock-app BRD4187C FLASH 959624 959560 -64 -0.0
RAM 126408 126148 -260 -0.2
BRD4338a FLASH 754960 754848 -112 -0.0
RAM 255732 255464 -268 -0.1
window-app BRD4187C FLASH 1053764 1053660 -104 -0.0
RAM 122604 122344 -260 -0.2
esp32 all-clusters-app c3devkit DRAM 102592 102912 320 0.3
FLASH 1775748 1776352 604 0.0
IRAM 83862 83862 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 914684 915308 624 0.1
RAM 152960 153288 328 0.2
nrf5340dk_nrf5340_cpuapp FLASH 677872 678364 492 0.1
RAM 153484 153812 328 0.2
light-switch-app nrf52840dk_nrf52840 FLASH 798208 798824 616 0.1
RAM 117902 118230 328 0.3
lighting-app nrf52840dk_nrf52840+rpc FLASH 856888 856832 -56 -0.0
RAM 133118 132854 -264 -0.2
nrf52840dongle_nrf52840 FLASH 793416 793360 -56 -0.0
RAM 140937 140673 -264 -0.2
lock-app nrf52840dk_nrf52840 FLASH 788604 788548 -56 -0.0
RAM 118447 118183 -264 -0.2
pump-app nrf52840dk_nrf52840 FLASH 766084 766688 604 0.1
RAM 117114 117416 302 0.3
pump-controller-app nrf52840dk_nrf52840 FLASH 751528 752128 600 0.1
RAM 116873 117175 302 0.3
nxp contact mcxw71+release FLASH 690400 690296 -104 -0.0
RAM 61640 61376 -264 -0.4
lighting mcxw71+release FLASH 722208 722104 -104 -0.0
RAM 68308 68036 -272 -0.4
lock mcxw71+release FLASH 769008 768912 -96 -0.0
RAM 62004 61740 -264 -0.4
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1665436 1666148 712 0.0
RAM 211328 212972 1644 0.8
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1585012 1585716 704 0.0
RAM 208592 210236 1644 0.8
light cy8ckit_062s2_43012 FLASH 1454876 1454780 -96 -0.0
RAM 197248 196984 -264 -0.1
lock cy8ckit_062s2_43012 FLASH 1487204 1487108 -96 -0.0
RAM 224968 224704 -264 -0.1
qpg lighting-app qpg6200+debug FLASH 831224 831160 -64 -0.0
RAM 127788 127512 -276 -0.2
lock-app qpg6200+debug FLASH 768276 768228 -48 -0.0
RAM 118748 118480 -268 -0.2
realtek light-switch-app rtl8777g FLASH 703464 704080 616 0.1
RAM 106660 106692 32 0.0
lighting-app rtl8777g FLASH 755224 755224 0 0.0
RAM 127040 127040 0 0.0
stm32 light STM32WB5MM-DK FLASH 467724 467668 -56 -0.0
RAM 141400 141128 -272 -0.2
telink bridge-app tl7218x FLASH 708694 708642 -52 -0.0
RAM 91428 91164 -264 -0.3
light-app-ota-compress-lzma-shell-factory-data tl3218x FLASH 797920 797868 -52 -0.0
RAM 42000 41736 -264 -0.6
light-app-ota-shell-factory-data tl7218x FLASH 789134 789082 -52 -0.0
RAM 94644 94380 -264 -0.3
light-switch-app-ota-compress-lzma-factory-data tl7218x_retention FLASH 715336 715904 568 0.1
RAM 52228 52556 328 0.6
light-switch-app-ota-compress-lzma-shell-factory-data tlsr9528a FLASH 748642 749210 568 0.1
RAM 71276 71604 328 0.5
light-switch-app-ota-factory-data tl3218x_retention FLASH 725482 726050 568 0.1
RAM 34976 35304 328 0.9
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 603346 603294 -52 -0.0
RAM 107436 107172 -264 -0.2
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 821756 821708 -48 -0.0
RAM 93040 92776 -264 -0.3

@mergify mergify bot merged commit 19207d5 into project-chip:master Sep 18, 2025
75 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

app cluster-decoupling Work for cluster decoupling: remove direct app-specific code dependency and allow unit testing core documentation Improvements or additions to documentation examples github lib review - approved scripts tests workflows

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants