Skip to content

Fix ESP32 IP_EVENT_ETH_GOT_IP event data handling in ESP32 platform #40660

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: v1.4-branch
Choose a base branch
from
Open

Fix ESP32 IP_EVENT_ETH_GOT_IP event data handling in ESP32 platform #40660

wants to merge 1 commit into from

Conversation

0x1abin
Copy link

@0x1abin 0x1abin commented Aug 20, 2025

Summary

Fix IP_EVENT_ETH_GOT_IP event data handling in ESP32 platform

Problem

When Ethernet interface gets an IP address, the log shows incorrect IP information:

I (4750) chip[DL]: IPv4 address available on Ethernet interface: 0.0.0.0/0.0.0.0 gateway 0.0.0.0

@0x1abin 0x1abin requested a review from a team as a code owner August 20, 2025 06:47
@CLAassistant
Copy link

CLAassistant commented Aug 20, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

gemini-code-assist[bot]
gemini-code-assist bot reviewed Aug 20, 2025
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes an issue where incorrect IP information was logged for Ethernet interfaces. By adding handling for the IP_EVENT_ETH_GOT_IP event, the event data is now properly copied, resolving the bug. I've added one suggestion to combine the new case with an existing one to reduce code duplication, in line with the project's style guide.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 20, 2025 •
edited
Loading

PR #40660: Size comparison from 2acb65b to 17b08df

Full report (88 builds for bl602, bl702, bl702l, cc13x4_26x4, cc32xx, cyw30739, efr32, esp32, linux, nrfconnect, nxp, psoc6, qpg, stm32, telink, tizen)
platform target config section 2acb65b 17b08df change % change
bl602 lighting-app bl602 FLASH 1281428 1281428 0 0.0
RAM 96056 96056 0 0.0
bl602+mfd FLASH 1309476 1309476 0 0.0
RAM 95704 95704 0 0.0
bl602+rpc FLASH 1335848 1335848 0 0.0
RAM 104032 104032 0 0.0
bl702 lighting-app bl702 FLASH 945040 945040 0 0.0
RAM 15121 15121 0 0.0
bl702+mfd FLASH 957750 957750 0 0.0
RAM 14785 14785 0 0.0
bl702+rpc FLASH 1051454 1051454 0 0.0
RAM 23677 23677 0 0.0
bl706-eth FLASH 658456 658456 0 0.0
RAM 24753 24753 0 0.0
bl706-wifi FLASH 825224 825224 0 0.0
RAM 13981 13981 0 0.0
bl702l lighting-app bl702l FLASH 961976 961976 0 0.0
RAM 16820 16820 0 0.0
bl702l+mfd FLASH 974738 974738 0 0.0
RAM 16484 16484 0 0.0
cc13x4_26x4 lighting-app LP_EM_CC1354P10_6 FLASH 829440 829440 0 0.0
RAM 123492 123492 0 0.0
lock-ftd LP_EM_CC1354P10_6 FLASH 814836 814836 0 0.0
RAM 125372 125372 0 0.0
pump-app LP_EM_CC1354P10_6 FLASH 761400 761400 0 0.0
RAM 113880 113880 0 0.0
pump-controller-app LP_EM_CC1354P10_6 FLASH 745628 745628 0 0.0
RAM 114056 114056 0 0.0
cc32xx air-purifier CC3235SF_LAUNCHXL FLASH 617354 617354 0 0.0
RAM 205964 205964 0 0.0
lock CC3235SF_LAUNCHXL FLASH 657678 657678 0 0.0
RAM 206092 206092 0 0.0
cyw30739 light CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 678397 678397 0 0.0
RAM 78708 78708 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 698249 698249 0 0.0
RAM 81348 81348 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 698249 698249 0 0.0
RAM 81348 81348 0 0.0
CYW930739M2EVB-02 unknown 2040 2040 0 0.0
FLASH 655185 655185 0 0.0
RAM 73776 73776 0 0.0
light-switch CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 614805 614805 0 0.0
RAM 71676 71676 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 634433 634433 0 0.0
RAM 74220 74220 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 634433 634433 0 0.0
RAM 74220 74220 0 0.0
lock CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 634125 634125 0 0.0
RAM 74716 74716 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 653833 653833 0 0.0
RAM 77260 77260 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 653833 653833 0 0.0
RAM 77260 77260 0 0.0
thermostat CYW30739B2-P5-EVK-01 unknown 2040 2040 0 0.0
FLASH 609389 609389 0 0.0
RAM 68804 68804 0 0.0
CYW30739B2-P5-EVK-02 unknown 2040 2040 0 0.0
FLASH 629241 629241 0 0.0
RAM 71444 71444 0 0.0
CYW30739B2-P5-EVK-03 unknown 2040 2040 0 0.0
FLASH 629241 629241 0 0.0
RAM 71444 71444 0 0.0
efr32 lighting-app BRD4187C FLASH 934084 934084 0 0.0
RAM 136292 136292 0 0.0
lock-app BRD2605a FLASH 741864 741856 -8 -0.0
RAM 232160 232160 0 0.0
BRD4338a FLASH 742304 742296 -8 -0.0
RAM 232044 232044 0 0.0
window-app BRD4187C FLASH 1018120 1018112 -8 -0.0
RAM 128220 128220 0 0.0
esp32 all-clusters-app c3devkit DRAM 95112 95112 0 0.0
FLASH 1542404 1542414 10 0.0
IRAM 82538 82538 0 0.0
m5stack DRAM 116040 116040 0 0.0
FLASH 1552446 1552458 12 0.0
IRAM 117039 117039 0 0.0
linux air-purifier-app debug unknown 4688 4688 0 0.0
FLASH 2781719 2781719 0 0.0
RAM 129688 129688 0 0.0
all-clusters-app debug unknown 5528 5528 0 0.0
FLASH 6085912 6085912 0 0.0
RAM 510792 510792 0 0.0
all-clusters-minimal-app debug unknown 5424 5424 0 0.0
FLASH 5419178 5419178 0 0.0
RAM 241432 241432 0 0.0
bridge-app debug unknown 5408 5408 0 0.0
FLASH 4752706 4752706 0 0.0
RAM 218608 218608 0 0.0
chip-tool debug unknown 6096 6096 0 0.0
FLASH 12725358 12725358 0 0.0
RAM 561250 561250 0 0.0
chip-tool-ipv6only arm64 unknown 20792 20792 0 0.0
FLASH 1135062 1135062 0 0.0
RAM 611632 611632 0 0.0
fabric-admin debug unknown 5792 5792 0 0.0
FLASH 11022921 11022921 0 0.0
RAM 560138 560138 0 0.0
fabric-bridge-app debug unknown 4632 4632 0 0.0
FLASH 4575510 4575510 0 0.0
RAM 205240 205240 0 0.0
lighting-app debug+rpc+ui unknown 6056 6056 0 0.0
FLASH 5692305 5692305 0 0.0
RAM 228648 228648 0 0.0
lock-app debug unknown 5344 5344 0 0.0
FLASH 4803308 4803308 0 0.0
RAM 204696 204696 0 0.0
ota-provider-app debug unknown 4720 4720 0 0.0
FLASH 4431692 4431692 0 0.0
RAM 198384 198384 0 0.0
ota-requestor-app debug unknown 4656 4656 0 0.0
FLASH 4570514 4570514 0 0.0
RAM 202952 202952 0 0.0
shell debug unknown 4216 4216 0 0.0
FLASH 3111869 3111869 0 0.0
RAM 159512 159512 0 0.0
thermostat-no-ble arm64 unknown 9464 9464 0 0.0
FLASH 4319808 4319808 0 0.0
RAM 243112 243112 0 0.0
tv-app debug unknown 5624 5624 0 0.0
FLASH 6043941 6043941 0 0.0
RAM 584448 584448 0 0.0
tv-casting-app debug unknown 5208 5208 0 0.0
FLASH 10852157 10852157 0 0.0
RAM 649184 649184 0 0.0
nrfconnect all-clusters-app nrf52840dk_nrf52840 FLASH 914312 914312 0 0.0
RAM 142398 142398 0 0.0
nrf7002dk_nrf5340_cpuapp FLASH 885316 885316 0 0.0
RAM 140545 140545 0 0.0
all-clusters-minimal-app nrf52840dk_nrf52840 FLASH 847612 847612 0 0.0
RAM 141292 141292 0 0.0
nxp contact k32w0+release FLASH 582104 582104 0 0.0
RAM 70984 70984 0 0.0
k32w1+release FLASH 596888 596888 0 0.0
RAM 63216 63216 0 0.0
mcxw71+release FLASH 596648 596648 0 0.0
RAM 63216 63216 0 0.0
light k32w0+release FLASH 618764 618764 0 0.0
RAM 70456 70456 0 0.0
k32w1+release FLASH 682936 682936 0 0.0
RAM 48840 48840 0 0.0
mcxw71+release FLASH 682936 682936 0 0.0
RAM 48840 48840 0 0.0
lock k32w1+release FLASH 705224 705224 0 0.0
RAM 67364 67364 0 0.0
mcxw71+release FLASH 705232 705232 0 0.0
RAM 67364 67364 0 0.0
psoc6 all-clusters cy8ckit_062s2_43012 FLASH 1646612 1646612 0 0.0
RAM 211464 211464 0 0.0
all-clusters-minimal cy8ckit_062s2_43012 FLASH 1552692 1552692 0 0.0
RAM 208272 208272 0 0.0
light cy8ckit_062s2_43012 FLASH 1468132 1468132 0 0.0
RAM 201240 201240 0 0.0
lock cy8ckit_062s2_43012 FLASH 1465332 1465332 0 0.0
RAM 225592 225592 0 0.0
qpg lighting-app qpg6105+debug FLASH 660608 660608 0 0.0
RAM 105444 105444 0 0.0
lock-app qpg6105+debug FLASH 618572 618572 0 0.0
RAM 99912 99912 0 0.0
stm32 light STM32WB5MM-DK FLASH 481888 481888 0 0.0
RAM 144892 144892 0 0.0
telink air-quality-sensor-app tlsr9528a_retention FLASH 620888 620888 0 0.0
RAM 50696 50696 0 0.0
all-clusters-app tlsr9118bdk40d FLASH 688240 688240 0 0.0
RAM 148552 148552 0 0.0
all-clusters-minimal-app tlsr9528a FLASH 781244 781244 0 0.0
RAM 110496 110496 0 0.0
bridge-app tlsr9258a FLASH 681070 681070 0 0.0
RAM 91352 91352 0 0.0
contact-sensor-app tlsr9528a_retention FLASH 620652 620652 0 0.0
RAM 50648 50648 0 0.0
light-switch-app-ota-shell-factory-data tlsr9528a FLASH 708644 708644 0 0.0
RAM 73984 73984 0 0.0
lighting-app-ota-factory-data tlsr9118bdk40d FLASH 625658 625658 0 0.0
RAM 144516 144516 0 0.0
lighting-app-ota-rpc-factory-data-4mb tlsr9518adk80d FLASH 811430 811430 0 0.0
RAM 99148 99148 0 0.0
lock-app-dfu tlsr9528a FLASH 656620 656620 0 0.0
RAM 66704 66704 0 0.0
ota-requestor-app tlsr9258a FLASH 697042 697042 0 0.0
RAM 90944 90944 0 0.0
pump-app-usb tlsr9518adk80d FLASH 634306 634306 0 0.0
RAM 55524 55524 0 0.0
pump-controller-app tlsr9518adk80d FLASH 611496 611496 0 0.0
RAM 52768 52768 0 0.0
shell tlsr9518adk80d FLASH 467876 467876 0 0.0
RAM 68168 68168 0 0.0
smoke_co_alarm-app tlsr9528a_retention FLASH 627956 627956 0 0.0
RAM 52356 52356 0 0.0
temperature-measurement-app-mars-ota tlsr9518adk80d FLASH 653634 653634 0 0.0
RAM 56316 56316 0 0.0
thermostat tlsr9518adk80d FLASH 638222 638222 0 0.0
RAM 53160 53160 0 0.0
window-covering tlsr9118bdk40d FLASH 524470 524470 0 0.0
RAM 97488 97488 0 0.0
tizen all-clusters-app arm unknown 4912 4912 0 0.0
FLASH 1727316 1727316 0 0.0
RAM 89200 89200 0 0.0
chip-tool-ubsan arm unknown 10848 10848 0 0.0
FLASH 18026362 18026362 0 0.0
RAM 7871476 7871476 0 0.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

esp32 platform

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@0x1abin @CLAassistant