Skip to content

Conversation

aqrln
Copy link
Member

@aqrln aqrln commented Oct 9, 2025

  • Bump @opentelemetry/* packages.
  • Align tracing functional tests with the latest SDK APIs.
  • Update @prisma/instrumentation README examples to match the new configuration patterns in @opentelemetry/sdk-trace-base@2.

Part of https://linear.app/prisma-company/issue/TML-1317/add-qc-support-in-local-ppg-with-accelerate-api

@aqrln aqrln added this to the 6.18.0 milestone Oct 9, 2025
@Copilot Copilot AI review requested due to automatic review settings October 9, 2025 16:48
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR upgrades OpenTelemetry dependencies to their latest versions and updates the tracing setup to use the new SDK APIs introduced in @opentelemetry/sdk-trace-base@2.

  • Bumps OpenTelemetry packages to newer versions and unifies them through workspace catalog
  • Migrates from deprecated APIs to new patterns (Resource constructor → resourceFromAttributes, provider.register() → trace.setGlobalTracerProvider())
  • Updates semantic convention imports to use the new ATTR_* naming convention

Reviewed Changes

Copilot reviewed 8 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
pnpm-workspace.yaml Adds new OpenTelemetry package versions to workspace catalog
packages/query-plan-executor/package.json Migrates to use catalog reference for sdk-trace-base
packages/instrumentation/README.md Updates documentation examples to use new OpenTelemetry v2 APIs
packages/client/tests/functional/tracing/tests.ts Migrates test setup to new API patterns and fixes span property access
packages/client/tests/functional/tracing-no-sampling/tests.ts Updates tracing setup with new APIs
packages/client/tests/functional/tracing-filtered-spans/tests.ts Updates tracing setup with new APIs
packages/client/tests/functional/tracing-disabled/tests.ts Updates tracing setup with new APIs
packages/client/package.json Bumps OpenTelemetry dependencies to latest versions
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Contributor

github-actions bot commented Oct 9, 2025

size-limit report 📦

Path Size
packages/client/runtime/library.js 197.77 KB (0%)
packages/client/runtime/library.d.ts 126.71 KB (0%)
packages/client/runtime/binary.js 658.34 KB (0%)
packages/client/runtime/binary.d.ts 26 B (0%)
packages/client/runtime/edge.js 166.66 KB (0%)
packages/client/runtime/edge-esm.js 166.12 KB (0%)
packages/client/runtime/wasm-engine-edge.js 128.78 KB (0%)
packages/client/runtime/index-browser.js 34.5 KB (0%)
packages/client/runtime/index-browser.d.ts 11.64 KB (0%)
packages/cli/build/index.js 2.63 MB (-0.01% 🔽)
packages/client/prisma-client-0.0.0.tgz 25.93 MB (-0.01% 🔽)
packages/cli/prisma-0.0.0.tgz 16.73 MB (-0.01% 🔽)
packages/bundle-size/da-workers-libsql/output.tgz 924.95 KB (0%)
packages/bundle-size/da-workers-neon/output.tgz 999.02 KB (0%)
packages/bundle-size/da-workers-pg/output.tgz 998.21 KB (0%)
packages/bundle-size/da-workers-planetscale/output.tgz 941.41 KB (0%)
packages/bundle-size/da-workers-d1/output.tgz 906.81 KB (0%)

@aqrln aqrln force-pushed the push-pvkqkltonwlz branch 2 times, most recently from 63005f3 to 7f1c927 Compare October 10, 2025 11:12
@aqrln aqrln changed the base branch from main to fix/revert-catalog October 10, 2025 11:27
Base automatically changed from fix/revert-catalog to main October 10, 2025 11:41
- Bump `@opentelemetry/*` packages and unify them using workspace
  catalog.
- Align tracing functional tests with the latest SDK APIs.
- Update `@prisma/instrumentation` README examples to match the new
  configuration patterns in `@opentelemetry/sdk-trace-base@2`.
@aqrln aqrln force-pushed the push-pvkqkltonwlz branch from 7f1c927 to 30ce209 Compare October 10, 2025 12:11
@aqrln aqrln merged commit c524934 into main Oct 10, 2025
813 of 814 checks passed
@aqrln aqrln deleted the push-pvkqkltonwlz branch October 10, 2025 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants