Skip to content

feat(adapter-mssql): make migration aware for use in prisma config adapter #28262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat(adapter-mssql): make migration aware for use in prisma config adapter #28262

wants to merge 1 commit into from
+20 −4

Conversation

tylerclendenin
Copy link
Contributor

Update the MSSQL adapter to be compatible with the prisma config file's defineConfig adapter option by implementing SqlMigrationAwareDriverAdapterFactory.

I added the connectToShadowDb method and updated the PrismaMssqlAdapter class to accept a release function which is called during dispose.

I used the adapter-pg as a template and adapted it.

Ref #9187

@jacek-prisma
Copy link
Contributor

Hi @tylerclendenin,
Making the adapter conform to the interface is not enough to enable its usage in the CLI - we also need to support it in our schema engine and this work is incomplete. I think it's better to not implement the interface for the time being until the MSSQL adapter is actually fully supported. Right now users attempting to use it in the CLI would see panics coming from the schema engine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@tylerclendenin @jacek-prisma