Skip to content

Conversation

Takur0
Copy link
Contributor

@Takur0 Takur0 commented Oct 22, 2024

This PR closes #25404

@Takur0 Takur0 marked this pull request as ready for review October 22, 2024 18:02
@aqrln
Copy link
Member

aqrln commented Oct 24, 2024

Hey @Takur0, thanks so much for the PR, the change looks good to me. Would you mind adding a test as well?

@aqrln aqrln modified the milestones: 5.21.0, 5.22.0 Oct 24, 2024
@jkomyno jkomyno self-assigned this Oct 24, 2024
@Takur0
Copy link
Contributor Author

Takur0 commented Oct 25, 2024

Hi @aqrln, thank you for reviewing my PR! I'm happy to add a test for this change. I'll update the PR soon.

@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Oct 25, 2024