-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix(adapter-d1): throws Error when string column contains any ISO date #25483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xPapla
approved these changes
Oct 23, 2024
Hey @Takur0, thanks so much for the PR, the change looks good to me. Would you mind adding a test as well? |
Hi @aqrln, thank you for reviewing my PR! I'm happy to add a test for this change. I'll update the PR soon. |
… into fix/d1AdapterDateBug
This PR closes #25404