fix(adapter-*): use Uint8Array #23114
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
size-limit report 📦
|
CodSpeed Performance ReportMerging #23114 will improve performances by 20.19%Comparing Summary
Benchmarks breakdown
|
SevInf
suggested changes
Feb 14, 2024
There was a problem hiding this comment.
Unfortinately, this code was added recently by me in #23047 to work around pg bug (brianc/node-postgres#2930). It got fixed, but not released yet. Without that coercion, lists of bytes will not be encoded correctly when passed to the DB (we probably need test for that on the client side).
When the fix is available in pg, we won't need fixArrayBufferValues function at all.
Note: pg will convert all typed arrays to Buffers anyway, so for them we might actually suggest to go node_compat mode even after the fix is released.
|
Thanks for the context! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.