Skip to content

feat(driver adapters): [public API] Rename flavour field to provider, remove close() #22179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Dec 4, 2023
Merged

feat(driver adapters): [public API] Rename flavour field to provider, remove close() #22179

merged 11 commits into from
Dec 4, 2023

Conversation

jkomyno
Copy link
Contributor

@jkomyno jkomyno commented Nov 30, 2023 •
edited
Loading

This PR closes #21865 and closes https://github.com/prisma/team-orm/issues/574.

These changes affect the DriverAdapter interface from @prisma/driver-adapter-utils:

  • flavour: string is now provider: string
  • close(): Promise<Result<void>> is no longer required by the public API

@jkomyno jkomyno self-assigned this Nov 30, 2023
@jkomyno jkomyno added this to the 5.7.0 milestone Nov 30, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Nov 30, 2023 •
edited
Loading

size-limit report 📦

Path Size
packages/client/runtime/library.js 195.96 KB (-0.02% 🔽)
packages/client/runtime/library.d.ts 100.13 KB (-0.12% 🔽)
packages/client/runtime/binary.js 627.67 KB (-0.01% 🔽)
packages/client/runtime/binary.d.ts 26 B (0%)
packages/client/runtime/edge.js 235.99 KB (-0.01% 🔽)
packages/client/runtime/edge-esm.js 235.77 KB (-0.01% 🔽)
packages/client/runtime/index-browser.js 33.5 KB (0%)
packages/client/runtime/index-browser.d.ts 11.96 KB (0%)
packages/cli/build/index.js 2.72 MB (0%)

@jkomyno jkomyno changed the title chore(driver-adapters): rename "flavour" to "provider" feat(driver adapters): [public API] Rename flavour field to provider Nov 30, 2023
@jkomyno jkomyno changed the title feat(driver adapters): [public API] Rename flavour field to provider feat(driver adapters): [public API] Rename flavour field to provider, remove close() Dec 1, 2023
SevInf
SevInf reviewed Dec 1, 2023
View reviewed changes
@jkomyno jkomyno marked this pull request as ready for review December 1, 2023 11:47
@jkomyno jkomyno requested a review from a team as a code owner December 1, 2023 11:47
@jkomyno jkomyno requested review from SevInf and aqrln and removed request for a team December 1, 2023 11:47
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 1, 2023 •
edited
Loading

🟢 All good, this PR is no longer uses custom engine.

aqrln
aqrln reviewed Dec 3, 2023
View reviewed changes
Copy link
Member

@aqrln aqrln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please also remove the close method from libSQL adapter? If it's not required by the engine, let's not add extra things to the public API surface, users can call client.close() directly

@shiyuhang0
Copy link

shiyuhang0 commented Dec 4, 2023 •
edited
Loading

Hi, Which version will these adapters be released in?

@jkomyno jkomyno mentioned this pull request Dec 4, 2023
Closed
@jkomyno jkomyno requested a review from aqrln December 4, 2023 14:05
@aqrln
Copy link
Member

aqrln commented Dec 4, 2023 •
edited by janpio
Loading

@shiyuhang0 5.7.0 tomorrow Wednesday

@jkomyno jkomyno merged commit 4c493a1 into main Dec 4, 2023
@jkomyno jkomyno deleted the feat/driver-adapters-public-api branch December 4, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aqrln aqrln aqrln approved these changes

+1 more reviewer

@SevInf SevInf SevInf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jkomyno jkomyno

Labels

None yet

Projects

None yet

Milestone

5.7.0

Development

Successfully merging this pull request may close these issues.

[Driver Adapters]: rename flavour public field to provider

4 participants

@jkomyno @shiyuhang0 @aqrln @SevInf