-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix: Unskip failing test in planetscale related to dates #21806
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
size-limit report 📦
|
Blocked until prisma/prisma-engines#4422 is merged |
Waiting to update prisma main with latest engines' after merging prisma/prisma-engines#4422, There's a PR open for the integration branch in #21831 and I'm looking for an (a priori unrelated) failing test |
Actually the offending test in #21831 passes locally, so I will merge this PR as soon as the new version of engines is published and bumped either in main or here (whatever happens before)
|
PR for engine update is here, but failing some tests that are blocking the merge: #21832 (I just rebased which will also run tests again, maybe it was just flaky) |
I actually merged the PR, but it was indeed not flaky. 😅 See the failing test for Planetscale, it's the same error in this PR now that it's sync with main |
So technically not blocking this PR, but someone needs to have a look |
I'm taking a look. |
Ok, fix: prisma/prisma-engines#4426, The reason for the flakeyness, is that there is a lag between the create and the update, of up to a hundred milleseconds. Sometimes that makes it to the next second since epoch and the test passed. There was an underlying bug, tho. DateTimes didn't include franctionals in main. I'm merging this, in the light of prisma/prisma-engines#4426 |
Close https://github.com/prisma/team-orm/issues/517
Requires prisma/prisma-engines#4422 to be merged and integrated into prisma/prisma before merging