Skip to content

fix(client): initialize generic parameters of ExtendsHook #20131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

fix(client): initialize generic parameters of ExtendsHook #20131

wants to merge 3 commits into from

Conversation

adamjkb
Copy link

@adamjkb adamjkb commented Jul 9, 2023

Fixes #20128

Explicitly initializes the default state of the ExtendsHook interface so in a JS environment they don't default to anyand breaking the Client's type.

The any fallback is one of the difference how JS is different from TS: microsoft/TypeScript#30009 (comment)

The change in the PR is just defining the default explicitly but—as far as I can tell— Typescript already does this implicitly.

@adamjkb adamjkb requested a review from a team as a code owner July 9, 2023 12:24
@adamjkb adamjkb requested review from Jolg42 and millsp and removed request for a team July 9, 2023 12:24
@CLAassistant
Copy link

CLAassistant commented Jul 9, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@adamjkb adamjkb marked this pull request as draft July 16, 2023 21:31
@adamjkb
Copy link
Author

adamjkb commented Jul 16, 2023 •
edited
Loading

This is in fact breaking types from external plugins. So it might not be as simple as this. (Briefly tested it w/ withAccelerate and it resulted in the same issue as in the original issue.)

@millsp
Copy link
Contributor

millsp commented Oct 26, 2023

@adamjkb what would be the next steps?

@apolanc apolanc added the PR: Bug A PR That Fixes a bug label Mar 13, 2024
@adamjkb