fix(client): initialize generic parameters of ExtendsHook #20131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
This is in fact breaking types from external plugins. So it might not be as simple as this. (Briefly tested it w/ |
|
@adamjkb what would be the next steps? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20128
Explicitly initializes the default state of the ExtendsHook interface so in a JS environment they don't default to
anyand breaking the Client's type.The
anyfallback is one of the difference how JS is different from TS: microsoft/TypeScript#30009 (comment)The change in the PR is just defining the default explicitly but—as far as I can tell— Typescript already does this implicitly.