Skip to content

feat(client): Remove runtime/index.js build #20049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 7, 2023
Merged

feat(client): Remove runtime/index.js build #20049

merged 5 commits into from
Jul 7, 2023

Conversation

SevInf
Copy link
Contributor

@SevInf SevInf commented Jul 4, 2023

File is not used by generated client since engine-specific runtimes
were introduced and produced a warning on direct import.

BREAKING CHANGE

Close #19316

@SevInf SevInf added this to the 5.0.0 milestone Jul 4, 2023
@SevInf
Copy link
Contributor Author

SevInf commented Jul 4, 2023

Accelerate PR: https://github.com/prisma/prisma-extension-accelerate/pull/25

@SevInf SevInf force-pushed the feat/remove-runitme-index branch 2 times, most recently from 495c785 to 5365088 Compare July 4, 2023 13:51
@millsp
Copy link
Contributor

millsp commented Jul 5, 2023

Looks good. Maybe worth checking if this had any unintended interaction with the Deno preview feature (iirc, there was some weirdness with type re-exports)? Running an integration version should clear that up.

@millsp
Copy link
Contributor

millsp commented Jul 5, 2023 •
edited
Loading

The changes for Accelerate seem safe, as we have had library.d.ts point to index.d.ts in the past, so it should be backwards compatible even. Do you know how far back this comes from, in which release was it introduced for the first time?

Sergey Tatarintsev added 5 commits July 7, 2023 11:13
feat(client): Remove runtime/index.js build
151363c 
File is not used by generated client since engine-specific runtimes
were introduced and produced a warning on direct import.

BREAKING CHANGE

Close #19316
Fix declaration test
ebc8822
fix default-index
07c1a13
Fix e2e test
f346f7c
TMP: dev accelerate extension
1be63c6
@SevInf SevInf force-pushed the feat/remove-runitme-index branch from 6bdf56a to 1be63c6 Compare July 7, 2023 09:20
SevInf
SevInf commented Jul 7, 2023
View reviewed changes
@codspeed-hq
Copy link

codspeed-hq bot commented Jul 7, 2023

CodSpeed Performance Report

Merging #20049 will degrade performances by 50.67%

Comparing feat/remove-runitme-index (1be63c6) with main (d185fba)

Summary

❌ 1 regressions
✅ 3 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main feat/remove-runitme-index Change
❌ typescript compilation ~50 Models 78.5 ms 159 ms -50.67%

@SevInf SevInf marked this pull request as ready for review July 7, 2023 10:19
@SevInf SevInf requested a review from a team as a code owner July 7, 2023 10:19
@SevInf SevInf requested review from Druue and Jolg42 and removed request for a team July 7, 2023 10:19
@SevInf SevInf merged commit 6374c13 into main Jul 7, 2023
@SevInf SevInf deleted the feat/remove-runitme-index branch July 7, 2023 10:38
@Jolg42 Jolg42 mentioned this pull request Jul 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Druue Druue Awaiting requested review from Druue Druue was automatically assigned from prisma/orm-ts-maintain

2 more reviewers

@Jolg42 Jolg42 Jolg42 approved these changes

@millsp millsp millsp approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@SevInf SevInf

Labels

None yet

Projects

None yet

Milestone

5.0.0

Development

Successfully merging this pull request may close these issues.

Prisma Client: remove runtime/index.js bundle from client

3 participants

@SevInf @millsp @Jolg42