forked from freedomofpress/securedrop
-
Notifications
You must be signed in to change notification settings - Fork 0
[pull] develop from freedomofpress:develop #196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…letion Adopts the native "dict" type available since Python 3.9. thread: #7672 (comment)
…of event handlers thread: #7672 (comment)
…potence Most applications return the original result for subsequent calls to an idempotent operation. In our case, we just have to indicate that we've already processed the event, since (a) the client already knows the expected result of the operation and can apply it locally, and (b) in the event of any conflict or drift it should catch up to the server within the same (or at worst one additional) sync period.
…s-journalist collisions/leakage Journalists are trusted users, but there's no reason to allow either collisions or leakage in a global Event.id namespace (as opposed to global ordering). thread: #7672 (comment)
The original comment came verbatim from journalist_app.utils. Co-authored-by: Kunal Mehta <[email protected]>
…ric ValueError thread: #7672 (comment)
Co-authored-by: Kunal Mehta <[email protected]>
This lets us (a) guarantee we have an Event.id to order on, (b) narrow EventHandler.process() to take only Event objects instead of dictionaries, and (c) short-circuit all processing if any event is invalid. thread: #7672 (comment)
…nt races as well as enforce idempotence
As a side effect, processing of the entire BatchRequest short-circuits on any failure of validation, not just deserialization. thread: #7672 (comment)
…tion The tests.utils.ascii_armor() helper function is courtesy of ChatGPT.
`/api/v2/data`: handle batched events from clients
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )