Skip to content

refactor(): use mime in stead of mime-types so we don't rely on NodeJS built-in modules #1417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 19, 2025
Merged

refactor(): use mime in stead of mime-types so we don't rely on NodeJS built-in modules #1417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2ee75d0
refactor(): use mime in stead of mime-types so we don't rely on NodeJ…
patricksevat Sep 10, 2025
5352e35
Merge branch 'develop' of github.com:postmanlabs/postman-collection i…
appurva21 Sep 19, 2025
ef2d232
chore: update changelog
appurva21 Sep 19, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
unreleased:
new features:
- GH-1418 Add new key `requests` to Script
chores:
- GH-1417 Use mime instead of mime-types

5.1.1:
date: 2025-09-05
Expand Down
4 changes: 2 additions & 2 deletions lib/content-info/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
var util = require('../util'),
_ = util.lodash,
fileType = require('file-type'),
mimeType = require('mime-types'),
mime = require('mime'),
mimeFormat = require('mime-format'),

/**
Expand Down Expand Up @@ -285,7 +285,7 @@ var util = require('../util'),
mimeType: normalized.type, // sanitized mime type base
mimeFormat: normalized.format, // format specific to the type returned
charset: normalized.charset || CHARSET_UTF8,
extension: detectedExtension || mimeType.extension(normalized.source) || E
extension: detectedExtension || mime.getExtension(normalized.source) || E
};
},

Expand Down
27 changes: 21 additions & 6 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"liquid-json": "0.3.1",
"lodash": "4.17.21",
"mime-format": "2.0.2",
"mime-types": "2.1.35",
"mime": "3.0.0",
"postman-url-encoder": "3.0.8",
"semver": "7.7.1",
"uuid": "8.3.2"
Expand Down
Loading