pkp/pkp-lib#9295 client side only implementation for issue selection #5117
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c823943 to
52f858d
Compare
52f858d to
cde8ca9
Compare
asmecher
approved these changes
Oct 8, 2025
| + array_slice($menu, $index + 1, null, true); | ||
| } | ||
|
|
||
| $menu['content']['submenu'] = ['issues' => $issuesLink] + $menu['content']['submenu']; |
There was a problem hiding this comment.
This change seems unrelated? Blessie was working on moving issue to the content menu. So maybe it somehow slipped here?
|
|
||
| if (in_array(JournalContentOption::CATEGORY_LISTING->value, $activeTheme->getOption('journalContentOrganization'))) { | ||
| if (in_array(JournalContentOption::CATEGORY_LISTING->value, $journalContentOptions)) { | ||
| $categories = Repo::category() |
There was a problem hiding this comment.
Curious what this is addressing?
jardakotesovec
approved these changes
Oct 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for pkp/pkp-lib#9295 cleanup