fix: SVG multi-subpath rendering with default fill-rule #11727
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐛 Problem
SVG
<path>elements with multiple subpaths (compound paths with holes) were only rendering correctly whenfill-rule="evenodd"was explicitly specified. Paths without afill-ruleattribute (which defaults tononzeroper SVG spec) were rendering as solid shapes instead of showing holes.Example:


Before:
After:
🔍 Root Cause
File:
src/scene/graphics/shared/svg/SVGParser.ts:150Only processed holes when
fill-rule="evenodd"was explicitly set, ignoring the SVG default behavior.✅ Solution
Changed hole processing logic to handle multi-subpath SVGs regardless of explicit
fill-ruleattribute:Logic:
nonzero"evenodd""nonzero"Since PixiJS uses containment-based hole detection, NOT true nonzero winding direction or evenodd crossing count. This works correctly for most real-world SVGs but isn't fully spec-compliant.
🧪 Tests
Added visual regression tests with social media icon SVGs:
svg-icon-google.scene.ts- Single path validationsvg-icon-twitter-x.scene.ts- Single path validationsvg-icon-discord.scene.ts- Single path validationsvg-icon-instagram.scene.ts- Multi-path with holes (validates fix)svg-icons-comparison.scene.ts- Grid comparisonAll existing
svg-fill-rule-*tests still pass ✅📊 Impact
fill-rulefill-rule="evenodd"fill-rule="nonzero"No breaking changes - all existing functionality preserved.
✨ Result
Icon SVGs (Instagram, social media icons, etc.) now render correctly without requiring manual
fill-ruleattributes.npm run lint)npm run test)