Skip to content

Fixed checking if file exist when restoring from recycle bin with empty #18646

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 27, 2025
Merged

Fixed checking if file exist when restoring from recycle bin with empty #18646

merged 2 commits into from
Aug 27, 2025

Conversation

cuca24
Copy link
Contributor

@cuca24 cuca24 commented Aug 26, 2025 •
edited
Loading

Changes in this pull request

Resolves #18645

Additional info

@github-actions GitHub Actions
Copy link

Review Checklist

  • Target branch (11.5 for bug fixes, others 12.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

kingjia90
kingjia90 reviewed Aug 26, 2025
View reviewed changes
@mcop1 mcop1 linked an issue Aug 27, 2025 that may be closed by this pull request
[Bug]: Restore from Recyclebin not working when using azure blob or potentially other systems except the local disk #18645
Closed
@mcop1 mcop1 added this to the 12.1.4 milestone Aug 27, 2025
@kingjia90 kingjia90 added the Bug label Aug 27, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@kingjia90 kingjia90 merged commit cb06a1a into pimcore:12.1 Aug 27, 2025
13 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kingjia90 kingjia90 kingjia90 left review comments

Assignees

@kingjia90 kingjia90

Labels
Bug
Projects
None yet
Milestone
12.1.4
Development

Successfully merging this pull request may close these issues.

[Bug]: Restore from Recyclebin not working when using azure blob or potentially other systems except the local disk
3 participants
@cuca24 @kingjia90 @mcop1