Skip to content

[Bug]: env variable PIMCORE_CLASS_DEFINITION_DIRECTORY causes double loading #18605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Aug 27, 2025
Merged

[Bug]: env variable PIMCORE_CLASS_DEFINITION_DIRECTORY causes double loading #18605

merged 6 commits into from
Aug 27, 2025

Conversation

robertSt7
Copy link
Contributor

resolves #17938

@robertSt7 robertSt7 added the Bug label Aug 6, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 6, 2025

Review Checklist

  • Target branch (11.5 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@robertSt7
Copy link
Contributor Author

@fashxp @kingjia90 @bluvulture Could this be a possible fix for #17938 ?

@kingjia90 kingjia90 self-assigned this Aug 20, 2025
@kingjia90 kingjia90 linked an issue Aug 20, 2025 that may be closed by this pull request
[Bug]: env variable PIMCORE_CLASS_DEFINITION_DIRECTORY causes double loading #17938
Closed
kingjia90
kingjia90 requested changes Aug 21, 2025
View reviewed changes
Copy link
Contributor

@kingjia90 kingjia90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a micro-optimization

@kingjia90 kingjia90 added this to the 11.5.9 milestone Aug 27, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@kingjia90 kingjia90 merged commit 6a9e016 into 11.5 Aug 27, 2025
19 checks passed
@kingjia90 kingjia90 deleted the fix-double-load branch August 27, 2025 08:21
@github-actions github-actions bot locked and limited conversation to collaborators Aug 27, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kingjia90 kingjia90 kingjia90 requested changes

Assignees

@kingjia90 kingjia90

Labels
Bug
Projects
None yet
Milestone
11.5.9
Development

Successfully merging this pull request may close these issues.

[Bug]: env variable PIMCORE_CLASS_DEFINITION_DIRECTORY causes double loading
2 participants
@robertSt7 @kingjia90