fix: error translating quantity value unit without abbreviation #18321
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review Checklist
|
|
Note that #18313 wants to change the same line. |
Pimcore\Translation\Translator::trans(): Argument #1 ($id) must be of type string, null given Fixed by adding a condition to check whether abbreviation is null and using the untranslated ID instead.
|
|
@kjkooistra-youwe I am not able to save a unit with null in abbreviation. For me the abbreviation is always an empty string, even when I export it, write null as value and import it. Could you please provide more information? Thanks |
|
@robertSt7 The units were created by an import via the PHP API. If the abbreviation is not set there it's null. I updated the initial comment to clarify this. |
|
@kjkooistra-youwe Thanks for fixing this null error |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pimcore\Translation\Translator::trans(): Argument #1 ($id) must be of type string, null given
Fixed by adding a condition to check whether abbreviation is null and using the untranslated ID instead.
To reproduce, set a quantity value with a unit without an abbreviation. This unit would be created via the PHP API.
Encountered this error in the messenger failed queue of an import because it creates units for use in the Pimcore, but it doesn't provide any additional details (like abbreviation).