Allow "_" in object brick / field collection class names #17881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…data object class names)
Review Checklist
|
50a6b88 to
473c3fe
Compare
…data object class names)
jdreesen
reviewed
Dec 2, 2024
Co-authored-by: Jacob Dreesen <[email protected]>
|
|
You are right, @jdreesen - thanks. Let's see what SonarQube thinks now ;-) Edit:
Imho it does not make sense to support unicode here because then also non-ASCII characters would be allowed. Have I overseen something? |
Agree with you, it's not necessary and does not make sense. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For data object classes it is allowed to use
_in class names:pimcore/models/DataObject/ClassDefinition.php
Lines 351 to 353 in 679e2f2
But for object brick and field collection classes, this is currently not the case. From technical perspective this does not seem to have a valid reason - even for some features like column sorting / filtering in the grid,
_is not used as separator between brick and field name (instead there~is used which is fine because this is not a valid character for PHP class names).So to be consistent, this PR adds support for
_also for object brick and field collection class names.Note: I replaced
[a-zA-Z0-9_]with\win the regular expression because of your SonarCube rule: