Skip to content

[Bug]: Error from Migrations - call on null $this->container #17804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 8, 2024
Merged

[Bug]: Error from Migrations - call on null $this->container #17804

merged 1 commit into from
Nov 8, 2024

Conversation

kingjia90
Copy link
Contributor

@kingjia90 kingjia90 commented Nov 7, 2024 •
edited
Loading

Changes in this pull request

Potentially resolves https://pimcore.atlassian.net/browse/PEES-436

Additional info

This PR should avoid this error
image

By looking at some other migration

pimcore/bundles/CoreBundle/src/Migrations/Version20221028115803.php

Line 53 in 3ffaeac

$class->generateClassFiles(true);

which leads to

pimcore/models/DataObject/ClassDefinition.php

Line 418 in 3ffaeac

Pimcore::getContainer()->get(PHPClassDumperInterface::class)->dumpPHPClasses($this);

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

Review Checklist

  • Target branch (11.4 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@kingjia90 kingjia90 changed the title replace this->container [Bug]: Error from Migrations - call on null $this->container Nov 7, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Nov 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ghost ghost added this to the 11.4.2 milestone Nov 8, 2024
@kingjia90 kingjia90 merged commit 89d5fe7 into 11.4 Nov 8, 2024
20 checks passed
@kingjia90 kingjia90 deleted the container branch November 8, 2024 07:30
@github-actions github-actions bot locked and limited conversation to collaborators Nov 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug Pimcore:ToDo
Projects
None yet
Milestone
11.4.2
Development

Successfully merging this pull request may close these issues.
1 participant
@kingjia90