Skip to content

Fix: EncryptedField getDataForGrid return typehint is defined as array while it could returns string #17778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 10, 2024
Merged

Fix: EncryptedField getDataForGrid return typehint is defined as array while it could returns string #17778

merged 6 commits into from
Dec 10, 2024

Conversation

blankse
Copy link
Contributor

@blankse blankse commented Oct 28, 2024

Changes in this pull request

Resolves #17777

Additional info

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 28, 2024 •
edited by robertSt7
Loading

Review Checklist

  • Target branch (11.4 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@blankse blankse mentioned this pull request Oct 28, 2024
Closed
@ghost ghost added the Pimcore:ToDo label Oct 29, 2024
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@robertSt7 robertSt7 self-assigned this Nov 21, 2024
@robertSt7 robertSt7 added this to the 11.4.4 milestone Dec 10, 2024
@robertSt7 robertSt7 merged commit a3c4cde into pimcore:11.4 Dec 10, 2024
20 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2024
@robertSt7
Copy link
Contributor

@blankse Thanks a lot for the fix and your contribution.

@blankse blankse deleted the fix_encrypted_field branch December 10, 2024 08:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@robertSt7 robertSt7 robertSt7 left review comments

Assignees

@robertSt7 robertSt7

Labels
Pimcore:ToDo
Projects
None yet
Milestone
11.4.4
Development

Successfully merging this pull request may close these issues.
2 participants
@blankse @robertSt7