Skip to content

[Bug] Get values must be static #17714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 19, 2024
Merged

[Bug] Get values must be static #17714

merged 2 commits into from
Nov 19, 2024

Conversation

mattamon
Copy link
Contributor

Changes in this pull request

Resolves #17701

Additional info

Get Values must be static because of static enum values.

@mattamon mattamon added this to the 11.4.2 milestone Oct 11, 2024
@github-actions GitHub Actions
Copy link

Review Checklist

  • Target branch (11.4 for bug fixes, others 11.x)
  • Tests (if it's testable code, there should be a test for it - get help)
  • Docs (every functionality needs to be documented, see here)
  • Migration incl. install.sql (e.g. if the database schema changes, ...)
  • Upgrade notes (deprecations, important information, migration hints, ...)
  • Label
  • Milestone

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@mattamon mattamon requested a review from kingjia90 October 14, 2024 07:36
@kingjia90 kingjia90 self-assigned this Nov 19, 2024
@kingjia90 kingjia90 merged commit 9a7827c into 11.4 Nov 19, 2024
21 checks passed
@kingjia90 kingjia90 deleted the 17701-get-values-must-be-static branch November 19, 2024 12:07
@github-actions github-actions bot locked and limited conversation to collaborators Nov 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kingjia90 kingjia90 Awaiting requested review from kingjia90

Assignees

@kingjia90 kingjia90

Labels
Bug Pimcore:ToDo
Projects
None yet
Milestone
11.4.2
Development

Successfully merging this pull request may close these issues.
3 participants
@mattamon @kingjia90 @kevinloeber-twocream