Fix fallback language for boolean fields with two fallback languages #17621
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have a model with a boolean field
active
Say we have 3 languages, English, Dutch and German and the fallback languages for German are Dutch -> English in this order.
The model looks like this:
1
-1
Empty
We would expect the
active
value of German to be-1
because the fallback language of German is Dutch and the value in Dutch is actually filled inBut because of the check on line 472, it thinks the value is falsy so it needs to check the next language
In my proposed change we actually check if the field is empty before checking the next language, like is done on line 468