-
Couldn't load subscription status.
- Fork 27
feat[path]: added mockModeList & hardValidationList #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
simply add this line in your config for mock mode to be enabled for /v1/enshittification |
|
Can we code it such that paths:
/v1/enshittification:
mockMode: true |
I agree that this would be ideal, the problem is that I tried creating a test as such ^, and it wouldn't work. My assumption was that the |
I designed it so we don't overload configurations with configurations and we end up with a DSL for a config. I think keeping this as a separate configuration is the right design, it makes the config more verbose, but it keeps it clean. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have any comments or feedback. Sorry, PR is clean and it does exactly what is required of the feature and it follows all the existing designs in place.
|
There is a test failure, it could be due to an out of date |
The description n in the https://api.pb33f.io/wiretap/giftshop-openapi.yaml changed from `A t-shirt with the pb33f logo on it`-> `A t-shirt with the pb33f logo on the front`
01cb7bf to
402f8e0
Compare
It was due to an update in the https://api.pb33f.io/wiretap/giftshop-openapi.yaml spec. I did still bump the deps tho 👍 ⚡ |
|
docs updated. good to go! |
Changes:
mockModeList&hardValidationListMotive:
The documentation needs to be updated now. I don't think the docs are open source. Is there anyway I could change it?
Please feel free to nitpick the entire MR! I genuinely want to see the best. Even if they are small nitpicks that don't really matter, I genuinely appreciate every perspective 🙏